💬 theStack commented on pull request "test: added coverage to mining_basic.py":
(https://github.com/bitcoin/bitcoin/pull/27603#discussion_r1189840647)
nit: could just directly serialize a newly created temporary CBlock() instance, instead of creating a new variable
```suggestion
self.log.info("submitblock: Test block decode failure with empty vtx")
assert_raises_rpc_error(-22, "Block does not start with a coinbase", node.submitblock, CBlock().serialize().hex())
```
Would also suggest to move this down to the test checking the other condition for the same error message ("submitblock: Test invalid coinbase transaction").

💬 0xB10C commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542136632)
post-merge ACK

💬 josibake commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1542154805)
> > Using this command to identify those peers: `bitcoin-cli getpeerinfo | jq -r '.[] | if (.bytessent_per_msg.inv > 100000 and .bytesrecv_per_msg.inv == null) then .addr else empty end'`
>
> Someone posted https://news.ycombinator.com/item?id=35824998 linking to a DoS script https://github.com/visualbasic6/drain/blob/c8373b55d83832f95fb0a77aca56436adeffb58d/drain-btc.py a day before this issue. It's possible someone may be using the script targeting public nodes.
>
> Check your `bytessent
...

💬 kevkevinpal commented on pull request "test: added coverage to mining_basic.py":
(https://github.com/bitcoin/bitcoin/pull/27603#discussion_r1189865879)
FIxed in [a7b46a1](https://github.com/bitcoin/bitcoin/pull/27603/commits/a7b46a1feae60e38fe4bdcacf5034f44cae49222)

Thanks for the suggestion!

⚠️ Jackwumingjie opened an issue: "Method not found"
(https://github.com/bitcoin/bitcoin/issues/27617)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

<img width="1018" alt="企业微信截图_958a8dcb-6942-407e-a01b-14eee3df3e14" src="https://github.com/bitcoin/bitcoin/assets/39093109/8059bcd8-967f-41b9-9eb6-3a9425f97b2e">
I build the node with ubuntu20.04 and 24.0.1. But some api return the error as the picture. The run command "bitcoind -datadir=/data2/.btc/data -rpcuser="xxxx" -rpcpass
...

💬 fanquake commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542160043)
Did you compile with wallet support?

💬 fjahr commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1542165949)
@jamesob What's your feeling on how important figuring out the fix for the pruning issue is at the moment? People don't consider it blocking #24008, right? Just curious about where to spend review time right now. FWIW, I noted the same issue on `getblockfrompeer` and wrote a test for it back then, in case you haven't seen it, it might come in handy: https://github.com/bitcoin/bitcoin/pull/23813

💬 Jackwumingjie commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542169819)
How to compile with wallet support?

💬 Jackwumingjie commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542172628)
My compile steps:
sudo mkdir /data/.btc && cd /data/.btc
sudo git clone https://github.com/bitcoin/bitcoin.git
cd bitcoin
sudo ./autogen.sh
sudo ./configure
sudo make
sudo make install

💬 kouloumos commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542174130)
You are probably missing the SQLite or BDB dependency to compile the wallet. When you run `./configure` make sure that summary (that's in your `config.log`) shows `with wallet = yes`.

If that's the case, you'll need to install the dependencies and then recompile following the steps you done before (`./configure`, `make`, etc.)

See also https://github.com/bitcoin/bitcoin/issues/26193.

💬 0xB10C commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1542178451)
Concept ACK

💬 willcl-ark commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1542181711)
ACK 5b34060

Currently running this cherry-picked on top of v24.0.1 on mainnet and seeing reduced resource usage.

👍 theStack approved a pull request: "test: added coverage to mining_basic.py"
(https://github.com/bitcoin/bitcoin/pull/27603#pullrequestreview-1420617170)
ACK a7b46a1feae60e38fe4bdcacf5034f44cae49222

💬 instagibbs commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1542201540)
ACK https://github.com/bitcoin/bitcoin/pull/27610/commits/5b3406094f2679dfb3763de4414257268565b943

Significant reduction in CPU usage when influx of transactions is high and sustained. Allows an additional INV to trickle per additional 200 INV backlog.

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1542220359)
trivial re-ACK 886a473fc48f2c7d67436b5d9ac5643cd007e27f 🐗

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: trivial re-ACK 886a
...

💬 sdaftuar commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1189926154)
Oops -- will fix in a followup. Thanks for catching.

💬 kouloumos commented on issue "rpc: Allow importing wallets by data instead of by filename":
(https://github.com/bitcoin/bitcoin/issues/27597#issuecomment-1542272946)
Is there a specific reason that you need to pass around the whole wallet? You might be able to do a work-around with descriptor wallets (default wallet type since [23.0](https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-23.0.md#wallet)) using the `{list,import}descriptors` RPCs.

💬 fanquake commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542275484)
Ok. This isn't a bug, and can be fixed by reading the documentation. i.e https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md. Closing for now.

✅ fanquake closed an issue: "Method not found"
(https://github.com/bitcoin/bitcoin/issues/27617)

💬 Zero-1729 commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542296157)
Post merge ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

Verified key fingerprint checks out in my local keychain.