💬 jamesob commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542307429)
ACK russ

💬 jamesob commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542309525)

I'm also unable to verify the GPG key.

📝 MarcoFalke converted_to_draft a pull request: "ci: Run iwyu on all src files"
(https://github.com/bitcoin/bitcoin/pull/27571)
This makes it easier to look at the CI output of a file without having to manually add it first to the list.

🤔 instagibbs reviewed a pull request: "rpc: allow submitpackage to be called outside of regtest"
(https://github.com/bitcoin/bitcoin/pull/27609#pullrequestreview-1420792155)
concept ACK

💬 instagibbs commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#discussion_r1190006006)
the string `packagerelay` doesn't exist yet in the codebase

💬 Jackwumingjie commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542318987)
@fanquake I have installed the sqlite, but other error display:
<img width="1078" alt="image" src="https://github.com/bitcoin/bitcoin/assets/39093109/a989acd1-9867-4dd4-b2c2-e1ebc9822660">

💬 MarcoFalke commented on issue "The `libbitcoinkernel` Project":
(https://github.com/bitcoin/bitcoin/issues/24303#issuecomment-1542335212)
Let's continue discussion in #27587?

✅ MarcoFalke closed an issue: "The `libbitcoinkernel` Project"
(https://github.com/bitcoin/bitcoin/issues/24303)

💬 0xB10C commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#issuecomment-1542339344)
Compared where the time is spent in the `b-msghand` thread on a mainnet `master` and a mainnet 5b3406094f2679dfb3763de4414257268565b943 node that were both running for a while. Followed [eklitzke's flamegraph.md](https://github.com/eklitzke/bitcoin/blob/flamegraphs/doc/flamegraphs.md#generating-a-profile) to create the flamegraphs below. This seems to be indeed a nice performance improvement. The second flamegraph looks _healthier_.

`master`:

![flamegraph-master](https://github.com/bitcoi
...

💬 sipa commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542347503)
@Jackwumingjie Did you recompile?

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1542375384)
> What's your feeling on how important figuring out the fix for the pruning issue is at the moment? People don't consider it blocking https://github.com/bitcoin/bitcoin/pull/24008, right?

Right, pruning issues shouldn't block #24008 - those changes need to happen regardless of how we manage pruning with snapshots.

I'll reproduce/investigate the pruning issues over the coming days. But it's worth noting that @Sjors didn't see any regressions in pruning on this branch _before_ loading the sn
...

💬 instagibbs commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1190051098)
Is this block required anymore now that `ProcessBlock` will call it for us?

⚠️ adastreamer opened an issue: "Keep it simple"
(https://github.com/bitcoin/bitcoin/issues/27618)
### Please describe the feature you'd like to see added.

Dear community,

On my opinion Bitcoin network should not contain anything except BTC transfer transactions. BTC network is absolutely organic and all economic rules are totally balanced - fee/rate/complexity.

All application-level business logic such as tokens and custom data, should be moved to shard/side-chains to keep the main network simple and light as possible. Great example - Lightning network, or the design of Polka/TON netw
...

💬 jamesob commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1190059834)
"by another peer" reads fine to me?

✅ fanquake closed an issue: "Keep it simple"
(https://github.com/bitcoin/bitcoin/issues/27618)

💬 willcl-ark commented on issue "Keep it simple":
(https://github.com/bitcoin/bitcoin/issues/27618#issuecomment-1542389194)
@adastreamer This project's issue tracker is not the right place for this sort of discussion.

I'd recommend asking conceptual/theoretical questions like this either on the bitcoin-dev mailing list or on bitcoin.stackexchange.com.

💬 instagibbs commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1190062712)
peer didn't request, WE requested that peer

💬 willcl-ark commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542391942)
@Jackwumingjie now that you have the wallet compiled in the error message is telling you what to do to: i) either create a wallet (if you don't have one already) or ii) load a wallet (if you do have one).

If you run `bitcoin-cli help createwallet` or `bitcoin-cli help loadwallet` you will find more detailed instructions on how to use these RPCs.

Also see https://github.com/bitcoin/bitcoin/blob/master/doc/managing-wallets.md for more information.

💬 instagibbs commented on pull request "p2p: Avoid prematurely clearing download state for other peers":
(https://github.com/bitcoin/bitcoin/pull/27608#discussion_r1190063736)
ah right, suggested text is also ambiguous....

"Block was requested by us from another peer" ?

💬 jamesob commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1542394306)
Hm, for what it's worth, pruning is working as expected for me on this branch.


```
Every 2.0s: cat <(./src/bitcoin-cli -datadir=/home/james/tmp/bitcoin-au-testing getmempoolinfo) <( ./src/bitcoin-cli -datadir=/home/james/tmp/bitcoin-au-testing getchainstates)
...