💬 MarcoFalke commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189746443)
Likely due to a LOCKS_EXCLUDED?

👍 fanquake approved a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420387226)
ACK e23088707be2c3bf247f4b777290c8e401db48cb - deals with almost all follow up comments out of #27491.

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541983546)
Rebased 8f94f059b3af5ecaf175a95389ba5e73b724203b -> 886a473fc48f2c7d67436b5d9ac5643cd007e27f ([removeBlockstorageArgs_23](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_23) -> [removeBlockstorageArgs_24](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_24), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_23..removeBlockstorageArgs_24))
* Fixed conflicts with https://github.com/bitcoin/bitcoin/pull/27573

💬 hebasto commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541991193)
Concept ACK.

💬 poiuty commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1541991306)
@ayeowch, I ran the script on several vps. Generated a lot of traffic and CPU load increased.
But, the time `bitcoind` was using 100% CPU (single thread) I didn't see much network traffic.

<img src="https://img.poiuty.com/a/ae/f9a79fffd2136c3cfba61a103c3575ae.jpg">

<img src="https://img.poiuty.com/a/d6/9ab34f93219d8f00e91e283c2c750ed6.jpg">

<img src="https://img.poiuty.com/a/58/40789731a81d2332a97a7305fb54af58.jpg">

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189764071)
> Likely due to a LOCKS_EXCLUDED?

Right, in `Chainstate::InvalidateBlock`.

👍 hebasto approved a pull request: "refactor: Replace global find_value function with UniValue::find_value method"
(https://github.com/bitcoin/bitcoin/pull/27605#pullrequestreview-1420414448)
re-ACK fa266c4bbf564308ddbc12653527226506902084

:lock: fanquake locked an issue: "wiadomośc"
(https://github.com/bitcoin-core/gui/issues/718)

:lock: fanquake locked an issue: "View JPEG-encoded data"
(https://github.com/bitcoin-core/gui/issues/707)

🚀 fanquake merged a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611)

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1542019486)
Maybe notice the GCC-13 bug in the comments for `#define WITH_LOCK`?

🤔 hebasto reviewed a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420434054)
Post-merge ACK e23088707be2c3bf247f4b777290c8e401db48cb.

💬 hebasto commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189776962)
Our [Developer Notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#c-data-structures) also suggest a comment `// no default case, so the compiler can warn about missing cases`.

💬 fanquake commented on pull request "ci: Run iwyu on all src files":
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542050798)
> (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)

Looks like it's mostly working, except GUI stuff is still being dragged in

💬 MarcoFalke commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1542071939)
> Maybe notice the GCC-13 bug in the comments for #define WITH_LOCK?

I think https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189731837 applies and we should disable the warning instead if there are more false positives?

💬 Sjors commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542082141)
Concept ACK. I can't verify the PGP key.

📝 MarcoFalke opened a pull request: " ci: Remove CI_EXEC bloat "
(https://github.com/bitcoin/bitcoin/pull/27616)
`CI_EXEC` has many issues:

* It is roughly equivalent to `bash -c "$*"`, meaning that the full command will be treated as a single string, ignoring tokens.
* It must be put in front of (almost) every command, making it easy to forget, hard to debug the resulting failure, and the code verbose.

Fix all issues by removing it almost completely.

💬 RandyMcMillan commented on pull request "ci: Remove CI_EXEC bloat":
(https://github.com/bitcoin/bitcoin/pull/27616#issuecomment-1542118050)
concept ACK

💬 hebasto commented on pull request "ci: Run iwyu on all src files":
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542127948)
> > (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)
>
> Looks like it's mostly working, except GUI stuff is still being dragged in

And `qt/qrc_bitcoin.cpp` as well.

🤔 theStack reviewed a pull request: "test: added coverage to mining_basic.py"
(https://github.com/bitcoin/bitcoin/pull/27603#pullrequestreview-1420535642)
Concept ACK