💬 ryanofsky commented on pull request "refactor: Extract common/args from util/system":
(https://github.com/bitcoin/bitcoin/pull/27419#issuecomment-1505447794)
I think this PR could be labeled move-only instead of refactoring, because no code is changing other than #includes.
(https://github.com/bitcoin/bitcoin/pull/27419#issuecomment-1505447794)
I think this PR could be labeled move-only instead of refactoring, because no code is changing other than #includes.
💬 fanquake commented on pull request "ci: Run iwyu on all src files":
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542050798)
> (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)
Looks like it's mostly working, except GUI stuff is still being dragged in
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542050798)
> (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)
Looks like it's mostly working, except GUI stuff is still being dragged in
💬 hebasto commented on pull request "ci: Run iwyu on all src files":
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542127948)
> > (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)
>
> Looks like it's mostly working, except GUI stuff is still being dragged in
And `qt/qrc_bitcoin.cpp` as well.
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542127948)
> > (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)
>
> Looks like it's mostly working, except GUI stuff is still being dragged in
And `qt/qrc_bitcoin.cpp` as well.
💬 MarcoFalke commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551399068)
Looks like iwyu doesn't work with qt?
```
(qt/test/util.h has correct #includes/fwd-decls)
qt/test/util.cpp should add these lines:
#include <QtCore/qobjectdefs.h> // for FunctionPointer<>::IsPointerToMember...
#include <qapplication.h> // for QApplication
#include <qlist.h> // for QList
#include <qmessagebox.h> // for QMessageBox
#include <qobject.h> // for qobject_cast
#include <qpushbutton.h> // for QPushButton
#include <qstring.
...
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551399068)
Looks like iwyu doesn't work with qt?
```
(qt/test/util.h has correct #includes/fwd-decls)
qt/test/util.cpp should add these lines:
#include <QtCore/qobjectdefs.h> // for FunctionPointer<>::IsPointerToMember...
#include <qapplication.h> // for QApplication
#include <qlist.h> // for QList
#include <qmessagebox.h> // for QMessageBox
#include <qobject.h> // for qobject_cast
#include <qpushbutton.h> // for QPushButton
#include <qstring.
...
💬 TheCharlatan commented on pull request "refactor: Make node_id a const& in RemoveBlockRequest":
(https://github.com/bitcoin/bitcoin/pull/31282#issuecomment-2473659364)
Looks like iwyu is still complaining about some of the includes:
```
[08:23:24.120] (/ci_container_base/src/net_processing.h has correct #includes/fwd-decls)
[08:23:24.120]
[08:23:24.120] /ci_container_base/src/net_processing.cpp should add these lines:
[08:23:24.120]
[08:23:24.120] /ci_container_base/src/net_processing.cpp should remove these lines:
[08:23:24.120] - #include <deploymentstatus.h> // lines 21-21
[08:23:24.120] - #include <node/warnings.h> // lines 39-39
```
(https://github.com/bitcoin/bitcoin/pull/31282#issuecomment-2473659364)
Looks like iwyu is still complaining about some of the includes:
```
[08:23:24.120] (/ci_container_base/src/net_processing.h has correct #includes/fwd-decls)
[08:23:24.120]
[08:23:24.120] /ci_container_base/src/net_processing.cpp should add these lines:
[08:23:24.120]
[08:23:24.120] /ci_container_base/src/net_processing.cpp should remove these lines:
[08:23:24.120] - #include <deploymentstatus.h> // lines 21-21
[08:23:24.120] - #include <node/warnings.h> // lines 39-39
```
💬 Sjors commented on pull request "Double check all block rules in `ConnectBlock`, not only `CheckBlock`":
(https://github.com/bitcoin/bitcoin/pull/31792#issuecomment-2639841215)
Some historical context. The 2 hour future check used to be in `CheckBlockHeader`, but was moved in #8068 (Compact Blocks) in order to "prevent yet more includes and the crazy-looking GetAdjustedTime call from within the GetBlock stuff.": https://github.com/bitcoin/bitcoin/pull/8068/files#r66835690
> In order to avoid checking the merkle tree twice (which is incredibly expensive), I had to call CheckBlock, which required three #includes (including main.h) to blockencodings.cpp, despite them b
...
(https://github.com/bitcoin/bitcoin/pull/31792#issuecomment-2639841215)
Some historical context. The 2 hour future check used to be in `CheckBlockHeader`, but was moved in #8068 (Compact Blocks) in order to "prevent yet more includes and the crazy-looking GetAdjustedTime call from within the GetBlock stuff.": https://github.com/bitcoin/bitcoin/pull/8068/files#r66835690
> In order to avoid checking the merkle tree twice (which is incredibly expensive), I had to call CheckBlock, which required three #includes (including main.h) to blockencodings.cpp, despite them b
...