🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝
Similar to https://github.com/wemake-services/django-modern-rest/issues/93 we have several important public APIs for
But, we never test that they can actually be applied. This is a very simple issue with just 2 extra tests with existing examples from https://github.com/wemake-services/django-modern-rest/pull/95
#helpwanted #goodfirst_issue #enhancement
sent via relator
📝
Endpoint
customizations are not tested (#104)Similar to https://github.com/wemake-services/django-modern-rest/issues/93 we have several important public APIs for
Endpoint
customization: https://github.com/wemake-services/django-modern-rest/blob/9e1a24deb3a65683f991ebd14465b0b20e0c22b1/djangomodernrest/endpoint.py#L53-L58But, we never test that they can actually be applied. This is a very simple issue with just 2 extra tests with existing examples from https://github.com/wemake-services/django-modern-rest/pull/95
#helpwanted #goodfirst_issue #enhancement
sent via relator
👍2
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Write a test for custom
Our endpoints have two methods to handle custom errors: https://github.com/wemake-services/django-modern-rest/blob/17edd60e1d13b88f4ee2c229095c237b1919b415/djangomodernrest/endpoint.py#L118-L132
But, they are not tested to be customized. Please, add two cases with:
1. Async endpoint and
2. Sync endpoint and
#helpwanted #goodfirst_issue #enhancement
sent via relator
📝 Write a test for custom
handle_error
and handle_async_error
types (#110)Our endpoints have two methods to handle custom errors: https://github.com/wemake-services/django-modern-rest/blob/17edd60e1d13b88f4ee2c229095c237b1919b415/djangomodernrest/endpoint.py#L118-L132
But, they are not tested to be customized. Please, add two cases with:
1. Async endpoint and
handle_async_error
that custom errors can be serialized to json the right way2. Sync endpoint and
handle_error
with the same logic#helpwanted #goodfirst_issue #enhancement
sent via relator