🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Add `slotscheck` to the CI (#68)
There's an amazing tool called https://github.com/ariebovenberg/slotscheck
We use
List of things to do:
• Add
• Add the configuration to
• Add the call to
This should be a really small task for several minutes :)
#help_wanted #good_first_issue #dependencies #github_actions
sent via relator
📝 Add `slotscheck` to the CI (#68)
There's an amazing tool called https://github.com/ariebovenberg/slotscheck
We use
__slots__ in this project by default. So, we would love to test their defition.List of things to do:
• Add
slotscheck to test deps• Add the configuration to
pyproject.toml• Add the call to
MakefileThis should be a really small task for several minutes :)
#help_wanted #good_first_issue #dependencies #github_actions
sent via relator
👍1
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Add `codespell` to the CI (#72)
We need to add
Example:
• https://github.com/dry-python/returns/blob/1d74c969a94ce13648be2fe2a8bfad3b12f73069/pyproject.toml#L64
• Configuration (should be moved to
• Running: https://github.com/dry-python/returns/blob/1d74c969a94ce13648be2fe2a8bfad3b12f73069/.github/workflows/test.yml#L61
PRs are welcome!
#enhancement #good_first_issue #github_actions #help_wanted
sent via relator
📝 Add `codespell` to the CI (#72)
We need to add
codespell to the CI, because I make a lot of typos :)Example:
• https://github.com/dry-python/returns/blob/1d74c969a94ce13648be2fe2a8bfad3b12f73069/pyproject.toml#L64
• Configuration (should be moved to
pyproject.toml): https://github.com/dry-python/returns/blob/1d74c969a94ce13648be2fe2a8bfad3b12f73069/setup.cfg#L170-L173• Running: https://github.com/dry-python/returns/blob/1d74c969a94ce13648be2fe2a8bfad3b12f73069/.github/workflows/test.yml#L61
PRs are welcome!
#enhancement #good_first_issue #github_actions #help_wanted
sent via relator
❤1👍1
🚀 New issue to wemake-services/wemake-python-styleguide by @sobolevn
📝 `WPS226` false positive on fstring parts (#3548)
This code raises a violation:
When
Output:
This does not seem right, because strings that are part of
PR would be rather easy :)
#help_wanted #levelstarter #good_first_issue #bug
sent via relator
📝 `WPS226` false positive on fstring parts (#3548)
This code raises a violation:
x = f'single {1}'
y = f'single {1}'
When
--max-string-usage=1 is provided.Output:
1:5 WPS226 Found string literal over-use: single > 1
x = f'single {1}'
^
This does not seem right, because strings that are part of
f strings should not be counted by WPS226PR would be rather easy :)
#help_wanted #levelstarter #good_first_issue #bug
sent via relator
New issue to wemake-services/django-modern-rest by @sobolevn
Write tests for "double validation" problem (#85)
We need to be sure that double validation does not happen. Ever.
See what "double validation" is: fastapi/fastapi#3021
To be sure, we need to write tests for it.
Tests would be rather easy to write:
• One for
• One for
• One for raw data return
Also test disabled response validation mode to do 0 validations.
See the attached issue to learn how to make sure that double validation happened.
No matter what - we need to do a 1 or 0 validations.
#django_modern_rest #help_wanted #enhancement #good_first_issue
sent via relator
Write tests for "double validation" problem (#85)
We need to be sure that double validation does not happen. Ever.
See what "double validation" is: fastapi/fastapi#3021
To be sure, we need to write tests for it.
Tests would be rather easy to write:
• One for
@modify• One for
@validate• One for raw data return
Also test disabled response validation mode to do 0 validations.
See the attached issue to learn how to make sure that double validation happened.
No matter what - we need to do a 1 or 0 validations.
#django_modern_rest #help_wanted #enhancement #good_first_issue
sent via relator
🔥1
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Create
We have kwargs for
And they are used here: https://github.com/wemake-services/django-modern-rest/blob/2edcf631b26758c84adafe1a0f24a8de824c8fca/djangomodernrest/plugins/msgspec.py#L136-L142
We need to make a
#goodfirstissue #help_wanted #enhancement
sent via relator
📝 Create
TypedDict for the msgspec.convert call (#124)We have kwargs for
msgspec.convert defined here: https://github.com/wemake-services/django-modern-rest/blob/2edcf631b26758c84adafe1a0f24a8de824c8fca/djangomodernrest/plugins/msgspec.py#L81And they are used here: https://github.com/wemake-services/django-modern-rest/blob/2edcf631b26758c84adafe1a0f24a8de824c8fca/djangomodernrest/plugins/msgspec.py#L136-L142
We need to make a
TypedDict for the possible values of these kwargs.#goodfirstissue #help_wanted #enhancement
sent via relator
👍2