đŦ pinheadmz commented on pull request "Security: Add info for Nathan Woodburn":
(https://github.com/handshake-org/hsd/pull/953#issuecomment-4024380337)
I added Nathan as a maintainer of hnsd for now. Will come back to organization-level permission soon.
(https://github.com/handshake-org/hsd/pull/953#issuecomment-4024380337)
I added Nathan as a maintainer of hnsd for now. Will come back to organization-level permission soon.
đŦ realrasengan commented on pull request "Handshake Hard Fork - Arbitrary DNS Records, Supply Reallocation, and Tree Interval":
(https://github.com/handshake-org/hsd/pull/952#issuecomment-4025546173)
> G'day, Just seeing your response [#952 (comment)](https://github.com/handshake-org/hsd/pull/952#issuecomment-4006515966) and I've got a few questions
>
> 1. Is there any reason for why a 10 minute DNS change is needed?
It's a pain to wait. Even 10 minutes is long! :)
> DNS changes are rare in production sites.
It depends on what site/service. While many static production sites may not change their DNS settings often, there are actually many other sites that include dynamically ch
...
(https://github.com/handshake-org/hsd/pull/952#issuecomment-4025546173)
> G'day, Just seeing your response [#952 (comment)](https://github.com/handshake-org/hsd/pull/952#issuecomment-4006515966) and I've got a few questions
>
> 1. Is there any reason for why a 10 minute DNS change is needed?
It's a pain to wait. Even 10 minutes is long! :)
> DNS changes are rare in production sites.
It depends on what site/service. While many static production sites may not change their DNS settings often, there are actually many other sites that include dynamically ch
...
đŦ Nathanwoodburn commented on pull request "Handshake Hard Fork - Arbitrary DNS Records, Supply Reallocation, and Tree Interval":
(https://github.com/handshake-org/hsd/pull/952#issuecomment-4034940450)
There are a few issues that I can see with every block being an urkel update.
1. Re-orgs? At the moment how does hsd handle re-orgs that cross the urkel tree update block? How would a re-org of >1 block work for hsd. Will it be able to rewind though multiple urkel trees
2. Safe height confirmations. At the moment we have to wait a few blocks (12? I think) after a tree update before it is considered safe. So currently there is a min of 12 blocks and a max of 48 blocks for an update to take affe
...
(https://github.com/handshake-org/hsd/pull/952#issuecomment-4034940450)
There are a few issues that I can see with every block being an urkel update.
1. Re-orgs? At the moment how does hsd handle re-orgs that cross the urkel tree update block? How would a re-org of >1 block work for hsd. Will it be able to rewind though multiple urkel trees
2. Safe height confirmations. At the moment we have to wait a few blocks (12? I think) after a tree update before it is considered safe. So currently there is a min of 12 blocks and a max of 48 blocks for an update to take affe
...
đ Nathanwoodburn opened a pull request: "ci: Lock npm version and add brew prefix"
(https://github.com/handshake-org/hnsd/pull/133)
Fix actions to stop the consistent failures.
This PR locks the node version to 20.x to ensure that hnsd can compile and run without `std::memory_order` errors.
This also adds brew prefix to stop macOS tests from failing to validate libunbound is installed.
(https://github.com/handshake-org/hnsd/pull/133)
Fix actions to stop the consistent failures.
This PR locks the node version to 20.x to ensure that hnsd can compile and run without `std::memory_order` errors.
This also adds brew prefix to stop macOS tests from failing to validate libunbound is installed.
đŦ Falci commented on pull request "ci: Lock npm version and add brew prefix":
(https://github.com/handshake-org/hnsd/pull/133#discussion_r2928500345)
Work with this a temporary fix.
Maybe we should create an issue to revisit this.
(https://github.com/handshake-org/hnsd/pull/133#discussion_r2928500345)
Work with this a temporary fix.
Maybe we should create an issue to revisit this.
đ Falci approved a pull request: "ci: Lock npm version and add brew prefix"
(https://github.com/handshake-org/hnsd/pull/133)
(https://github.com/handshake-org/hnsd/pull/133)
âŠī¸ Nathanwoodburn synchronized a pull request: "ci: Lock npm version and add brew prefix"
(https://github.com/handshake-org/hnsd/pull/133)
(https://github.com/handshake-org/hnsd/pull/133)
đŦ Nathanwoodburn commented on pull request "ci: Lock npm version and add brew prefix":
(https://github.com/handshake-org/hnsd/pull/133#discussion_r2928553717)
This should be fixed now by increasing the HSD version in the integration testing https://github.com/Nathanwoodburn/hnsd/blob/cb1ab833ff8329d42a8d68e44e7c136196381d40/integration/package.json#L12
(https://github.com/handshake-org/hnsd/pull/133#discussion_r2928553717)
This should be fixed now by increasing the HSD version in the integration testing https://github.com/Nathanwoodburn/hnsd/blob/cb1ab833ff8329d42a8d68e44e7c136196381d40/integration/package.json#L12
đ Falci approved a pull request: "ci: Lock npm version and add brew prefix"
(https://github.com/handshake-org/hnsd/pull/133)
(https://github.com/handshake-org/hnsd/pull/133)
âŗī¸ Nathanwoodburn pushed commits to a branch: handshake-org/hnsd:master
(https://github.com/handshake-org/hnsd/compare/026b1cee353a...a484f9c11719)
Merge PR #133 from 'nathanwoodburn/fix/github_actions'
(https://github.com/handshake-org/hnsd/compare/026b1cee353a...a484f9c11719)
Merge PR #133 from 'nathanwoodburn/fix/github_actions'
đ Nathanwoodburn merged a pull request: "ci: Lock npm version and add brew prefix"
(https://github.com/handshake-org/hnsd/pull/133)
(https://github.com/handshake-org/hnsd/pull/133)
âŠī¸ Nathanwoodburn synchronized a pull request: "Update tld.h to fix issues with .in resolving"
(https://github.com/handshake-org/hnsd/pull/132)
(https://github.com/handshake-org/hnsd/pull/132)
âŗī¸ Nathanwoodburn pushed commits to a branch: handshake-org/hnsd:master
(https://github.com/handshake-org/hnsd/compare/a484f9c11719...56a09a2f7700)
Merge PR #132 from 'nathanwoodburn/update/tld.h'
(https://github.com/handshake-org/hnsd/compare/a484f9c11719...56a09a2f7700)
Merge PR #132 from 'nathanwoodburn/update/tld.h'
đ Nathanwoodburn merged a pull request: "Update tld.h to fix issues with .in resolving"
(https://github.com/handshake-org/hnsd/pull/132)
(https://github.com/handshake-org/hnsd/pull/132)
âŗī¸ Nathanwoodburn pushed commits to a branch: handshake-org/hnsd:master
(https://github.com/handshake-org/hnsd/compare/56a09a2f7700...f43442b56eef)
Merge PR #131 from 'walletdomain/patch-1'
(https://github.com/handshake-org/hnsd/compare/56a09a2f7700...f43442b56eef)
Merge PR #131 from 'walletdomain/patch-1'
đ Nathanwoodburn merged a pull request: "Update README.md"
(https://github.com/handshake-org/hnsd/pull/131)
(https://github.com/handshake-org/hnsd/pull/131)
â
Nathanwoodburn closed a pull request: "Better Developer UX"
(https://github.com/handshake-org/hnsd/pull/130)
(https://github.com/handshake-org/hnsd/pull/130)
đŦ Nathanwoodburn commented on pull request "Better Developer UX":
(https://github.com/handshake-org/hnsd/pull/130#issuecomment-4101632259)
G'day,
These code blocks follow the standard of using `$` to indicate that the commands are to be run from a user (non-root) terminal.
(https://github.com/handshake-org/hnsd/pull/130#issuecomment-4101632259)
G'day,
These code blocks follow the standard of using `$` to indicate that the commands are to be run from a user (non-root) terminal.
đ¤ Nathanwoodburn requested changes to a pull request: "Add workflow for updating tld.h file"
(https://github.com/handshake-org/hnsd/pull/121)
(https://github.com/handshake-org/hnsd/pull/121)
đŦ Nathanwoodburn commented on pull request "Add workflow for updating tld.h file":
(https://github.com/handshake-org/hnsd/pull/121#discussion_r2968644169)
G'day,
Using hsd v5 is causing the workflow to fail ([test run on my fork](https://github.com/Nathanwoodburn/hnsd/actions/runs/23368824359/job/67988295057))
Can you update this to hsd@v8 (or the latest hsd version)
(https://github.com/handshake-org/hnsd/pull/121#discussion_r2968644169)
G'day,
Using hsd v5 is causing the workflow to fail ([test run on my fork](https://github.com/Nathanwoodburn/hnsd/actions/runs/23368824359/job/67988295057))
Can you update this to hsd@v8 (or the latest hsd version)