handshake-org-github
51 subscribers
7.8K links
Public log of all github activity from https://github.com/handshake-org
Download Telegram
↩️ nodech synchronized a pull request: "Wallet TX Count and time indexing"
(https://github.com/handshake-org/hsd/pull/888)
👋 nodech's pull request is ready for review: "Wallet TX Count and time indexing"
(https://github.com/handshake-org/hsd/pull/888)
nodech closed a pull request: "WalletDB Migration to v3"
(https://github.com/handshake-org/hsd/pull/889)
💬 nodech commented on pull request "WalletDB Migration to v3":
(https://github.com/handshake-org/hsd/pull/889#issuecomment-2366764887)
Closing this. Proper migration is implemented in #888.
↩️ nodech synchronized a pull request: "Wallet TX Count and time indexing"
(https://github.com/handshake-org/hsd/pull/888)
↩️ nodech synchronized a pull request: "Wallet TX Count and time indexing"
(https://github.com/handshake-org/hsd/pull/888)
↩️ nodech synchronized a pull request: "Wallet TX Count and time indexing"
(https://github.com/handshake-org/hsd/pull/888)
📝 nodech opened a pull request: "Update types"
(https://github.com/handshake-org/hsd/pull/902)
This PR updates the most basic and least modified types, including those in hd, primitives, coins, covenants, protocol, script, net/packets, utils, and ui.

The goal of this PR is to clean up the types and enable simple reference and "go-to-definition" functionality in the TypeScript Language Server.

Code changes have been kept to an absolute minimum to minimize rebases in other PRs.

The TS JSDoc variation of import syntax is not compatible with standard JSDoc, and this has been handled
...
💬 coveralls commented on pull request "Update types":
(https://github.com/handshake-org/hsd/pull/902#issuecomment-2382879808)

[![Coverage Status](https://coveralls.io/builds/70071491/badge)](https://coveralls.io/builds/70071491)

coverage: 70.038% (+0.005%) from 70.033%
when pulling **e13f180c962ea90fb11166bbefad250a3a59cd6f on nodech:update-types**
into **5294be7eb876fe7cff75982febf97a81896f7517 on handshake-org:master**.
↩️ nodech synchronized a pull request: "Update types"
(https://github.com/handshake-org/hsd/pull/902)
💬 nodech commented on pull request "Update types":
(https://github.com/handshake-org/hsd/pull/902#issuecomment-2386110766)
mempool/claimentry - ClaimEntry .name is not consistent within itself. lib/mining/template BlockClaim.name is not consistent with ClaimEntry. Looking into Proof .data and encoding `.name` should be string. For now leave w/o modifying the code.
↩️ nodech synchronized a pull request: "Update types"
(https://github.com/handshake-org/hsd/pull/902)
✳️ nodech pushed commits to a branch: handshake-org/hsd:master
(https://github.com/handshake-org/hsd/compare/5294be7eb876...45c6ac1d64a2)
Merge PR #902 from 'nodech/update-types'
🚀 nodech merged a pull request: "Update types"
(https://github.com/handshake-org/hsd/pull/902)
⚠️ nodech opened an issue: "Add chaindb option for compaction directory."
(https://github.com/handshake-org/hsd/issues/903)
Currently, compaction happens on the same disk with suffix of `~`. Add ability for users to specify some place specific to utilize different volumes etc.
↩️ nodech synchronized a pull request: "Wallet TX Count and time indexing"
(https://github.com/handshake-org/hsd/pull/888)
📝 nodech opened a pull request: "Add more specific error when linked inputs are pending."
(https://github.com/handshake-org/hsd/pull/904)
Linked inputs, such as REVEAL, REDEEM, REGISTER ... REVOKE, are tied to specific coins. Coins can't be used when they are either spent or spent in the mempool. Already spent errors are handled properly by checking existence of coins.

Credits when they are in the wallets pending list (Most likely in the mempool as well) are not properly handled. Wallet will allow creation of covenant inputs, but it will fail later on coin selection. Coin selection can't use coins spent in pending, so it will
...
↩️ nodech synchronized a pull request: "Add more specific error when linked inputs are pending."
(https://github.com/handshake-org/hsd/pull/904)
↩️ nodech synchronized a pull request: "Add more specific error when linked inputs are pending."
(https://github.com/handshake-org/hsd/pull/904)
💬 coveralls commented on pull request "Add more specific error when linked inputs are pending.":
(https://github.com/handshake-org/hsd/pull/904#issuecomment-2393482187)

[![Coverage Status](https://coveralls.io/builds/70166249/badge)](https://coveralls.io/builds/70166249)

coverage: 70.06% (+0.02%) from 70.04%
when pulling **7b5aab14e2a6d636ae542a47a0b26280fbef20c1 on nodech:preferred-inputs-bug**
into **45c6ac1d64a25aa07aeab9b5018dd50efdff31b7 on handshake-org:master**.