handshake-org-github
54 subscribers
8.29K links
Public log of all github activity from https://github.com/handshake-org
Download Telegram
♊️ gorisefunds forked: hs-client
(https://github.com/gorisefunds/hs-client)
♊️ rseales forked: hnsd
(https://github.com/rseales/hnsd)
♊️ rseales forked: hs-client
(https://github.com/rseales/hs-client)
♊️ rseales forked: HIPs
(https://github.com/rseales/HIPs)
♊️ rseales forked: hs-airdrop
(https://github.com/rseales/hs-airdrop)
♊️ rseales forked: goosig
(https://github.com/rseales/goosig)
♊️ rseales forked: bfilter
(https://github.com/rseales/bfilter)
♊️ rseales forked: handshake-web
(https://github.com/rseales/handshake-web)
♊️ rseales forked: hsd-ledger
(https://github.com/rseales/hsd-ledger)
♊️ rseales forked: hs-names
(https://github.com/rseales/hs-names)
📝 nodech opened a pull request: "wallet-http: TransactionOptions minor refactor"
(https://github.com/handshake-org/hsd/pull/943)
This allows tx options to have different defaults.

e.g.
```
const options = new TransactionOptions();
options.blocks = 10;
options.fromValidator(valid);
```

This will override options.blocks only when validator has it.
📝 nodech opened a pull request: "wallet: makeOpen will remove added output if output is doubleOpen."
(https://github.com/handshake-org/hsd/pull/944)
If partial batching is used double open errors would still leave the outputs in mtx making OPEN txs invalid.

This ensures it is removed if check fails.
✳️ nodech pushed commits to a branch: handshake-org/hsd:master
(https://github.com/handshake-org/hsd/compare/8f42b5ddd78b...cd262937a0e4)
Merge PR #943 from 'nodech/transaction-http-validator'
🚀 nodech merged a pull request: "wallet-http: TransactionOptions minor refactor"
(https://github.com/handshake-org/hsd/pull/943)
💬 coveralls commented on pull request "wallet-http: TransactionOptions minor refactor":
(https://github.com/handshake-org/hsd/pull/943#issuecomment-3213274457)

[![Coverage Status](https://coveralls.io/builds/75201631/badge)](https://coveralls.io/builds/75201631)

coverage: 71.655% (+0.02%) from 71.638%
when pulling **a30427f894ede9c8d2e04c0e921d32b421a77e1c on nodech:transaction-http-validator**
into **8f42b5ddd78b3e41311f5394d078093bd404aa22 on handshake-org:master**.
💬 coveralls commented on pull request "wallet: makeOpen will remove added output if output is doubleOpen.":
(https://github.com/handshake-org/hsd/pull/944#issuecomment-3213295256)

[![Coverage Status](https://coveralls.io/builds/75201764/badge)](https://coveralls.io/builds/75201764)

coverage: 71.653% (+0.02%) from 71.638%
when pulling **2ae6584a0bffec76fc15f8236236521c0c1503d1 on nodech:fix-partial-open**
into **8f42b5ddd78b3e41311f5394d078093bd404aa22 on handshake-org:master**.
✳️ nodech pushed commits to a branch: handshake-org/hsd:master
(https://github.com/handshake-org/hsd/compare/cd262937a0e4...698e252ebc7b)
Merge PR #944 from 'nodech/fix-partial-open'
🚀 nodech merged a pull request: "wallet: makeOpen will remove added output if output is doubleOpen."
(https://github.com/handshake-org/hsd/pull/944)