💬 laanwj commented on pull request "build: add `-Wundef`":
(https://github.com/bitcoin/bitcoin/pull/29876#discussion_r1580663336)
i don't know, i don't think what i imagined is actually doable: make sure the entire build system->program interface consists of 0/1 defines (mandatory) not error-prone `#define`/`#undef`. There's just too many. So resolving this, retracting my comment.
(https://github.com/bitcoin/bitcoin/pull/29876#discussion_r1580663336)
i don't know, i don't think what i imagined is actually doable: make sure the entire build system->program interface consists of 0/1 defines (mandatory) not error-prone `#define`/`#undef`. There's just too many. So resolving this, retracting my comment.
💬 l0rinc commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2347458082)
If any of you feel strongly, I can change it, but it was a deliberate choice from my part.
See https://godbolt.org/z/o3sKqefT5 for an ugly error on Windows that also convinced me to just use the shorter version. I could of course hack it with:
```C++
#ifdef _WIN32
#include <windows.h>
#undef max
#else
```
or just hope that https://github.com/bitcoin/bitcoin/blob/9f744fffc39d93c9966dec1d61f113a7521983ad/CMakeLists.txt#L261 fixes it, but `SIZE_MAX` seemed simpler and shorter in this case :/
-
...
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2347458082)
If any of you feel strongly, I can change it, but it was a deliberate choice from my part.
See https://godbolt.org/z/o3sKqefT5 for an ugly error on Windows that also convinced me to just use the shorter version. I could of course hack it with:
```C++
#ifdef _WIN32
#include <windows.h>
#undef max
#else
```
or just hope that https://github.com/bitcoin/bitcoin/blob/9f744fffc39d93c9966dec1d61f113a7521983ad/CMakeLists.txt#L261 fixes it, but `SIZE_MAX` seemed simpler and shorter in this case :/
-
...
💬 stringintech commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2411570436)
Yes. I am compiling using `afl-clang-fast++` (it seems that other options are either unavailable or obsolete on macOS). However, I just added a `#undef __AFL_LOOP` at the top of `fuzz.cpp` to disable persistent mode (I made sure I no longer see the `[+] Persistent mode binary detected` log when running) and reverted the above change to `rand_path()`, but the same crash still occurs.
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2411570436)
Yes. I am compiling using `afl-clang-fast++` (it seems that other options are either unavailable or obsolete on macOS). However, I just added a `#undef __AFL_LOOP` at the top of `fuzz.cpp` to disable persistent mode (I made sure I no longer see the `[+] Persistent mode binary detected` log when running) and reverted the above change to `rand_path()`, but the same crash still occurs.