💬 maflcko commented on pull request "wallet: Fix use-after-free in WalletBatch::EraseRecords":
(https://github.com/bitcoin/bitcoin/pull/29176#issuecomment-1876939948)
I believe this bug existed since the code was written in commit 22401f17e026ead4bc3fe96967eec56a719a4f75.
If one wants to trigger the bug in any c++ standard library, forcing a clear to also shrink may work:
```diff
diff --git a/src/streams.h b/src/streams.h
index bc04a2babd..26320db602 100644
--- a/src/streams.h
+++ b/src/streams.h
@@ -10,6 +10,7 @@
#include <span.h>
#include <support/allocators/zeroafterfree.h>
#include <util/overflow.h>
+#include <util/vector.h>
#includ
...
(https://github.com/bitcoin/bitcoin/pull/29176#issuecomment-1876939948)
I believe this bug existed since the code was written in commit 22401f17e026ead4bc3fe96967eec56a719a4f75.
If one wants to trigger the bug in any c++ standard library, forcing a clear to also shrink may work:
```diff
diff --git a/src/streams.h b/src/streams.h
index bc04a2babd..26320db602 100644
--- a/src/streams.h
+++ b/src/streams.h
@@ -10,6 +10,7 @@
#include <span.h>
#include <support/allocators/zeroafterfree.h>
#include <util/overflow.h>
+#include <util/vector.h>
#includ
...
💬 Kordestan1993 commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2136041245)
hi thank you very much
در تاریخ سهشنبه ۲۸ مهٔ ۲۰۲۴، ۲۳:۰۵ laanwj ***@***.***> نوشت:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/util/netif.cpp
> <https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1617802306>:
>
> > +
> +#include <config/bitcoin-config.h> // IWYU pragma: keep
> +
> +#include <util/netif.h>
> +
> +#include <logging.h>
> +#include <netbase.h>
> +#include <util/check.h>
> +#include <util/sock.h>
> +#includ
...
(https://github.com/bitcoin/bitcoin/pull/30043#issuecomment-2136041245)
hi thank you very much
در تاریخ سهشنبه ۲۸ مهٔ ۲۰۲۴، ۲۳:۰۵ laanwj ***@***.***> نوشت:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/util/netif.cpp
> <https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1617802306>:
>
> > +
> +#include <config/bitcoin-config.h> // IWYU pragma: keep
> +
> +#include <util/netif.h>
> +
> +#include <logging.h>
> +#include <netbase.h>
> +#include <util/check.h>
> +#include <util/sock.h>
> +#includ
...
💬 maflcko commented on pull request "refactor: policy: Pass kernel::MemPoolOptions to IsStandard[Tx] rather than long list of individual options":
(https://github.com/bitcoin/bitcoin/pull/30232#issuecomment-2208611605)
E.g.:
```diff
commit 94ed6bf4575abee5200e7fc7054a47d66bebd56c
Author: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Wed Jul 3 18:05:21 2024 +0200
move-only: Default values in MemPoolLimits
diff --git a/src/kernel/mempool_limits.h b/src/kernel/mempool_limits.h
index 8d4495c3cb..eeeaedd233 100644
--- a/src/kernel/mempool_limits.h
+++ b/src/kernel/mempool_limits.h
@@ -4,9 +4,17 @@
#ifndef BITCOIN_KERNEL_MEMPOOL_LIMITS_H
#define BITCOIN_KERNEL_MEMPOOL_LIMITS_H
-#includ
...
(https://github.com/bitcoin/bitcoin/pull/30232#issuecomment-2208611605)
E.g.:
```diff
commit 94ed6bf4575abee5200e7fc7054a47d66bebd56c
Author: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Wed Jul 3 18:05:21 2024 +0200
move-only: Default values in MemPoolLimits
diff --git a/src/kernel/mempool_limits.h b/src/kernel/mempool_limits.h
index 8d4495c3cb..eeeaedd233 100644
--- a/src/kernel/mempool_limits.h
+++ b/src/kernel/mempool_limits.h
@@ -4,9 +4,17 @@
#ifndef BITCOIN_KERNEL_MEMPOOL_LIMITS_H
#define BITCOIN_KERNEL_MEMPOOL_LIMITS_H
-#includ
...
💬 darosior commented on pull request "fuzz: a target for the block index database":
(https://github.com/bitcoin/bitcoin/pull/28209#issuecomment-2273621519)
Thanks for the review everyone. Maintainers: there is still a determinism issue here as per Niklas, which i have yet to re-reproduce.
-------- Original Message --------
On 8/7/24 4:16 PM, Bruno Garcia wrote:
> @brunoerg commented on this pull request.
>
> ---------------------------------------------------------------
>
> In [src/test/fuzz/block_index.cpp](https://github.com/bitcoin/bitcoin/pull/28209#discussion_r1707092262):
>
>> +
> +#include <chain.h>
> +#include <chainparams.h>
> +#includ
...
(https://github.com/bitcoin/bitcoin/pull/28209#issuecomment-2273621519)
Thanks for the review everyone. Maintainers: there is still a determinism issue here as per Niklas, which i have yet to re-reproduce.
-------- Original Message --------
On 8/7/24 4:16 PM, Bruno Garcia wrote:
> @brunoerg commented on this pull request.
>
> ---------------------------------------------------------------
>
> In [src/test/fuzz/block_index.cpp](https://github.com/bitcoin/bitcoin/pull/28209#discussion_r1707092262):
>
>> +
> +#include <chain.h>
> +#include <chainparams.h>
> +#includ
...
💬 stickies-v commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1831195216)
nit: includes are [not quite up to date](https://api.cirrus-ci.com/v1/task/6598898733547520/logs/ci.log) (in both files)
<details>
<summary>git diff on d5c564a24f to make iwyu happy</summary>
```diff
diff --git a/src/policy/ephemeral_policy.cpp b/src/policy/ephemeral_policy.cpp
index 6854822e35..3a9a3fa530 100644
--- a/src/policy/ephemeral_policy.cpp
+++ b/src/policy/ephemeral_policy.cpp
@@ -5,6 +5,22 @@
#include <policy/ephemeral_policy.h>
#include <policy/policy.h>
+#includ
...
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1831195216)
nit: includes are [not quite up to date](https://api.cirrus-ci.com/v1/task/6598898733547520/logs/ci.log) (in both files)
<details>
<summary>git diff on d5c564a24f to make iwyu happy</summary>
```diff
diff --git a/src/policy/ephemeral_policy.cpp b/src/policy/ephemeral_policy.cpp
index 6854822e35..3a9a3fa530 100644
--- a/src/policy/ephemeral_policy.cpp
+++ b/src/policy/ephemeral_policy.cpp
@@ -5,6 +5,22 @@
#include <policy/ephemeral_policy.h>
#include <policy/policy.h>
+#includ
...