💬 svanstaa commented on pull request "mempool / rpc: add getprioritisedtransactions, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#issuecomment-1551353374)
Concept ACK

💬 MarcoFalke commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1551363732)
(The gcc bug was just fixed in 13.2)

💬 TheCharlatan commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#issuecomment-1551363803)
Rebased b29eab3fc68de28fe2aa67700fd99c6744e37f61 -> 0b88c307a8ed81705cf8e6fb6332fdf969eb0e2e ([chainstateRmKernelUiInterface_5](https://github.com/TheCharlatan/bitcoin/commits/chainstateRmKernelUiInterface_5) -> [chainstateRmKernelUiInterface_6](https://github.com/TheCharlatan/bitcoin/commits/chainstateRmKernelUiInterface_6), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainstateRmKernelUiInterface_5..chainstateRmKernelUiInterface_6)).
* Fixed conflict with https://github.com/bitc
...

💬 furszy commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#issuecomment-1551366404)
> > ACK [6b605b9](https://github.com/bitcoin/bitcoin/commit/6b605b91c1faf2c7f7cc0c9d39b4fcfd66dc2965) modulo `miniminer_overlap` test.
> > Not really blocking, I'm planning to go deeper later. And probably add some explanatory comments and code simplifications. I think that has a readability barrier that will be a maintenance issue moving forward.
>
> Perhaps we can address that in #26152 as well

Absolutely. Loved @theStack diagram.

💬 fanquake commented on pull request "build: Bump minimum supported Clang to clang-10":
(https://github.com/bitcoin/bitcoin/pull/27682#issuecomment-1551368174)
Guix Build:
```bash
87a9f57e4436db8aa1f892cd7a5bfacaade632d518cf99f3f036ea59936b01a6 guix-build-fa199ee614a7/output/aarch64-linux-gnu/SHA256SUMS.part
7f2cb983eb4433db2e7e8acaa014069b978e999330a2850846ecff66e5276c30 guix-build-fa199ee614a7/output/aarch64-linux-gnu/bitcoin-fa199ee614a7-aarch64-linux-gnu-debug.tar.gz
ba5144a64d5f70adf26b072c966925c79a56d4501389478d2a240daacd523a96 guix-build-fa199ee614a7/output/aarch64-linux-gnu/bitcoin-fa199ee614a7-aarch64-linux-gnu.tar.gz
00d8f4b7904f6e71
...

💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551372789)
Hey all so I am running a 2014 Mac mini with Intel core i5 and have also downloaded the new vs v24.0.1 on Mac osx 12.6.5 Monterey with the same out come it loads and then says fatal error dose not go to anything and shuts down and when I look for the logs on my end it's saying can't find logs have also done a reboot with same outcome

💬 fanquake commented on pull request "msvc: Provide `ObjectFileName` explicitly":
(https://github.com/bitcoin/bitcoin/pull/27687#issuecomment-1551378680)
Can you explain what the issue currently is, and why this is the right fix (as opposed to https://github.com/bitcoin-core/gui/pull/729)? Seems odd to have intermittent link failures.

💬 fanquake commented on pull request "doc: Rework build-unix.md":
(https://github.com/bitcoin/bitcoin/pull/27685#discussion_r1196508636)
Didn't drop `Security` ?

👍 fanquake approved a pull request: "build: Bump minimum supported Clang to clang-10"
(https://github.com/bitcoin/bitcoin/pull/27682#pullrequestreview-1430690452)
ACK fa199ee614a7ed99c6caf329093a3573ea5a664b

💬 MarcoFalke commented on pull request "doc: Rework build-unix.md":
(https://github.com/bitcoin/bitcoin/pull/27685#discussion_r1196517868)
Yeah, not sure if it fits in here, maybe open a separate pull for that?

💬 MarcoFalke commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551399068)
Looks like iwyu doesn't work with qt?

```
(qt/test/util.h has correct #includes/fwd-decls)

qt/test/util.cpp should add these lines:
#include <QtCore/qobjectdefs.h> // for FunctionPointer<>::IsPointerToMember...
#include <qapplication.h> // for QApplication
#include <qlist.h> // for QList
#include <qmessagebox.h> // for QMessageBox
#include <qobject.h> // for qobject_cast
#include <qpushbutton.h> // for QPushButton
#include <qstring.
...

💬 MarcoFalke commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551402978)
> can't find logs

What happens if you start the program in a terminal app and pass `-printtoconsole=1` to it?

💬 fanquake commented on pull request "test: Add missed header":
(https://github.com/bitcoin-core/gui/pull/729#issuecomment-1551403254)
> Looks like iwyu doesn't work with qt?

We might have to provide a mapping file, for it to work sanely? i.e https://github.com/include-what-you-use/include-what-you-use/blob/master/qt5_11.imp.

💬 ryanofsky commented on pull request "init: verify blocks data existence only once for all the indexers":
(https://github.com/bitcoin/bitcoin/pull/27607#issuecomment-1551406710)
Looking at current version of the PR 6dfec1b5fbb0f8e95a6134ea8b27e9d6c285d171 it seems to have changed a lot, and the other thing it is doing now is delaying startup of indexes until blocks are loaded, so there is no longer a conflict with `reindex-chainstate`. So it is basically reimplementing #25193 in a different way that doesn't require a `sleep_for(std::chrono::milliseconds(500))` waitloop. I think this approach is cleaner, but also that #25193 is a smaller more targeted change with a test,
...

💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551416962)

💬 ryanofsky commented on pull request "indexes: Read the locator's top block during init, allow interaction with reindex-chainstate":
(https://github.com/bitcoin/bitcoin/pull/25193#issuecomment-1551420724)
> Thanks! I'll rebase and address furszy's comments next week!

I think it'd be good to just rebase this and merge it and not try to do the "move the indexes threads start after the loading process" change here. This PR is pretty simple, has had a good amount of review and testing, and I think that change would make it more complicated. furszy also implemented that change separately in #27607, and it should simplify both PRs to base that change on top of this one.

💬 ddykeman1 commented on issue "Mac osx 12.6.5 ":
(https://github.com/bitcoin/bitcoin/issues/27681#issuecomment-1551423215)
This is all that I'm getting as of now the program then shuts down

👍 ryanofsky approved a pull request: "indexes: Read the locator's top block during init, allow interaction with reindex-chainstate"
(https://github.com/bitcoin/bitcoin/pull/25193#pullrequestreview-1430738915)
Code review ACK 974140f9e721740f857b45d10d7dbab62fdbbe53. Confirmed this is just a clean rebase since my last review. This needs another rebase now, but after that I would like to merge it.

📝 fanquake opened a pull request: "doc: remove Security section from build-unix.md"
(https://github.com/bitcoin/bitcoin/pull/27688)
Our compile documentation isn't the right place for genric binary hardening notes, which are neither particularly Bitcoin-Core specific, or as relevant as they might have once been, i.e non-executable stacks are now just the norm.

Just remove the notes for now, if someone has something more interesting/Bitcoin Core specific, it could be added in separate documentation in the future (maybe into the devwiki or similar).

Split from https://github.com/bitcoin/bitcoin/pull/27685#discussion_r119
...

💬 fanquake commented on pull request "doc: Rework build-unix.md":
(https://github.com/bitcoin/bitcoin/pull/27685#discussion_r1196552617)
Ok. Done in #27688.