💬 michaelfolkson commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1523860147)
Also while we're sneaking [PR review club](https://bitcoincore.reviews/27460) questions on here what do people here use this for? I'm assuming it is useful for mempool dev work (specific details would be interesting) but I can't imagine it is common for a user to want this.

Concept ACK (the RPC approach seems superior assuming people are currently importing mempools without a RPC being available)

🤔 George43566 reviewed a pull request: "Remove now-unnecessary poll, fcntl includes from net(base).cpp"
(https://github.com/bitcoin/bitcoin/pull/27530#pullrequestreview-1402612799)
Okay

⚠️ ilbarillo2014 opened an issue: "Bitcoin Core v22.0.0 crashes while syncronizing the first local wallet transaction"
(https://github.com/bitcoin/bitcoin/issues/27533)
Hi all,
I'm running Bitcoin Core v22.0.0 and I'm syncronizing all the full blocks.
When it arrives exactly at processing the transaction when I received on 3-01-2018 my first small amount of bitcoin in my wallet, it crashes.

In debug.log I can see only this last message:
2023-04-26T19:01:29Z UpdateTip: new best=000000000000000000667c6320fa787dbd80768f3a9babcf7d7b5b36956f918b height=502410 version=0x20000000 log2_work=87.792928 tx=288732313 date='2018-01-03T19:34:24Z' progress=0.364601 cach
...

📝 satsie opened a pull request: "rpc: add 'getnetmsgstats', new rpc to view network message statistics"
(https://github.com/bitcoin/bitcoin/pull/27534)
Introduce a new RPC, `getnetmsgstats` to retrieve network message statistics. This work addresses https://github.com/bitcoin/bitcoin/issues/26337. More information on the RPC design and implementation can be found in that issue.

**_Massive_** thank-you to @amitiuttarwar, @vasild, and @ajtowns for their help on this :pray: Over the course of several months, they have patiently provided a tremendous amount of guidance and assistance in more ways than I can count!

-------

## getnetmsgstat
...

📝 satsie converted_to_draft a pull request: "rpc: add 'getnetmsgstats', new rpc to view network message statistics"
(https://github.com/bitcoin/bitcoin/pull/27534)
Introduce a new RPC, `getnetmsgstats` to retrieve network message statistics. This work addresses https://github.com/bitcoin/bitcoin/issues/26337. More information on the RPC design and implementation can be found in that issue.

**_Massive_** thank-you to @amitiuttarwar, @vasild, and @ajtowns for their help on this :pray: Over the course of several months, they have patiently provided a tremendous amount of guidance and assistance in more ways than I can count!

-------

## getnetmsgstat
...

💬 petertodd commented on issue "add ability to remove (dust) UTXOs":
(https://github.com/bitcoin/bitcoin/issues/23875#issuecomment-1524286578)
@rebroad The economic way to deal with dust UTXO's would be to soft-fork in a per-UTXO storage "tax", that eventually makes a UTXO unsepndable. At that point it can be removed from the UTXO set. You can't actually recover that tax in that circumstance with a soft-fork. But that's ok - the amount of money tied up in dust UTXO's isn't very big anyway.

💬 petertodd commented on pull request "Ignore datacarrier limits for dataless OP_RETURN outputs":
(https://github.com/bitcoin/bitcoin/pull/27261#issuecomment-1524311380)
@Sjors Added a test.

🚀 fanquake merged a pull request: "test: add coverage for rpc error when trying to rescan beyond pruned data"
(https://github.com/bitcoin/bitcoin/pull/25937)

✅ hebasto closed a pull request: "Add `UNREACHABLE` macro and drop `-Wreturn-type`/`C4715` warnings suppressions"
(https://github.com/bitcoin/bitcoin/pull/26504)

💬 hebasto commented on pull request "Move `CopyrightHolders()` and `LicenseInfo()` into `libbitcoin_common`":
(https://github.com/bitcoin/bitcoin/pull/26688#issuecomment-1524812974)
> I think this is a bugfix/requirement for https://github.com/bitcoin/bitcoin/pull/26504, so I am not sure why it was closed but the other not?

It is closed as well now.

📝 defiminds opened a pull request: "Build file"
(https://github.com/bitcoin/bitcoin/pull/27535)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ defiminds closed a pull request: "Build file"
(https://github.com/bitcoin/bitcoin/pull/27535)

📝 defiminds opened a pull request: "build file"
(https://github.com/bitcoin/bitcoin/pull/27536)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 rebroad commented on issue "add ability to remove (dust) UTXOs":
(https://github.com/bitcoin/bitcoin/issues/23875#issuecomment-1524863724)
I'm curious what algorithms you have in mind. How would you derive the
numbers used in this algorithm?[image:
dfd40693391154b2159adbf2cd30e6451e74f7b2]
​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​

On Thu, 27 Apr 2023, 01:28 Peter Todd, ***@***.***> wrote:

> @rebroad <https://github.com/rebroad> The economic way to deal with dust
> UTXO's would be to soft-fork in a per-UTXO storage "tax", that eventually
> makes a UTXO unsepndable
...

✅ MarcoFalke closed a pull request: "build file"
(https://github.com/bitcoin/bitcoin/pull/27536)

💬 MarcoFalke commented on pull request "Add `UNREACHABLE` macro and drop `-Wreturn-type`/`C4715` warnings suppressions":
(https://github.com/bitcoin/bitcoin/pull/26504#issuecomment-1524922834)
Concept ACK 🫠

💬 instagibbs commented on pull request "[POLICY] Ephemeral anchors":
(https://github.com/bitcoin/bitcoin/pull/26403#issuecomment-1524972854)
Should add a test showing that node restart dumps ephemeral transactions since re-admission to the mempool is done single tx by single tx only.

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1524999351)
The use case would be wanting to sync both the chain and the mempool to include everything/most known by the network or one of your other nodes. This is trivially possible for the chain, however for the mempool it is not.

One option would be to use the `mempool` P2P message type, or add a new message type. This would likely require lifting some restrictions or adding others to make it usable in a normal setting and still prevent privacy/DoS concerns. To what extent the existing `mempool` mess
...

⚠️ MarcoFalke opened an issue: "Drop support for g++-8?"
(https://github.com/bitcoin/bitcoin/issues/27537)
I am wondering when we can drop support for g++-8. All supported operating systems, except for CentOS Stream 8 offer a greater version:

* Ubuntu Focal: gcc 9 (https://packages.ubuntu.com/focal/gcc)
* Debian Bullseye: gcc 10 (https://packages.debian.org/bullseye/gcc)
* CentOS 8 Stream: gcc 8, with EOL of " May 31st, 2024 " (https://www.centos.org/centos-stream/)

The rationale for dropping it would be that there are currently occasional compile failures with perfectly valid C++-17 code, fo
...

💬 MarcoFalke commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1525048924)
Added 27.0 for now, which should be uncontroversial.