💬 MarcoFalke commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#issuecomment-1525052314)
Maybe rebase to make CI less sad?

💬 laanwj commented on pull request "contrib: add ELF OS ABI check to symbol-check.py":
(https://github.com/bitcoin/bitcoin/pull/26953#discussion_r1178793152)
lets check `note.details.abi == lief.ELF.NOTE_ABIS.LINUX` as well

💬 laanwj commented on pull request "contrib: add ELF OS ABI check to symbol-check.py":
(https://github.com/bitcoin/bitcoin/pull/26953#issuecomment-1525096454)
Concept and code review ACK 407bad3f5e9a749bb344ad677036f22c2b70ea69 , left a nit

💬 laanwj commented on pull request "Add support for RNDR/RNDRRS for AArch64 on Linux":
(https://github.com/bitcoin/bitcoin/pull/26839#discussion_r1178799972)
nit: this whole block is in a `#ifdef __aarch64__` section so it's not necessary to re-check here

💬 MarcoFalke commented on pull request "test: perturb anchors.dat to test error during initialization":
(https://github.com/bitcoin/bitcoin/pull/26314#issuecomment-1525122282)
lgtm ACK 33fdfc7986455191df8ce339261bc0561115cf7f

💬 laanwj commented on pull request "Add support for RNDR/RNDRRS for AArch64 on Linux":
(https://github.com/bitcoin/bitcoin/pull/26839#discussion_r1178811690)
this seems correct: according to the spec "If the instruction cannot return a genuine random number in a reasonable period of time, PSTATE.NZCV is set to 0b0100 and the data value returned is 0.", so the `Z` flag is set. The `ok` flag is set to 1 (with instruction [cset](https://developer.arm.com/documentation/ddi0596/2021-12/Base-Instructions/CSET--Conditional-Set--an-alias-of-CSINC-?lang=en#sa_cond_1)) when condition `ne` holds, which means `Z==0` [conditions](https://community.arm.com/arm-com
...

💬 laanwj commented on pull request "Add support for RNDR/RNDRRS for AArch64 on Linux":
(https://github.com/bitcoin/bitcoin/pull/26839#discussion_r1178812574)
same nit as above

💬 laanwj commented on pull request "Add support for RNDR/RNDRRS for AArch64 on Linux":
(https://github.com/bitcoin/bitcoin/pull/26839#issuecomment-1525147489)
> It's not possible to directly query for the capability in userspace, but the Linux kernel [added support](https://github.com/torvalds/linux/commit/1a50ec0b3b2e9a83f1b1245ea37a853aac2f741c) for querying the extension via getauxval in version 5.6 (in 2020), so this is limited to Linux-only for now.

That's the correct way to do it. We might actually want to define `WCAP2_RNG` ourselves instead of checking for its existence, to reduce dependency on compiling with specific kernel version headers
...

💬 pinheadmz commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#issuecomment-1525160464)
> Maybe rebase to make CI less sad?

rebased. cheer up little guy!

💬 kristapsk commented on pull request "Add support for RNDR/RNDRRS for AArch64 on Linux":
(https://github.com/bitcoin/bitcoin/pull/26839#issuecomment-1525178903)
Concept ACK

📝 fanquake locked a pull request: "build file"
(https://github.com/bitcoin/bitcoin/pull/27536)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1525201860)
Concept ACK. I think we could even drop 8 for 26.x.

💬 hebasto commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1525216181)
Concept ACK.

🚀 fanquake merged a pull request: "test: test banlist database recreation"
(https://github.com/bitcoin/bitcoin/pull/26794)

🚀 fanquake merged a pull request: "test: perturb anchors.dat to test error during initialization"
(https://github.com/bitcoin/bitcoin/pull/26314)

💬 ismaelsadeeq commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1178919301)
Approach ACK
I think here since "apply_unbroadcast_set": True` option is added, we should test mempool unbroadcast set list, else there would be no need for the second option.
```suggestion
assert_equal({}, self.nodes[0].importmempool(mempooldat0, {"apply_fee_delta_priority": True, "apply_unbroadcast_set": True}))
assert_equal(2, self.nodes[0].getmempoolinfo()['unbroadcastcount'])
```

💬 pinheadmz commented on issue "Bitcoin Core v22.0.0 crashes while syncronizing the first local wallet transaction":
(https://github.com/bitcoin/bitcoin/issues/27533#issuecomment-1525343831)
Could you try again with the latest release? (24.0.1) Also, what is the story with this wallet? Was it created with Bitcoin Core back in 2018? How did you load it into your v22.0 node?

💬 adlai commented on issue "Improve transaction privacy / fungibility in Bitcoin Core and the Bitcoin system [meta tracking issues]":
(https://github.com/bitcoin/bitcoin/issues/6568#issuecomment-1525428723)
@pinheadmz could you please edit your closing comment to include links, reducing the amount of fingerprinting that must be suffered by folks reading along?

💬 pinheadmz commented on issue "Improve transaction privacy / fungibility in Bitcoin Core and the Bitcoin system [meta tracking issues]":
(https://github.com/bitcoin/bitcoin/issues/6568#issuecomment-1525459479)
@adlai https://en.bitcoin.it/wiki/Privacy

💬 adlai commented on issue "Improve transaction privacy / fungibility in Bitcoin Core and the Bitcoin system [meta tracking issues]":
(https://github.com/bitcoin/bitcoin/issues/6568#issuecomment-1525476600)
> @adlai https://en.bitcoin.it/wiki/Privacy

Why should I donate my metaphorical guano to the bitcoin-doteyetee domain?