✅ achow101 closed a pull request: "Move `CopyrightHolders()` and `LicenseInfo()` into `libbitcoin_common`"
(https://github.com/bitcoin/bitcoin/pull/26688)

📝 achow101 converted_to_draft a pull request: "wallet: tx creation, don't select outputs from txes that are being replaced"
(https://github.com/bitcoin/bitcoin/pull/26732)
Adding test coverage and the needed checks for two scenarios
where the wallet creates invalid transactions.


#### First Scenario, Do Not Use Outputs From the Tx Being Replaced

When the wallet creates/fund a replacement transaction, it should
not fund the new transaction with outputs belonging to the tx
being replaced.

Reason:
Once replaced, those outputs are no longer going to exist, there
by the created/funded transaction will be invalid.

#### Second Scenario, Do Not Create BI
...

💬 achow101 commented on pull request "policy: Report reason inputs are nonstandard from AreInputsStandard":
(https://github.com/bitcoin/bitcoin/pull/13525#issuecomment-1522029174)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "policy: Report reason inputs are nonstandard from AreInputsStandard"
(https://github.com/bitcoin/bitcoin/pull/13525)

💬 achow101 commented on pull request "Safegcd-based modular inverses in MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/21590#issuecomment-1522036913)
cc @real-or-random @fjahr

💬 achow101 commented on pull request "test: Remove unused coin_selection param":
(https://github.com/bitcoin/bitcoin/pull/26110#issuecomment-1522037326)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "test: Remove unused coin_selection param"
(https://github.com/bitcoin/bitcoin/pull/26110)

💬 achow101 commented on pull request "refactor: Simplify bnb coin_selection test params":
(https://github.com/bitcoin/bitcoin/pull/26111#issuecomment-1522038714)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "refactor: Simplify bnb coin_selection test params"
(https://github.com/bitcoin/bitcoin/pull/26111)

📝 0xB10C converted_to_draft a pull request: "tracing: Only prepare tracepoint arguments when actually tracing"
(https://github.com/bitcoin/bitcoin/pull/26593)
Currently, if the tracepoints are compiled (e.g. in depends and release builds), we always prepare the tracepoint arguments regardless of the tracepoints being used or not. We made sure that the argument preparation is as cheap as possible, but we can almost completely eliminate any overhead for users not interested in the tracepoints (the vast majority), by gating the tracepoint argument preparation with an `if(something is attached to this tracepoint)`. To achieve this, we use the optional sem
...

💬 achow101 commented on pull request "test: Assert RPC Server binds before creating cookie":
(https://github.com/bitcoin/bitcoin/pull/26964#issuecomment-1522042872)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "test: Assert RPC Server binds before creating cookie"
(https://github.com/bitcoin/bitcoin/pull/26964)

💬 0xB10C commented on pull request "tracing: network connection tracepoints":
(https://github.com/bitcoin/bitcoin/pull/25832#issuecomment-1522043071)
Still think this is relevant, marking this as in draft until I address the feedback.

📝 0xB10C converted_to_draft a pull request: "tracing: network connection tracepoints"
(https://github.com/bitcoin/bitcoin/pull/25832)
This adds five new tracepoints with documentation and tests for network connections:

- established connections with `net:inbound_connection` and `net:outbound_connection`
- closed connections (both closed by us or by the peer) with `net:closed_connnection`
- connections that we choose to evict with `net:evicted_connection`
- connections that are misbehaving and punished with `net:misbehaving_connection`

I've been using these tracepoints for a few months now to monitor connection lifetim
...

✅ achow101 closed a pull request: "wallet, refactor: FundTransaction(): return out-params as `util::Result` structure"
(https://github.com/bitcoin/bitcoin/pull/26129)

✅ achow101 closed a pull request: "wallet: Include a signature with encrypted keys to mitigate a wallet scam"
(https://github.com/bitcoin/bitcoin/pull/25766)

✅ achow101 closed a pull request: "CCoinsViewCache code cleanup & deduplication"
(https://github.com/bitcoin/bitcoin/pull/9384)

💬 achow101 commented on pull request "test: allow BITCOIN_TEST_PATH to specify working dir":
(https://github.com/bitcoin/bitcoin/pull/26564#issuecomment-1522051059)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "During IBD, prune as much as possible until we get close to where we will eventually keep blocks"
(https://github.com/bitcoin/bitcoin/pull/20827)
This should reduce pruning flushes even more, speeding up IBD with pruning on systems that have a sufficient dbcache.

Assumes 1 MB per block between tip and best header chain. Simply adds this to the buffer pruning is trying to leave available, which results in pruning almost everything up until we get close to where we need to be keeping blocks.

💬 achow101 commented on pull request "fuzz: BIP 42, BIP 30, CVE-2018-17144":
(https://github.com/bitcoin/bitcoin/pull/17860#issuecomment-1522062568)
Are you still working on this?