✅ achow101 closed a pull request: "script: create V1SigVersion for functions which should only accept taproot/tapscript"
(https://github.com/bitcoin/bitcoin/pull/26101)
(https://github.com/bitcoin/bitcoin/pull/26101)
✅ achow101 closed a pull request: "Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference"
(https://github.com/bitcoin/bitcoin/pull/23507)
(https://github.com/bitcoin/bitcoin/pull/23507)
✅ achow101 closed a pull request: "p2p: Replace RecursiveMutex `m_tx_inventory_mutex` with Mutex and rename it"
(https://github.com/bitcoin/bitcoin/pull/24125)
(https://github.com/bitcoin/bitcoin/pull/24125)
💬 achow101 commented on pull request "index: Compare deserialized block hash with the block hash from the blockindex":
(https://github.com/bitcoin/bitcoin/pull/26390#issuecomment-1521985512)
Are you still working on this?
(https://github.com/bitcoin/bitcoin/pull/26390#issuecomment-1521985512)
Are you still working on this?
💬 achow101 commented on pull request "Remove Taproot activation height":
(https://github.com/bitcoin/bitcoin/pull/26201#issuecomment-1521993089)
Are you still working on this?
(https://github.com/bitcoin/bitcoin/pull/26201#issuecomment-1521993089)
Are you still working on this?
💬 achow101 commented on pull request "lib: Optimizing siphash implementation":
(https://github.com/bitcoin/bitcoin/pull/18014#issuecomment-1522000397)
Closing as up for grabs due to lack of activity.
(https://github.com/bitcoin/bitcoin/pull/18014#issuecomment-1522000397)
Closing as up for grabs due to lack of activity.
✅ achow101 closed a pull request: "lib: Optimizing siphash implementation"
(https://github.com/bitcoin/bitcoin/pull/18014)
(https://github.com/bitcoin/bitcoin/pull/18014)
💬 achow101 commented on pull request "Prune locks":
(https://github.com/bitcoin/bitcoin/pull/19463#issuecomment-1522002830)
Are you still working on this?
(https://github.com/bitcoin/bitcoin/pull/19463#issuecomment-1522002830)
Are you still working on this?
💬 theuni commented on pull request " test: Extend stale_tip_peer_management test ":
(https://github.com/bitcoin/bitcoin/pull/23352#issuecomment-1522005446)
Ping @MarcoFalke, apparently :)
(https://github.com/bitcoin/bitcoin/pull/23352#issuecomment-1522005446)
Ping @MarcoFalke, apparently :)
💬 glozow commented on pull request "[mempool] allow tx replacement by smaller witness":
(https://github.com/bitcoin/bitcoin/pull/24007#issuecomment-1522007031)
Closing as there doesn't seem to be much support for this change - it's still unclear whether any use cases exist. If something changes, please feel free to comment and we can revisit this at a later time.
(https://github.com/bitcoin/bitcoin/pull/24007#issuecomment-1522007031)
Closing as there doesn't seem to be much support for this change - it's still unclear whether any use cases exist. If something changes, please feel free to comment and we can revisit this at a later time.
✅ glozow closed a pull request: "[mempool] allow tx replacement by smaller witness"
(https://github.com/bitcoin/bitcoin/pull/24007)
(https://github.com/bitcoin/bitcoin/pull/24007)
📝 brunoerg converted_to_draft a pull request: "p2p: delete anchors.dat after trying to connect to that peers"
(https://github.com/bitcoin/bitcoin/pull/24034)
In the current scenario, `anchors.dat` is deleted right after reading it, however, if my node stops before trying to connect to the anchors peers, it will create an empty `anchors.dat`. This PR changes it to delete `anchors.dat` after trying to connect to the peers from it. So, if my node stops (**in a clean way**) before trying to connect to that peers, the `anchors.dat` file will be preserved and a dump won't happen.
(https://github.com/bitcoin/bitcoin/pull/24034)
In the current scenario, `anchors.dat` is deleted right after reading it, however, if my node stops before trying to connect to the anchors peers, it will create an empty `anchors.dat`. This PR changes it to delete `anchors.dat` after trying to connect to the peers from it. So, if my node stops (**in a clean way**) before trying to connect to that peers, the `anchors.dat` file will be preserved and a dump won't happen.
💬 achow101 commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-1522014008)
@real-or-random
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-1522014008)
@real-or-random
💬 achow101 commented on pull request "refactor: Extract MIB_BYTES constant for init.cpp":
(https://github.com/bitcoin/bitcoin/pull/25386#issuecomment-1522019921)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.
(https://github.com/bitcoin/bitcoin/pull/25386#issuecomment-1522019921)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.
✅ achow101 closed a pull request: "refactor: Extract MIB_BYTES constant for init.cpp"
(https://github.com/bitcoin/bitcoin/pull/25386)
(https://github.com/bitcoin/bitcoin/pull/25386)
💬 glozow commented on pull request "util: Show descriptive error messages when FileCommit fails":
(https://github.com/bitcoin/bitcoin/pull/26654#issuecomment-1522020092)
@john-moffett please rebase?
(https://github.com/bitcoin/bitcoin/pull/26654#issuecomment-1522020092)
@john-moffett please rebase?
💬 achow101 commented on pull request "Add reindex=auto flag to automatically reindex corrupt data":
(https://github.com/bitcoin/bitcoin/pull/26674#issuecomment-1522021327)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Closing due to lack of interest. Pull requests with improvements are always welcome.
(https://github.com/bitcoin/bitcoin/pull/26674#issuecomment-1522021327)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Closing due to lack of interest. Pull requests with improvements are always welcome.
✅ achow101 closed a pull request: "Add reindex=auto flag to automatically reindex corrupt data"
(https://github.com/bitcoin/bitcoin/pull/26674)
(https://github.com/bitcoin/bitcoin/pull/26674)
💬 achow101 commented on pull request "contrib/init: Better systemd integration":
(https://github.com/bitcoin/bitcoin/pull/25975#issuecomment-1522023013)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Closing due to lack of interest. Pull requests with improvements are always welcome.
(https://github.com/bitcoin/bitcoin/pull/25975#issuecomment-1522023013)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Closing due to lack of interest. Pull requests with improvements are always welcome.
✅ achow101 closed a pull request: "contrib/init: Better systemd integration"
(https://github.com/bitcoin/bitcoin/pull/25975)
(https://github.com/bitcoin/bitcoin/pull/25975)