💬 fanquake commented on pull request "build: LLD based macOS toolchain":
(https://github.com/bitcoin/bitcoin/pull/21778#issuecomment-2111552513)
Guix build (aarch64):
```bash
cf99b6597c64c4d0cd75176d261a53f24779e8c3dbe9e891d9d166ae9d00d182 guix-build-f58a8678957e/output/aarch64-linux-gnu/SHA256SUMS.part
922e38e2b1a091f20caa014600936689fb9f14bf56fbd80e4c836c518897ff1f guix-build-f58a8678957e/output/aarch64-linux-gnu/bitcoin-f58a8678957e-aarch64-linux-gnu-debug.tar.gz
256c68e14a905aa6933a2dc83cad636a14ee99ac4661a287e7817efe421965ab guix-build-f58a8678957e/output/aarch64-linux-gnu/bitcoin-f58a8678957e-aarch64-linux-gnu.tar.gz
50eafd
...

💬 fanquake commented on pull request "util: avoid using thread_local variable that has a destructor":
(https://github.com/bitcoin/bitcoin/pull/30095#discussion_r1600922285)
Seems like a weird comment to add without specfic/obvious motivation, and doesn't prevent the same thing from happening elsewhere in the codebase?

🚀 fanquake merged a pull request: "refactor: simplify `FormatSubVersion` using strprintf/Join"
(https://github.com/bitcoin/bitcoin/pull/30098)

💬 fanquake commented on pull request "crypto: disable asan for sha256_sse4 with clang and -O0":
(https://github.com/bitcoin/bitcoin/pull/30097#issuecomment-2111604544)
> Upstream issue filed here: https://github.com/llvm/llvm-project/issues/92182

Thanks. Could you like to that thread from the comment added to the source, then this is probably good to go.

💬 jsarenik commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111605326)
@Sjors [wrote](https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2056345622):
> If anyone wants to deploy a faucet, let me know and I'll send some coins... unless someone reorgs me.

Yes, I'd be happy to set up a Testnet4 faucet similar to [Alt Signet Faucet](https://alt.signetfaucet.com/). Please send me some testnet coins to `tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc8szkreflscsdkgqsdent4` on [Testnet4](https://mempool.space/testnet4/address/tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc
...

💬 fanquake commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111607875)
> It is hard to say because https://github.com/bitcoin/bitcoin/commit/188ca75e5fe4837d16241446558c7566912f67b2 refers to the mentioned test case only. There was no links to any upstream issues.

What did you find in the mingw-w64 / GCC changelogs?

>> Erm, as of what version? Or what fix? We need more info here to be able to have any confidence.

> there are no evidences that the [test case](https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605) fails for any supported platform.
...

💬 jsarenik commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1600961392)
Could one possibly test with `-noconnect`, i.e. without connecting to the network and getting any other than genesis testnet4 block?

💬 fanquake commented on pull request "util: avoid using thread_local variable that has a destructor":
(https://github.com/bitcoin/bitcoin/pull/30095#issuecomment-2111609858)
> My understanding is that it is safe to use thread_local on FreeBSD for variables that do not have a destructor

So if we are moving forward with this assumption, what is preventing these kinds of variables being reintroduced (elsewhere) into the codebase? I'd rather `thread_local` be safe to use (in all circumstance) on a platform, or we just not use it.

This change feels a bit odd/forced because it's basically opting back into `thread_local`, but only certain usage/uncertain assumption
...

💬 emsit commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111634889)
If someone has coins they don't need, they can also donate them to the donate address of the faucet: [https://coinfaucet.eu/en/btc-testnet4/](url)

**tb1qn9rvr53m7qvrpysx48svuxsgahs88xfsskx367**

💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111643871)
Please note, that the test case fails when running a Windows binary `a.exe` on Ubuntu 14.04 LTS. It is reasonable to assume that it uses packages `wine-binfmt` and `wine`.

The error messages like "err:ntdll:RtlpWaitForCriticalSection section 0x100a8 "heap.c: main process heap section" wait timed out in thread 0064, blocked by 0055, retrying (60 sec)" are specific to the Wine runtime. For example, https://www.winehq.org/pipermail/wine-devel/2003-January/013655.html.

My point is that the htt
...

💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111650447)
I believe, that was a bug in the Wine package that has been fixed -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917307.

💬 emsit commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111655985)



> @Sjors [wrote](https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2056345622):
>
> > If anyone wants to deploy a faucet, let me know and I'll send some coins... unless someone reorgs me.
>
> Yes, I'd be happy to set up a Testnet4 faucet similar to [Alt Signet Faucet](https://alt.signetfaucet.com/). Please send me some testnet coins to `tb1p4tp4l6glyr2gs94neqcpr5gha7344nfyznfkc8szkreflscsdkgqsdent4` on [Testnet4](https://mempool.space/testnet4/address/tb1p4tp4l6glyr2gs94neqc
...

💬 hebasto commented on pull request "build: Enable `thread_local` for MinGW-w64 builds":
(https://github.com/bitcoin/bitcoin/pull/30099#issuecomment-2111656619)
I found that the test case error messages are quite similar to ones reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917307. That bug has been fixed as well.

💬 0xB10C commented on issue "ci: Enable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/issues/29804#issuecomment-2111699235)
https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/

💬 nickguo commented on issue "Performance decrease after tapscript miniscript":
(https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-2111705890)
Hello, is anyone actively working on this? -- and if not, would this be an appropriate "good first issue"?

💬 eriknylund commented on issue "Performance decrease after tapscript miniscript":
(https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-2111726566)
> Hello, is anyone actively working on this? -- and if not, would this be an appropriate "good first issue"?

@darosior replied to my open PR that he has no plans to implement right now (see https://github.com/bitcoin/bitcoin/pull/28212#issuecomment-2045410857), so afaik no one is actively working on this. I can't say if it's a good first issue, but I would be happy to help with review in combination with my 999-of-999 tests if you want to have a go at it. ❤️

💬 jsarenik commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2111731892)
> I shared with you, the world is small 😃 ![]

Thank you! One new testnet4 faucet running at https://testnet4.anyone.eu.org/

👋 maflcko's pull request is ready for review: "ci: Roll clang in test-each-commit task"
(https://github.com/bitcoin/bitcoin/pull/30060)

💬 maflcko commented on pull request "ci: Roll clang in test-each-commit task":
(https://github.com/bitcoin/bitcoin/pull/30060#issuecomment-2111827640)
rebased to fix commit hashes :see_no_evil:

💬 maflcko commented on issue "ci: Enable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/issues/29804#issuecomment-2111834677)
Is someone interested in moving the asan task over to GHA now?

cc @m3dwards