⚠️ SleepTheGod opened an issue: "Websocket Exploit"
(https://github.com/bitcoin/bitcoin/issues/30104)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

python exploit.py
--- request header ---
GET /inv HTTP/1.1
Upgrade: websocket
Host: ws.blockchain.info
Origin: https://ws.blockchain.info
Sec-WebSocket-Key: ZIHq/jbH7u0qeSHAFRSWFQ==
Sec-WebSocket-Version: 13
Connection: Upgrade


-----------------------
--- response header ---
HTTP/1.1 101 Switching Protocols
Date: Tue, 14 May 2024 23:06:34 GMT
Connection: upgrade
Sec-Webs
...

✅ achow101 closed an issue: "Websocket Exploit"
(https://github.com/bitcoin/bitcoin/issues/30104)

:lock: achow101 locked an issue: "Websocket Exploit"
(https://github.com/bitcoin/bitcoin/issues/30104)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/30103)

🚀 achow101 merged a pull request: "refactor: Simply include CTxMemPool::Options in CTxMemPool directly rather than duplicating definition"
(https://github.com/bitcoin/bitcoin/pull/29086)

📝 kevkevinpal opened a pull request: "test: Added test to ensure log and failure happen when work is less than active chainstate"
(https://github.com/bitcoin/bitcoin/pull/30105)
This adds coverage to the `ActivateSnapshot` function asserting that when we try to use a snapshot with too little work done on it, using `loadtxoutset`. That this log and rpc error are thrown

log
`[snapshot] activation failed - work does not exceed active chainstate`
rpc error
`Unable to load UTXO snapshot`

Adds coverage to this code https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L5567

🚀 fanquake merged a pull request: "contrib: use ENV flags in get_arch"
(https://github.com/bitcoin/bitcoin/pull/30074)

👋 fanquake's pull request is ready for review: "build: LLD based macOS toolchain"
(https://github.com/bitcoin/bitcoin/pull/21778)

📝 kevkevinpal opened a pull request: "lint: fixed typo in test_runner causing linter warning"
(https://github.com/bitcoin/bitcoin/pull/30106)
introduced in https://github.com/bitcoin/bitcoin/commit/357ad110548d726021547d85b5b2bfcf3191d7e3

This typo is causing an error in the linter, fixing this should remove this warning

```
test/functional/test_runner.py:651: insuffient ==> insufficient
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
```

[link to cirrus ci warning](https://cirrus-ci.com/task/5926490804584448?logs=lint
...

👍 tdb3 approved a pull request: "refactor: simplify `FormatSubVersion` using strprintf/Join"
(https://github.com/bitcoin/bitcoin/pull/30098#pullrequestreview-2056708441)
ACK for 12d82817bf32396b58c8c65645012def606680b6.

Thank you. Making code more concise and readable is much appreciated.
Built and ran unit tests (including `util_tests/test_FormatSubVersion`) and functionals. All passed.

A one/same-line `if` aligns with the coding style (https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c).

> If an if only has a single-statement then-clause, it can appear on the same line as the if, without braces.

💬 jonatack commented on pull request "lint: fixed typo in test_runner causing linter warning":
(https://github.com/bitcoin/bitcoin/pull/30106#issuecomment-2111412705)
See #30084.

💬 jonatack commented on pull request "contrib: lief updates":
(https://github.com/bitcoin/bitcoin/pull/30084#issuecomment-2111413331)
> If anything, I think the docs could be updated in some way to say that running the linters outside the container, or with versions that differ from the CI is generally unsupported.

Thanks for the feedback, will update.

✅ kevkevinpal closed a pull request: "lint: fixed typo in test_runner causing linter warning"
(https://github.com/bitcoin/bitcoin/pull/30106)

💬 kevkevinpal commented on pull request "lint: fixed typo in test_runner causing linter warning":
(https://github.com/bitcoin/bitcoin/pull/30106#issuecomment-2111420940)
> See #30084.

nice! closing in favor of https://github.com/bitcoin/bitcoin/pull/30084.

💬 andrewtoth commented on pull request "Drop -dbcache limit":
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-2111425877)
> The only time -dbcache is filled beyond its previous 16GB limit is during IDB

I'm sure it will happen if you restart your node now and leave it running for long enough ;)

> In order to benefit from having the full UTXO set in RAM after a restart, we'd have to proactively load the entire UTXO set into -dbcache if space permits.

I did make a crude attempt at that years ago https://github.com/bitcoin/bitcoin/pull/18941. Not sure it is worth it.

💬 kevkevinpal commented on pull request "refactor: simplify `FormatSubVersion` using strprintf/Join":
(https://github.com/bitcoin/bitcoin/pull/30098#issuecomment-2111441030)
utACK https://github.com/bitcoin/bitcoin/pull/30084.

🤔 tdb3 reviewed a pull request: "test: Added test to ensure log and failure happen when work is less than active chainstate"
(https://github.com/bitcoin/bitcoin/pull/30105#pullrequestreview-2056736096)
Concept ACK

Thanks. It's great to add test coverage. Left a question.

💬 tdb3 commented on pull request "test: Added test to ensure log and failure happen when work is less than active chainstate":
(https://github.com/bitcoin/bitcoin/pull/30105#discussion_r1600847551)
Made a temporary modification of a word in the expected message (of `feature_assumeutxo.py` to test that a mismatch would be caught (it was, as expected). Restored to original expected message then modified the message in `validation.cpp`. This mismatch was also detected (as expected)l.

https://github.com/bitcoin/bitcoin/blob/695d80126f75a99c80d5d6c18ebaaabf7410b989/src/validation.cpp#L5659

The default timeout for `assert_debug_log()` is 2 seconds. I haven't had a chance to dig deeper y
...

💬 tdb3 commented on pull request "test: Added test to ensure log and failure happen when work is less than active chainstate":
(https://github.com/bitcoin/bitcoin/pull/30105#discussion_r1600849721)
Also made a temporary modification to this expected message. Mismatch was caught (as expected).

⚠️ jonjonez opened an issue: "Restore wallet taking forever to load"
(https://github.com/bitcoin/bitcoin/issues/30108)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

For some time now, I've been experiencing unusual slowdowns in Bitcoin Core, such as spending a long time without connecting to other pairs on the network and recently, I can't recover a wallet I want in the "restore wallet" option, it keeps loading for hours and never actually restores, this was never happening in Linux (ubuntu.
...