💬 KonradStaniec commented on issue "Calling `walletprocesspsbt` to sign multisig containing `OP_GREATERTHANOREQUAL` op_code":
(https://github.com/bitcoin/bitcoin/issues/29949#issuecomment-2076276040)
Thanks for the quick responses! I think this issue can be closed then.
Two follow up questions, I would have:
1. Is there some other way to sign transaction, through bitcoind, which tries to spend from script which is not compatible with miniscript ?
2. Is the some problem with `OP_GREATERTHANOREQUAL` which makes it non compatible with Miniscript ?
(https://github.com/bitcoin/bitcoin/issues/29949#issuecomment-2076276040)
Thanks for the quick responses! I think this issue can be closed then.
Two follow up questions, I would have:
1. Is there some other way to sign transaction, through bitcoind, which tries to spend from script which is not compatible with miniscript ?
2. Is the some problem with `OP_GREATERTHANOREQUAL` which makes it non compatible with Miniscript ?
💬 maflcko commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578868096)
No, it is not a msvc bug. from_chars actually accepts a raw pointer, not an iterator, so my draft diff was wrong (type-wise)
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578868096)
No, it is not a msvc bug. from_chars actually accepts a raw pointer, not an iterator, so my draft diff was wrong (type-wise)
💬 maflcko commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578875254)
As the function body is new code, I'd say the `url_encoded` can be done correctly when the code is added, but no big deal
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578875254)
As the function body is new code, I'd say the `url_encoded` can be done correctly when the code is added, but no big deal
💬 maflcko commented on pull request "lint: scripted-diff verification also requires GNU grep":
(https://github.com/bitcoin/bitcoin/pull/29689#issuecomment-2076396476)
utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
(https://github.com/bitcoin/bitcoin/pull/29689#issuecomment-2076396476)
utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
📝 laanwj opened a pull request: "[PoC] qt, depends: Add wayland support without build-time nor fixed run-time deps"
(https://github.com/bitcoin/bitcoin/pull/29959)
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a `bitcoin-qt` binary that "just works" on systems that have only one of them installed, or both.
Everything (including libEGL) is loaded dynamically at run time if needed.
```
$ readelf -a src/qt/bitcoin-qt |grep
...
(https://github.com/bitcoin/bitcoin/pull/29959)
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a `bitcoin-qt` binary that "just works" on systems that have only one of them installed, or both.
Everything (including libEGL) is loaded dynamically at run time if needed.
```
$ readelf -a src/qt/bitcoin-qt |grep
...
📝 laanwj converted_to_draft a pull request: "[PoC] qt, depends: Add wayland support without build-time nor fixed run-time deps"
(https://github.com/bitcoin/bitcoin/pull/29959)
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a `bitcoin-qt` binary that "just works" on systems that have only one of them installed, or both.
Everything (including libEGL) is loaded dynamically at run time if needed.
```
$ readelf -a src/qt/bitcoin-qt |grep
...
(https://github.com/bitcoin/bitcoin/pull/29959)
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a `bitcoin-qt` binary that "just works" on systems that have only one of them installed, or both.
Everything (including libEGL) is loaded dynamically at run time if needed.
```
$ readelf -a src/qt/bitcoin-qt |grep
...
💬 hanmz commented on pull request "Fix typos in description.md and wallet_util.py":
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2076626155)
> Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
OK DONE
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2076626155)
> Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
OK DONE
💬 laanwj commented on pull request "guiconstants: update ORG_DOMAIN to bitcoincore.org":
(https://github.com/bitcoin-core/gui/pull/818#issuecomment-2076626737)
Right. i think qt-qml does something substantially different with regard to settings, so it may be warranted there.
(https://github.com/bitcoin-core/gui/pull/818#issuecomment-2076626737)
Right. i think qt-qml does something substantially different with regard to settings, so it may be warranted there.
💬 maflcko commented on pull request "Fix typos in description.md and wallet_util.py":
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2076650860)
ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867
Please add the `doc: ` prefix to the title
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2076650860)
ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867
Please add the `doc: ` prefix to the title
💬 paplorinc commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1579103153)
thanks for checking
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1579103153)
thanks for checking
💬 hebasto commented on pull request "[PoC] qt, depends: Add wayland support without build-time nor fixed run-time deps":
(https://github.com/bitcoin/bitcoin/pull/29959#issuecomment-2076675361)
> This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies.
Concept ACK on this.
Obviously :)
(https://github.com/bitcoin/bitcoin/pull/29959#issuecomment-2076675361)
> This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies.
Concept ACK on this.
Obviously :)
💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1579111090)
I didn't see compiler errors locally and the other CI jobs also didn't seem to fail on compilation. So I assumed clang does some implicit conversion at that point and MSVC doesn't.
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1579111090)
I didn't see compiler errors locally and the other CI jobs also didn't seem to fail on compilation. So I assumed clang does some implicit conversion at that point and MSVC doesn't.
👍 kristapsk approved a pull request: "Fix typos in description.md and wallet_util.py"
(https://github.com/bitcoin/bitcoin/pull/29938#pullrequestreview-2021917530)
ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867
(https://github.com/bitcoin/bitcoin/pull/29938#pullrequestreview-2021917530)
ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867
👍 kristapsk approved a pull request: "lint: scripted-diff verification also requires GNU grep"
(https://github.com/bitcoin/bitcoin/pull/29689#pullrequestreview-2021925047)
cr utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
(https://github.com/bitcoin/bitcoin/pull/29689#pullrequestreview-2021925047)
cr utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
💬 maflcko commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1579125570)
Yes, IIRC a standard library is free to define an iterator as a pointer, or allow iterators to convert to pointers implicitly, but there is no requirement for it do so.
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1579125570)
Yes, IIRC a standard library is free to define an iterator as a pointer, or allow iterators to convert to pointers implicitly, but there is no requirement for it do so.
👍 theStack approved a pull request: "refactor: Use our own implementation of urlDecode"
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2021985089)
Code-review ACK 992c714451676cee33d3dff49f36329423270c1c
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2021985089)
Code-review ACK 992c714451676cee33d3dff49f36329423270c1c
💬 m3dwards commented on pull request "depends: build libnatpmp with CMake":
(https://github.com/bitcoin/bitcoin/pull/29708#issuecomment-2076797188)
My Guix builds:
```shell
a134241bc9ff9823ce078ea10dbac544ff63536ee3f66fb557414ca191b1d62d guix-build-3c1ae3ee33d4/output/aarch64-linux-gnu/SHA256SUMS.part
f5a46ab7a5faae9ce50b2d084cf65d14372b354b9f8369178f1348b70a3b675b guix-build-3c1ae3ee33d4/output/aarch64-linux-gnu/bitcoin-3c1ae3ee33d4-aarch64-linux-gnu-debug.tar.gz
e2353ed4f0738026fe16cd90b503ef2f02f31e0b68ba42ea80924997225ae374 guix-build-3c1ae3ee33d4/output/aarch64-linux-gnu/bitcoin-3c1ae3ee33d4-aarch64-linux-gnu.tar.gz
780608996
...
(https://github.com/bitcoin/bitcoin/pull/29708#issuecomment-2076797188)
My Guix builds:
```shell
a134241bc9ff9823ce078ea10dbac544ff63536ee3f66fb557414ca191b1d62d guix-build-3c1ae3ee33d4/output/aarch64-linux-gnu/SHA256SUMS.part
f5a46ab7a5faae9ce50b2d084cf65d14372b354b9f8369178f1348b70a3b675b guix-build-3c1ae3ee33d4/output/aarch64-linux-gnu/bitcoin-3c1ae3ee33d4-aarch64-linux-gnu-debug.tar.gz
e2353ed4f0738026fe16cd90b503ef2f02f31e0b68ba42ea80924997225ae374 guix-build-3c1ae3ee33d4/output/aarch64-linux-gnu/bitcoin-3c1ae3ee33d4-aarch64-linux-gnu.tar.gz
780608996
...
💬 Sjors commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#issuecomment-2076802405)
I was able to build `bitcoind` (didn't try QT) with `llvm@17`, but _not_ with the current `llvm` 18.1.4. See log: https://gist.github.com/Sjors/194eb5d67e2e1132df7ff86f103ba16b
It's probably fine to drop `@17` anyway, and maybe suggest trying lower versions if building fails. But it would be nice if there's a simple fix for this.
(https://github.com/bitcoin/bitcoin/pull/29934#issuecomment-2076802405)
I was able to build `bitcoind` (didn't try QT) with `llvm@17`, but _not_ with the current `llvm` 18.1.4. See log: https://gist.github.com/Sjors/194eb5d67e2e1132df7ff86f103ba16b
It's probably fine to drop `@17` anyway, and maybe suggest trying lower versions if building fails. But it would be nice if there's a simple fix for this.
💬 vasild commented on issue "Error: Cannot resolve -bind address: 'bitcoind:8334=onion'":
(https://github.com/bitcoin/bitcoin/issues/26484#issuecomment-2076815988)
Yes, line `1841` is for when there is no `=` inside the argument, like in `-bind=1.2.3.4:8333`. Line `1853` is for when there is `=`, like `-bind=1.2.3.4:8333=onion`.
(https://github.com/bitcoin/bitcoin/issues/26484#issuecomment-2076815988)
Yes, line `1841` is for when there is no `=` inside the argument, like in `-bind=1.2.3.4:8333`. Line `1853` is for when there is `=`, like `-bind=1.2.3.4:8333=onion`.
👍 maflcko approved a pull request: "refactor: Use our own implementation of urlDecode"
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2022081812)
Did some differential fuzzing, as this is an ideal fit for it.
ACK 992c714451676cee33d3dff49f36329423270c1c 👈
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4
...
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2022081812)
Did some differential fuzzing, as this is an ideal fit for it.
ACK 992c714451676cee33d3dff49f36329423270c1c 👈
<details><summary>Show signature</summary>
Signature:
```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4
...