💬 brunoerg commented on pull request "fuzz: wallet: add target for `CreateTransaction`":
(https://github.com/bitcoin/bitcoin/pull/29936#discussion_r1578530492)
Done.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578533717)
Ugh, looks like MSVC has a problem with this, I am reverting it for now (see https://github.com/bitcoin/bitcoin/actions/runs/8823024109/job/24222527982?pr=29904)

👍 alfonsoromanz approved a pull request: "lint: scripted-diff verification also requires GNU grep"
(https://github.com/bitcoin/bitcoin/pull/29689#pullrequestreview-2021071819)
Tested ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b

I was using incompatible versions for both sed and grep, so I was able to verify both error messages. After installing the GNU versions I don't get any of the error messages.

⚠️ mouhand-a opened an issue: "Use custom elements on TestPanelContainerItemElement"
(https://github.com/bitcoin/bitcoin/issues/29955)
Use custom elements on TestPanelContainerItemElement

_Originally posted by @sadick254 in https://github.com/atom/atom/pull/22769_

💬 mouhand-a commented on issue "Use custom elements on TestPanelContainerItemElement":
(https://github.com/bitcoin/bitcoin/issues/29955#issuecomment-2076010481)
[‎⁨تصدير سِجِل الطلب-2024-04-20 09_25_30⁩ 2.xlsx](https://github.com/bitcoin/bitcoin/files/15101794/-2024-04-20.09_25_30.2.xlsx)
@
```c++
```

⚠️ mouhand-a opened an issue: "### Summary"
(https://github.com/bitcoin/bitcoin/issues/29956)
### Summary

Currently, projects can only support 1200 active items and 10,000 archived items but we've heard from many larger teams that these limits are too low for the work they need to track such as long-running backlogs. While we can't completely remove the limit for projects, we will raise the limit to approximately 50k active items to better support this scenario.

### Intended Outcome

For long running projects or all-encompassing backlogs for companies, the current limit for proje
...

⚠️ mouhand-a opened an issue: "Because"
(https://github.com/bitcoin/bitcoin/issues/29957)
_Originally posted by @mouhand-a in https://github.com/bitcoin/bitcoin/issues/29950_

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29955)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29955)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29956)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29956)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29957)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29957)

✅ MarnixCroes closed a pull request: "guiconstants: update ORG_DOMAIN to bitcoincore.org"
(https://github.com/bitcoin-core/gui/pull/818)

💬 MarnixCroes commented on pull request "guiconstants: update ORG_DOMAIN to bitcoincore.org":
(https://github.com/bitcoin-core/gui/pull/818#issuecomment-2076070570)
ok, it came across in the qt-qml repo, I looked here and assumed it was forgotten to be updated.
nvm

🤔 tdb3 reviewed a pull request: "test: Validate oversized transactions or without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862#pullrequestreview-2021206191)
re-ACK for e2e8b21240da8d567a37d35ae29a6100fde65d2b

💬 tdb3 commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1578682730)
Re-ran this sanity check on e2e8b21240da8d567a37d35ae29a6100fde65d2b
Unit test failed as expected.

💬 tdb3 commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1578682415)
To check see that the test would fail without "bad-txns-oversize", modified `tx_oversized` case temporarily with the following:

```c++
auto largeOutput = CScript() << OP_RETURN << std::vector<unsigned char>(60, 0x00);
```

Unit test failed (as expected).

🤔 tdb3 reviewed a pull request: "rpc: return warnings as an array instead of just a single one"
(https://github.com/bitcoin/bitcoin/pull/29845#pullrequestreview-2021354156)
Approach ACK.

Re-ran the sanity checks in https://github.com/bitcoin/bitcoin/pull/29845#pullrequestreview-1999801519
All were successful.

Tried testing out the `-deprecatedrpc=warnings` functionality. I'm guessing I'm missing something simple/trivial (or improperly using `-deprecatedrpc`). When running `src/bitcoind -deprecatedrpc=warnings`, both curl and bitcoin-cli returned an error:

curl:
```
$ curl --user __cookie__ --data-binary '{"id": "curltest", "method": "getblockchaininfo
...

💬 fanquake commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578771999)
Another MSVC bug for us to report upstream I guess. @hebasto.