💬 emc99 commented on pull request "ci: Bump s390x to ubuntu:24.04":
(https://github.com/bitcoin/bitcoin/pull/29856#issuecomment-2050172934)
What's s390x?

📝 naiyoma opened a pull request: "Test/rpc whitelistdefault test"
(https://github.com/bitcoin/bitcoin/pull/29858)
This PR adds tests for `rpcwhitelistdefault.` The implementation is a continuation of this [PR](https://github.com/bitcoin/bitcoin/pull/17805).

Applied suggestions to include the tests in` rpc_whitelist.py` and to use a single node.

💬 itornaza commented on pull request "test: Handle functional test disk-full error":
(https://github.com/bitcoin/bitcoin/pull/29335#issuecomment-2050304085)
tested re-ACK for 858fa78637041ae704005d4b6e564dd8245f4b5d

## No size restrictions

- Did a code review and checked that there is adequate space on the file system to run the tests
- Configured with `--with-incompatible-bdb` and `--enable-suppress-external-warnings`
- Ran unit tests with `make check` and all tests pass
- Ran all functional tests with no extra flags, all tests pass and no warnings about free space are displayed
- Ran all functional tests with `--extended` and all tests p
...

💬 laanwj commented on pull request "ci: Bump s390x to ubuntu:24.04":
(https://github.com/bitcoin/bitcoin/pull/29856#issuecomment-2050404404)
> I think they are only missing riscv64, after commit

Great!

> What's s390x?

s390x is some old IBM CPU architecture, we test on it to check if everything works on big-endian machines.

💬 davidgumberg commented on pull request "logging: Update to new logging API":
(https://github.com/bitcoin/bitcoin/pull/29231#discussion_r1561932572)
```suggestion
LogWarning("Relative datadir option '%s' specified, which will be interpreted relative to the "
```

💬 davidgumberg commented on pull request "logging: Update to new logging API":
(https://github.com/bitcoin/bitcoin/pull/29231#issuecomment-2050850514)
utACK https://github.com/bitcoin/bitcoin/commit/8d46bd6750b47caaf2556f915800c6a22c997bc3

Probably tangential to this PR:
Is `LogPrintLevel` in `void libevent_log_cb(...)` an example of:

> "when [...] a category needs to be added for an info/warning/error log message"

<details>

<summary>Otherwise:</summary>

```diff
static void libevent_log_cb(int severity, const char *msg)
{
- BCLog::Level level;
switch (severity) {
case EVENT_LOG_DEBUG:
- level = BCLo
...

📝 pablomartin4btc opened a pull request: "Bugfix - don't allow multiple dialogs for same tx in TransactionView"
(https://github.com/bitcoin-core/gui/pull/817)
Limit to one the transaction details dialogs that a user can open.

<details>
<summary>Currently a user can open unlimited tx details dialogs for the same tx id.</summary>


</details>
<details>
<summary>This PR fixes the issue.</summary>


</details>

💬 maflcko commented on pull request "refactor/test: add a few more base32/64 calculation corner cases":
(https://github.com/bitcoin/bitcoin/pull/29847#discussion_r1562077424)
Please no style changes of this kind

👍 maflcko approved a pull request: "test: refactor: introduce and use `calculate_input_weight` helper"
(https://github.com/bitcoin/bitcoin/pull/29777#pullrequestreview-1995987988)
lgtm

💬 paplorinc commented on pull request "refactor/test: add a few more base32/64 calculation corner cases":
(https://github.com/bitcoin/bitcoin/pull/29847#discussion_r1562143566)
Reverted.
I've changed it originally to be in alignment with the `EncodeBase64`

📝 hebasto opened a pull request: "build: Fix false positive `CHECK_ATOMIC` test for clang-15"
(https://github.com/bitcoin/bitcoin/pull/29859)
On the master branch @ 0de63b8b46eff5cda85b4950062703324ba65a80, a building `bitcoind` with clang-15 for `i686-pc-linux-gnu` fails to link:
```
CXXLD bitcoind
/usr/bin/ld: libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): in function `std::remove_volatile<double>::type std::__atomic_impl::load<double>(double const*, std::memory_order)':
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:948: undefined reference to `__atomic_load'
/usr/bin/ld: libbitc
...

💬 Thales-de-Milet commented on pull request ".":
(https://github.com/bitcoin-core/gui/pull/816#issuecomment-2051321028)
> The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
>
> ### Reviews
> See [the guideline](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review) for information on the review process. A summary of reviews will appear here.

#816

👍 dergoegge approved a pull request: "sign: don't assume we are parsing a sane TapMiniscript"
(https://github.com/bitcoin/bitcoin/pull/29853#pullrequestreview-1996279397)
utACK bdf2ef2c94cae2b0e2cdac1866322b4f9f7c7a7b

💬 maflcko commented on pull request "build: Fix false positive `CHECK_ATOMIC` test for clang-15":
(https://github.com/bitcoin/bitcoin/pull/29859#issuecomment-2051374764)
The same happens with clang-18 locally, but why does CI pass?

fad23a06469607689c4f637bb407c96af4902a27

💬 brunoerg commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#issuecomment-2051379737)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/29833#discussion_r1560532624. Thanks, @laanwj.

💬 laanwj commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#issuecomment-2051395460)
Thanks!
Code review ACK 9fa50338c115f0286637142fd887b212fddfb27d

💬 sipa commented on pull request "minisketch: pull subtree + #81":
(https://github.com/bitcoin/bitcoin/pull/29823#issuecomment-2051424104)
https://github.com/sipa/minisketch/pull/81 is now merged upstream.

⚠️ maflcko opened an issue: "test: Intermittent issue in p2p_compactblocks_hb.py" in relay_block_through assert_equal(status_to, status_from) AssertionError: not([True, False, True, True] == [True, True, True, True])"
(https://github.com/bitcoin/bitcoin/issues/29860)
Logs: https://drahtbot.space/temp_scratch/p2p_compactblocks_hb_170.tar.zstd

```
test 2024-04-10T02:55:04.098000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()

...

⚠️ case456 opened an issue: "Errors in block header at FlatFilePos"
(https://github.com/bitcoin/bitcoin/issues/29861)
ReadBlockFromDisk: Errors in block header at FlatFilePos(nFile=12, nPos=684188)
2024-04-12T09:45:50Z *** Failed to read block
2024-04-12T09:45:50Z Error: A fatal internal error occurred, see debug.log for details

💬 case456 commented on issue "Errors in block header at FlatFilePos":
(https://github.com/bitcoin/bitcoin/issues/29861#issuecomment-2051539334)
How do I go about fixing this?