💬 maflcko commented on issue "Errors in block header at FlatFilePos":
(https://github.com/bitcoin/bitcoin/issues/29861#issuecomment-2051547235)
Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206

💬 flack commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051671919)
would be nice if a click on a row where the dialog is already open would bring that dialog to the foreground

👋 fanquake's pull request is ready for review: "minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492"
(https://github.com/bitcoin/bitcoin/pull/29823)

💬 fanquake commented on pull request "minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492":
(https://github.com/bitcoin/bitcoin/pull/29823#issuecomment-2051675911)
> https://github.com/sipa/minisketch/pull/81 is now merged upstream.

This is now ready for review.

👍 dergoegge approved a pull request: "minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492"
(https://github.com/bitcoin/bitcoin/pull/29823#pullrequestreview-1996775007)
utACK 4722b7c7154e6130d4de66f7aed0fffe3c7c19a4

📝 paplorinc opened a pull request: "test: Validate transaction without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862)
Based on https://maflcko.github.io/b-c-cov/test_bitcoin.coverage/src/consensus/tx_check.cpp.gcov.html empty inputs weren't covered by unit tests.
<img src="https://github.com/bitcoin/bitcoin/assets/1841944/5ba01c65-e4f3-4231-91f2-8793b903f8b5">

I have tried including the empty transaction into https://github.com/bitcoin/bitcoin/blob/master/src/test/data/tx_invalid.json#L34-L36, but it failed for another reason, so I added a separate test case for it in the end.
If this is a welcome change,
...

💬 case456 commented on issue "Errors in block header at FlatFilePos":
(https://github.com/bitcoin/bitcoin/issues/29861#issuecomment-2051742350)
Thank you

🤔 BrandonOdiwuor reviewed a pull request: "Add new "address type" column to the "receiving tab" address book page"
(https://github.com/bitcoin-core/gui/pull/753#pullrequestreview-1996981996)
Concept ACK

Nice solution adding the AddressType `column` and the `filter` by AddressType

💬 BrandonOdiwuor commented on pull request "Add new "address type" column to the "receiving tab" address book page":
(https://github.com/bitcoin-core/gui/pull/753#discussion_r1562541010)
Why this change?

from this


to this

💬 maflcko commented on pull request "psbt: Check non witness utxo outpoint early":
(https://github.com/bitcoin/bitcoin/pull/29855#issuecomment-2051894008)
lgtm ACK 9e13ccc50eec9d2efe0f472e6d50dc822df70d84

💬 pablomartin4btc commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051908161)
> would be nice if a click on a row where the dialog is already open would bring that dialog to the foreground

Great suggestion! I'll try that since I have to fix a lint. Thanks!

💬 brunoerg commented on issue "getaddrmaninfo RPC: add Transport v1/v2 to `tried` for ipv4 & ipv6":
(https://github.com/bitcoin/bitcoin/issues/28807#issuecomment-2051921085)
I agree with @mzumsande. Also, I'm not sure but I do believe you could use tracepoints to track it. See: https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md

💬 pablomartin4btc commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051968829)
Updates:
- Fixed lint failure.
- Bring an already open dialog to the foreground as @flack [suggested](https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051671919).

💬 furszy commented on issue "ci: failure in `rpc_scanblocks.py`":
(https://github.com/bitcoin/bitcoin/issues/29831#issuecomment-2052027874)
> Will do some tests.

Update: working on a fix. Will push it next week.

⚠️ brunoerg opened an issue: "test: intermittent issue in interface_rest.py - AssertionError: self.wait_until(lambda: self.nodes[0].getindexinfo() == expected_filter)"
(https://github.com/bitcoin/bitcoin/issues/29863)
Logs: https://github.com/bitcoin/bitcoin/actions/runs/8659881706/job/23746656188?pr=29833#step:7:44796

```sh
test 2024-04-12T10:25:31.001000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
self.wait_until(lambda: self.nodes[0].getindexinfo() == expected_filter)
'''
test 2024-04-12T10:25:31.002000Z TestFramework (ERROR): Assertion failed
Traceback (most
...

💬 brunoerg commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#issuecomment-2052109417)
CI failure is unrelated to these changes.

💬 itornaza commented on pull request "tests: fix `OP_1NEGATE` handling in `CScriptOp`":
(https://github.com/bitcoin/bitcoin/pull/29589#issuecomment-2052160310)
tested ACK f0c077a388b980566590d7887d8c6dd97cbaa20a

- Performed a code review and everything lgtm
- Configured with --with-incompatible-bdb and --enable-suppress-external-warnings
- Built the PR, ran unit tests with make check and all tests pass
- Ran all functional tests with no extra flags and all tests pass
- Ran all functional tests with --extended and all tests pass

💬 dgpv commented on pull request "tests: fix `OP_1NEGATE` handling in `CScriptOp`":
(https://github.com/bitcoin/bitcoin/pull/29589#issuecomment-2052181600)
NACK for changing behavior of `decode_op_n()` and `encode_op_n()`

(the reasoning is given above, in https://github.com/bitcoin/bitcoin/pull/29589#issuecomment-1996854762)

💬 pablomartin4btc commented on pull request "Improve 'Requested Payments History' Multiselect":
(https://github.com/bitcoin-core/gui/pull/684#issuecomment-2052272585)
I could take this to move it forward @john-moffett, if you are not able to, please let me know.

👍 byaye approved a pull request: "doc: i2p: improve `-i2pacceptincoming` mention"
(https://github.com/bitcoin/bitcoin/pull/29813#pullrequestreview-1998244687)
ACK 2179e2c3209a41c1419f1f5ed6270a0dad68b50d