💬 fanquake commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2032611358)
Are you sure this isn't a local (permissions/filesystem/something else) issue. Works fine for me on macOS 13.6.6.

💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2032620346)
That's certainly possible, though it happens at different commits, which use different temp directories. And it happens for only with bdb while the other packages build fine. I'll try a reboot and wiping more temp stuff.

👍 ryanofsky approved a pull request: "build, depends: Fix `libmultiprocess` cross-compilation"
(https://github.com/bitcoin/bitcoin/pull/29665#pullrequestreview-1974544799)
Code review ACK 178065f27d2852c9ec7c5f44ab2c26c0d092bf70

Thanks for the fix. I don't actually understand why the fix is needed, though, or why mpgen linking should fail when it is cross compiled. That seems like an upstream bug and it would be nice to have more information about it, though the workaround here seems acceptable and has some nice features like using separate source/build directories.

There are some things I don't like about the workaround, but I don't think they are too impor
...

💬 itornaza commented on pull request "test: Handle functional test disk-full error":
(https://github.com/bitcoin/bitcoin/pull/29335#issuecomment-2032749968)
tested ACK 2f7fcd5fe7289f7ad3efd566dbbd725264654f8f

The user is notified when appropriate that there might be insufficient free space to run the tests. Moreover, if a test fails due to insufficient space, the functional test runner halts. Also, there is a relevant warning when the `--nocleanup` flag is used and hence the free disk requirements get bigger.

Note: All tests run on macos 14.4.1 (23E224)

## Standard tests

- Did a code review and checked that there is adequate space on the
...

👍 josibake approved a pull request: "doc: Update the developer mailing list address."
(https://github.com/bitcoin/bitcoin/pull/29782#pullrequestreview-1974619559)
ACK https://github.com/bitcoin/bitcoin/commit/754d42d3530da0a795679fcea3f02c91e2a7b027

Excellent commit message 👍

💬 edilmedeiros commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#issuecomment-2032788657)
For future reference, in case we decide to update the archive links cited in other places of the codebase, here is the mapping:

```
src/validation.cpp

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-November/016518.html
update: https://gnusha.org/pi/bitcoindev/c3f68b73-84c6-7428-4bf6-b47802141392@mattcorallo.com/

—

original: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20190225/a27d8837/attachment-0001.pdf
update: https://gnusha.org/p
...

💬 edilmedeiros commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#issuecomment-2032792467)
> ACK [754d42d](https://github.com/bitcoin/bitcoin/commit/754d42d3530da0a795679fcea3f02c91e2a7b027)
>
> Excellent commit message 👍

Thanks, but there was a typo (database instead of codebase). Amended to correct it.

💬 hebasto commented on pull request "build, depends: Fix `libmultiprocess` cross-compilation":
(https://github.com/bitcoin/bitcoin/pull/29665#issuecomment-2032800854)
> * I don't understand the "Rebuilding during installation has been skipped." comment, because I would not think anything would have been actually been built during the install step if make was just run previously.

Consider the following commands in the libmultiprocess root directory:
```
$ cmake .
$ make
$ make DESTDIR=/home/hebasto/INSTALL install-lib
Consolidate compiler generated dependencies of target util
[ 20%] Built target util
Consolidate compiler generated dependencies of tar
...

💬 ryanofsky commented on pull request "build, depends: Fix `libmultiprocess` cross-compilation":
(https://github.com/bitcoin/bitcoin/pull/29665#issuecomment-2032845728)
> From the build log it follows that the `util` and `multiprocess` targets were being rebuilt.

I don't think that's true. I see lines like `Building CXX object CMakeFiles/util.dir/src/mp/util.cpp.o` and `Linking CXX static library libmultiprocess.a` when targets are actually being built and lines like `Built target util` and `Built target multiprocess` when targets were previously built. Running `make install-bin` or `make install-lib` after building shouldn't cause anything to be rebuilt unl
...

👍 Zero-1729 approved a pull request: "doc: Update the developer mailing list address."
(https://github.com/bitcoin/bitcoin/pull/29782#pullrequestreview-1974752756)
crACK 0ead466a0c72bef0a8622749b84e9c7c5c37144f

LGTM

💬 josibake commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#issuecomment-2032896831)
reACK https://github.com/bitcoin/bitcoin/commit/0ead466a0c72bef0a8622749b84e9c7c5c37144f

👍 hebasto approved a pull request: "ci: Temporarily disable bpfcc-tools"
(https://github.com/bitcoin/bitcoin/pull/29788#pullrequestreview-1974811940)
ACK fac012c7262f036e9b6f5800e57dcd63870a871c, I have reviewed the code, it looks OK. And CI is green.

💬 hebasto commented on pull request "build, depends: Fix `libmultiprocess` cross-compilation":
(https://github.com/bitcoin/bitcoin/pull/29665#issuecomment-2032944870)
OK. I've dropped all unrelated / unneeded changes.

⚠️ gitconsumer opened an issue: "Bitcoin puzzles in lower ranges (starting with 66 as of now) can't be cashed out because of bots and RBF"
(https://github.com/bitcoin/bitcoin/issues/29793)
### Please describe the feature you'd like to see added.

As you might know, there is this bitcoin puzzle thing going on with the 66th at 10% and the prime candidate to be solved next. It's guaranteed to be solved within 2-3 years if I'm not mistaken.

It appears that whoever solves this puzzle first has no way to cash out because as soon as an outgoing transaction is published the public key of the wallet is revealed meaning that a great number of bots monitoring the 66th puzzle wallet pick u
...

💬 sipa commented on issue "Bitcoin puzzles in lower ranges (starting with 66 as of now) can't be cashed out because of bots and RBF":
(https://github.com/bitcoin/bitcoin/issues/29793#issuecomment-2033004155)
Which puzzles? And what does this have to do with Bitcoin Core?

🤔 achow101 reviewed a pull request: "rpc: Optimize serialization disk space of dumptxoutset - Reloaded"
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-1974818797)
`dumptxoutset` is a RPC that has been available for several releases, including those prior to the completion of assumeutxo validation code. Changing the format now is a breaking change - utxo sets dumped prior to the PR are incompatible with any version with this PR merged, and utxo sets dumped after this PR are incompatible with all prior versions.

Conceivably, in the future, someone could run an older node and create a utxo set snapshot to setup a new node with more recent software. This w
...

💬 achow101 commented on pull request "rpc: Optimize serialization disk space of dumptxoutset - Reloaded":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1548483059)
In e7889805999ed312a5af12a2c08c548c19403bd9 "rpc: Optimize serialization disk space of dumptxoutset"

`mapCoins` is never used.

💬 achow101 commented on pull request "ci: Temporarily disable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/pull/29788#issuecomment-2033013525)
Disabling bpfcc-tools means that CI no longer runs any of the USDT tests. Any idea when it could be re-enabled?

💬 sipsorcery commented on pull request "Drop Windows Socket dependency for `randomenv.cpp`":
(https://github.com/bitcoin/bitcoin/pull/29786#issuecomment-2033018400)
utACK 03b87a3e64305ba651e22a730e35271dea8fea64.

If the hostname hash can be generated without requiring network initialisation that seems like a worthwhile imrpovement.

💬 hebasto commented on pull request "ci: Temporarily disable bpfcc-tools":
(https://github.com/bitcoin/bitcoin/pull/29788#issuecomment-2033023246)
> Any idea when it could be re-enabled?

I guess, the package issue should be resolved by the Ubuntu 24.04 release date (this month).