👍 hebasto approved a pull request: "guix: remove errant leftover from #29648"
(https://github.com/bitcoin/bitcoin/pull/29787#pullrequestreview-1974252283)
ACK fd8527a20ebc490df030b3a91c1161f00c8a29b6.

👍 TheCharlatan approved a pull request: "guix: remove errant leftover from #29648"
(https://github.com/bitcoin/bitcoin/pull/29787#pullrequestreview-1974260972)
ACK fd8527a20ebc490df030b3a91c1161f00c8a29b6

Guix builds (x86_64):
```
2b06bbafa2cc5291e9afa1b16751cfb467923e6f7fa4e07faaef41f8dd625524 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/SHA256SUMS.part
3808ccae790057898ff275942b888443fa43f908aa6945057119f4705d7238b4 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu-debug.tar.gz
6c3542f09a01dfdb1817657172e747ba0953732866737ad12d5a79c768f89bc7 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-f
...

💬 vasild commented on issue "Error: Cannot resolve -bind address: 'bitcoind:8334=onion'":
(https://github.com/bitcoin/bitcoin/issues/26484#issuecomment-2032450343)
> Actually flipping that bool doesn't work. It seems to try to resolve the entire line, e.g
> Error: Cannot resolve -bind address: 'bitcoind:38334=onion'

Are you sure?

https://github.com/bitcoin/bitcoin/blob/3b987d03a49964995dced76889634561fd363d28/src/init.cpp#L1837-L1861

If there is `=` in the `-bind` argument then it will remove it and what is after it and will go to line 1853 where the last argument to `Lookup()` is `false`.

💬 edilmedeiros commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#discussion_r1548161056)
> Also, looking at `https://gnusha.org/pi/bitcoindev/` the layout is not very pretty. So even for the old archive I would prefer sticking to the linuxfoundation URL. But the text should clarify that this archive goes until December 2023.
>
> (and I don't think Google itself should be recommended as the canonical archive)

I wasn't aware the Linux Foundation archive were not being updated anymore. It means that the new archive is the comprehensive source of truth in the present and probably
...

🚀 fanquake merged a pull request: "guix: remove errant leftover from #29648"
(https://github.com/bitcoin/bitcoin/pull/29787)

💬 ajtowns commented on pull request "[DO NOT MERGE] testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2032468336)
Probably we should support tracking both testnet3 and the new testnet4 for some time. Making the new code conditional on a different chain param that's only set for testnet4 would probably be the easiest way of accomplishing that?

💬 edilmedeiros commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#issuecomment-2032473850)
@josibake Given the other comments, probably the consensus approach is
1. to update all mentions of the mailing list to the new link (CONTRIBUTING.md and dnsseed-policy.md),
2. CONTRIBUTING.md refers to the new archive since this file is the entry point for newcomers,
3. keep all other mentions of specific emails and threads as they are (as kanzure was told they will still be available in the long term).

I agree with Sjors to keep the old specific links as they are, that's why I opened t
...

📝 cbergqvist opened a pull request: "test: Bump timeouts in feature_index_prune and wallet_importdescriptors"
(https://github.com/bitcoin/bitcoin/pull/29791)
Timeout issues where encountered when running functional tests with `--jobs=16 --extended`.

Note that running `--extended` without `--jobs=16` does not trigger the issues.

Tested under NixOS on a Xeon CPU with 16 logical cores.

(A few tests are skipped locally as I haven't enabled BPF and a few other things).

## Measurements

Line in `feature_index_prune.py` took 101.6s, 96.6s, 103.0s across 3 runs on my machine.
Default limit is 60, suggested to increase limit to 150 seconds.


...

👍 ryanofsky approved a pull request: "ThreadSanitizer: Fix #29767"
(https://github.com/bitcoin/bitcoin/pull/29776#pullrequestreview-1974312067)
Code review ACK bbe82c116e72ca0638751e063bf564cd1fe5c4d5

It seems like the race condition between `m_synced = true` and committing has been around since 4368384f1d267b011e03a805f934f5c47e2ca1b2 from [#14121](https://github.com/bitcoin/bitcoin/pull/14121), and the race condition accessing the `m_next_filter_pos` variable existed then too.

💬 edilmedeiros commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#issuecomment-2032493576)
For the record, these are the mentions of the linux foundation links:

```
❯ ripgrep linuxfoundation
src/validation.cpp
962: // this, see https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-November/016518.html
3960: // https://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20190225/a27d8837/attachment-0001.pdf).
4383: // https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-February/016697.html. Because CheckBlock() is

src/crypto/muha
...

💬 josibake commented on pull request "doc: Update the developer mailing list address.":
(https://github.com/bitcoin/bitcoin/pull/29782#issuecomment-2032498583)
> @josibake Given the other comments, probably the consensus approach is
>
> 1. to update all mentions of the mailing list to the new link (CONTRIBUTING.md and dnsseed-policy.md),
>
> 2. CONTRIBUTING.md refers to the new archive since this file is the entry point for newcomers,
>
> 3. keep all other mentions of specific emails and threads as they are (as kanzure was told they will still be available in the long term).
>
>
> I agree with Sjors to keep the old specific li
...

👍 theuni approved a pull request: "depends: add -g to DEBUG=1 flags"
(https://github.com/bitcoin/bitcoin/pull/29527#pullrequestreview-1974354406)
ACK 84fbf9b2841a9ba1ebd1421b9ff9fe444bb1abd9

💬 josibake commented on pull request "guix: remove errant leftover from #29648":
(https://github.com/bitcoin/bitcoin/pull/29787#issuecomment-2032541109)
Post-merge:

Guix builds (x86_64):

```
2b06bbafa2cc5291e9afa1b16751cfb467923e6f7fa4e07faaef41f8dd625524 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/SHA256SUMS.part
3808ccae790057898ff275942b888443fa43f908aa6945057119f4705d7238b4 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu-debug.tar.gz
6c3542f09a01dfdb1817657172e747ba0953732866737ad12d5a79c768f89bc7 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu.t
...

💬 achow101 commented on issue "Error unlocking wallet: some keys decrypt but not all. your wallet file may be corrupt. ":
(https://github.com/bitcoin/bitcoin/issues/29789#issuecomment-2032544349)
Were you able to successfully unlock prior to the crash? If so, that suggests that the crash has indeed corrupted the wallet file and I suggest that you restore a backup.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1548220655)
Done.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2032545515)
`413574e81e...390e628a07`: rebase due to conflicts and address suggestion

💬 Sjors commented on pull request "depends: swap some cctools tools for LLVM tools":
(https://github.com/bitcoin/bitcoin/pull/29739#issuecomment-2032563698)
Tested 33a63925e7a91620bcfe45e46aeb94b8b521319a depends build on Intel macOS 13.6.6 as well as 14.4.1, including `make deploy`. Both work fine.

I did run into a confusing, but unrelated (happens on 28f2ca675f89a764e1ec8eb5671b35357b8677f3 too), failure with bdb, only on macOS 13.6.6:

```
---
Preprocessing bdb...
patching file 'dbinc/atomic.h'
Can't create '/var/folders/qp/bskkps293_v5w198m17h7zrm0000gn/T/patchoA5jhEiYaVC', output is in '/var/folders/qp/bskkps293_v5w198m17h7zrm0000gn/T/
...

⚠️ Sjors opened an issue: "depens: bdb build fails on Intel macOS 13.6.6 "
(https://github.com/bitcoin/bitcoin/issues/29792)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Building BDB as part of depends fails with a permission denied error for creating a temporary directory. The directory exists after `make` fails. Deleting it and running `make` once more, creates it again and the same error is shown.

Does not happen on my newer Intel macOS 14.4.1 machine.

### Expected behaviour

`make` succeeds

### Steps to reproduce

```sh
cd depends
make NO_BOOST
...

💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2032597413)
Fixing the legacy wallet for old macOS versions doesn't seem high priority, but `release-notes-empty-template.md` mentions "macOS 11.0+" as the minimum we test on. My iMac from 2017 can't run anything newer than macOS 13.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2032604175)
> Only 3 red CI machines to go :-)

Only the tidy job is an actual failure from this PR. MSan is an issue with libsecp that needs to be fixed in https://github.com/bitcoin-core/secp256k1/pull/1479. The ASan failure affects all PRs currently, see #29788