👍 pinheadmz approved a pull request: "Handle invalid hex encoding in ParseHex"
(https://github.com/bitcoin/bitcoin/pull/25227)
ACK fad0c892c34c30cf8f50e832425210e24d45837e

Built and ran all tests, reviewed code. I also inserted a few other test cases but nothing broke so, take em or leave em:

` Ff aA ` (mixed case / multiple spaces, succeeds)
` F F ` (spaces between nibbles, fails as expected)


<details><summary>Show Signature</summary>

```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK fad0c892c34c30cf8f50e832425210e24d45837e
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiE
...

👋 ryanofsky's pull request is ready for review: "Deduplicate bitcoind and bitcoin-qt init code"
(https://github.com/bitcoin/bitcoin/pull/27150)

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1444334598)
Marking ready for review since I was able to merge the duplicate InitSettings functions after #27073.

---

Rebased eeff271a693baa6fb013b6b007306d0c288c811a -> e248926c73ce6f707343501fb42b31090fed202b ([`pr/oneconfig.1`](https://github.com/ryanofsky/bitcoin/commits/pr/oneconfig.1) -> [`pr/oneconfig.2`](https://github.com/ryanofsky/bitcoin/commits/pr/oneconfig.2), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/oneconfig.1-rebase..pr/oneconfig.2)) after #27073 merge

📝 mzumsande opened a pull request: " 25574 followups (VerifyDB error handling)"
(https://github.com/bitcoin/bitcoin/pull/27157)
This addresses two outstanding comments by ryanofsky from #25574:
* return `ChainstateLoadStatus::INTERRUPTED` if verification was interrupted, avoiding a misleading log entry in `init`:
https://github.com/bitcoin/bitcoin/pull/25574#discussion_r1110050930
* add documentation for `require_full_verification` https://github.com/bitcoin/bitcoin/pull/25574#discussion_r1110031541

💬 jamesob commented on pull request "assumeutxo: keep cache when flushing snapshot (#17487 followup)":
(https://github.com/bitcoin/bitcoin/pull/27008#discussion_r1117597926)
`AbortNode()` is used elsewhere in the function that this function is called from, although I did change another reference that you pointed out what inconsistent.

💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1117702466)
Thanks @kouloumos -- updated to "Disable writing the log to a file, as used for unit tests and fuzzing in `MakeNoLogFileContext`."

💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1117704951)
Thanks, @LarryRuane! Added a commit by you at the start of the changes here to fix the order dependency.

💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1117709540)
Great points. Fixed the -debug, ensured that we do it where needed, and added this comment at the top of the benchmarks, along with co-author to both of you in this commit (LMK if a name/email is incorrect).

```diff
+// The test framework currently enables all categories by default, but in case
+// that changes, we set -debug=category in the benchmarks below when we expect a
+// category to be logged.
```

💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#issuecomment-1444580916)
Thank you @kouloumos and @LarryRuane for the excellent reviewing. Updated per `git diff 9d708db a0e092e`

💬 rserranon commented on pull request "wallet: finish addressbook encapsulation":
(https://github.com/bitcoin/bitcoin/pull/26836#discussion_r1117586765)
Nit: Shouldn't be better to use the capital B in `LoadAddrBookEntryLablel` and `LoadAddrBookEntryPurpose` as in `GetAddrBookSize` and `ListAddrBookAddreses` ?

💬 rserranon commented on pull request "wallet: finish addressbook encapsulation":
(https://github.com/bitcoin/bitcoin/pull/26836#discussion_r1117807285)
Nice optimization!

💬 RandyMcMillan commented on pull request "script: add description for the functionality of each opcode":
(https://github.com/bitcoin/bitcoin/pull/27109#issuecomment-1444733518)
ACK 40f36d0a3dac568bc9b05dea021d83986d8add84

💬 mzumsande commented on issue "Intermittent issue in p2p_ibd_stalling.py self.wait_until(lambda: self.total_bytes_recv_for_blocks() == 172761)":
(https://github.com/bitcoin/bitcoin/issues/27112#issuecomment-1445002667)
The reason for the test failure is that peer 0 gets disconnected because of headers sync timeout after >25 minutes runtime, ruining the test, which should be much faster under normal conditions.
` node0 2023-02-14T20:26:20.075032Z [msghand] [net_processing.cpp:5768] [SendMessages] Timeout downloading headers from peer=0, disconnecting`

It looks to me like something strange is going on in the test environment - the test node appears to "freeze" multiple times for no apparent reason, with noth
...

⚠️ Victorcorreiaaraujo opened an issue: "J"
(https://github.com/bitcoin/bitcoin/issues/27161)
<!-- Needs the label "good first issue" assigned manually before or after opening -->

<!-- A good first issue is an uncontroversial issue, that has a relatively unique and obvious solution -->

<!-- Motivate the issue and explain the solution briefly -->

#### Useful skills:

<!-- (For example, “std::thread”, “Qt5 GUI and async GUI design” or “basic understanding of Bitcoin mining and the Bitcoin Core RPC interface”.) -->

#### Want to work on this issue?

For guidance on contributing, please r
...

✅ fanquake closed an issue: "J"
(https://github.com/bitcoin/bitcoin/issues/27161)

:lock: fanquake locked an issue: "J"
(https://github.com/bitcoin/bitcoin/issues/27161)

💬 Metapolitan22 commented on issue "interpreter: split PrecomputedTransactionData::Init() or rename `force`":
(https://github.com/bitcoin/bitcoin/issues/27152#issuecomment-1445025860)
Hello gents, we are searching for a Bitcoin dev which has some knowledge in ordinals and inscribing specific stats. Sorry for the message out of context.

💬 brunoerg commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1117926027)
nit: Since `blockman_opts` is empty here, I think you can pass it directly instead of creating `blockman_opts` for it.
```cpp
ChainstateManager chainman{chainman_opts, {}};
```

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1445127686)
Updated e248926c73ce6f707343501fb42b31090fed202b -> 25f9cbf7191ee80a640da5f5386aef9658f1168b ([`pr/oneconfig.2`](https://github.com/ryanofsky/bitcoin/commits/pr/oneconfig.2) -> [`pr/oneconfig.3`](https://github.com/ryanofsky/bitcoin/commits/pr/oneconfig.3), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/oneconfig.2..pr/oneconfig.3)) to fix lint spelling error https://cirrus-ci.com/task/5488540285403136

📝 fanquake locked a pull request: "2023.02.21 ci prep"
(https://github.com/bitcoin/bitcoin/pull/27136)
null