💬 vasild commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#discussion_r1117187548)
I tested this and there is one copy in either case. I guess the compiler is smart enough to avoid unnecessary copies.

📝 instagibbs opened a pull request: "Expand scantxoutset help text to cover tr() and miniscript"
(https://github.com/bitcoin/bitcoin/pull/27155)
null

⚠️ alex-lt-kong opened an issue: "Bitcoind crashed, how to debug"
(https://github.com/bitcoin/bitcoin/issues/27156)
OS: Debian GNU/Linux 11 (bullseye)
Available RAM: ~3GB

I run `bitcoind` on the machine by `~/bin/bitcoin-22.0/bin/bitcoind -daemon` as `root` (as this is a VM dedicated to `bitcoind`, no other ordinary users are added).
I make local RPC calls relatively frequently (up to 10k calls per sec) but only sequentially (i.e., the 2nd RPC call is only made if the first RPC call returned).

It usually works fine for a few days/weeks, then the process just disappears. The log is like the following (
...

💬 MarcoFalke commented on issue "Bitcoind crashed, how to debug":
(https://github.com/bitcoin/bitcoin/issues/27156#issuecomment-1443870264)
Did you check for OOM?

💬 fanquake commented on issue "Bitcoind crashed, how to debug":
(https://github.com/bitcoin/bitcoin/issues/27156#issuecomment-1443870993)
Going to assume this is related to lack-of-ram/a memory leak. You could run with `-debug` to produce more logs. You could also upgrade to 24.0.1, which may have fixed whichever bug you might be seeing.

💬 jonatack commented on pull request "Remove Sock::Get() and Sock::Sock()":
(https://github.com/bitcoin/bitcoin/pull/26312#issuecomment-1443941348)
re-ACK e536b3a67b390c3c46dce99cb7466862d3fd4863 per `git range-diff be2e748 c40c257 e536b3a`

💬 alex-lt-kong commented on issue "Bitcoind crashed, how to debug":
(https://github.com/bitcoin/bitcoin/issues/27156#issuecomment-1443945435)
> Going to assume this is related to lack-of-ram/a memory leak. You could run with `-debug` to produce more logs. You could also upgrade to 24.0.1, which may have fixed whichever bug you might be seeing.

I always download Bitcoin Core from https://bitcoin.org/en/download, is this considered the "official" site? On this site the latest version is 22.0 so I am still using 22.0.

💬 alex-lt-kong commented on issue "Bitcoind crashed, how to debug":
(https://github.com/bitcoin/bitcoin/issues/27156#issuecomment-1443949225)
> Did you check for OOM?

I thought about this, but consider that the [requirements page](https://bitcoin.org/en/bitcoin-core/features/requirements) shows that 1GB is enough, I did not investigate this possibility thoroughly. Btw, is `bitcoin.org` considered the "official" site anyway?

💬 fanquake commented on issue "Bitcoind crashed, how to debug":
(https://github.com/bitcoin/bitcoin/issues/27156#issuecomment-1443951699)
> I always download Bitcoin Core from https://bitcoin.org/en/download, is this considered the "official" site?

The website for the Bitcoin Core project is https://bitcoincore.org/en/download/. bitcoin.org currently lists an outdated version of Bitcoin Core for download.

💬 alex-lt-kong commented on issue "Bitcoind crashed, how to debug":
(https://github.com/bitcoin/bitcoin/issues/27156#issuecomment-1443959034)
>



> > I always download Bitcoin Core from https://bitcoin.org/en/download, is this considered the "official" site?
>
> The website for the Bitcoin Core project is https://bitcoincore.org/en/download/. bitcoin.org currently lists an outdated version of Bitcoin Core for download.

Okay then. Let me close the issue, upgrade to 24.0 and increase available RAM. See if the problem could be solved.

✅ alex-lt-kong closed an issue: "Bitcoind crashed, how to debug"
(https://github.com/bitcoin/bitcoin/issues/27156)

💬 jonatack commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#issuecomment-1443962823)
> I will try to mimic the proxy in order to address the latter.

In case you plan to do that in a follow-up:

re-ACK c2a86ba6674008996552830877d66a1bf888fad1 per `git range-diff be2e748 8991ed2c6e c2a86ba667`

💬 fanquake commented on issue "contrib/install_db4.sh script fails on OpenBSD 7.2 (RPi 3) (error: Unable to find a mutex implementation)":
(https://github.com/bitcoin/bitcoin/issues/26860#issuecomment-1443978351)
@m-kubik were you compiling the master branch? We have since removed this script, in favour of using depends. You can see the updated OpenBSD build instructions here: https://github.com/bitcoin/bitcoin/blob/master/doc/build-openbsd.md.

👍 pinheadmz approved a pull request: "bumpfee: Allow the user to choose which output is change"
(https://github.com/bitcoin/bitcoin/pull/26467)
ACK 4167843e0729994954317e2a4ac8a96a453bad79

reviewed code, ran tests. Played with the feature on regtest and in particular using `reduce_output` to intentionally reduce the recipient output instead of the original change output added automatically by `sendtoaddress`. I don't think is explicitly covered in the test but could be. One other quesiton about the test below but otherwise LGTM

<details><summary>Show Signature</summary>

```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

A
...

💬 pinheadmz commented on pull request "bumpfee: Allow the user to choose which output is change":
(https://github.com/bitcoin/bitcoin/pull/26467#discussion_r1117235969)
Will `new_change_pos == change_pos` always here? Or are the outputs of the replacement re-randomized?

💬 fanquake commented on pull request "Fix various libbitcoinkernel DLL build problems":
(https://github.com/bitcoin/bitcoin/pull/27146#issuecomment-1444014647)
This also fixes #19772.

👍 stickies-v approved a pull request: "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`"
(https://github.com/bitcoin/bitcoin/pull/26261)
re-ACK [0566f17](https://github.com/bitcoin/bitcoin/commit/0566f171771e37dca02adc328e0385edbb412073)

I verified that the only changes since https://github.com/bitcoin/bitcoin/commit/84b3ab40d5480862f3f7e08c4ad1f9124990ba74 are:
- resolving the merge conflict from https://github.com/bitcoin/bitcoin/pull/25619
- in `ProcessUpnp()`, [replace](https://github.com/bitcoin/bitcoin/compare/4b0c5ca1315cee243280cbaf2afea6fe5d26d9db..ece6012cf18e096e053e45ebbb31898c6fb7871a?diff=unified#diff-641555124
...

💬 john-moffett commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#discussion_r1117323095)
`m_untouched_memory_end` now called `m_available_memory_end`

👍 john-moffett approved a pull request: "Add pool based memory resource"
(https://github.com/bitcoin/bitcoin/pull/25325)
ACK d87cb99bb37637e26a9e00b9f7de4bc6f44cb79d

Tested and code reviewed. Very nice improvement.

Left tiny nits in documentation, but please ignore unless updating for other reasons.

💬 john-moffett commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#discussion_r1117328292)
Extra "is" after "memory".