Bitcoin Core Github
44 subscribers
121K links
Download Telegram
🚀 achow101 merged a pull request: "p2p: give seednodes time before falling back to fixed seeds"
(https://github.com/bitcoin/bitcoin/pull/27577)
👍 theStack approved a pull request: "BIP324: ElligatorSwift integrations"
(https://github.com/bitcoin/bitcoin/pull/27479#pullrequestreview-1496080860)
re-ACK 3168b08043546cd248a81563e21ff096019f1521
📝 brunoerg opened a pull request: "net: remove unused `CConnmanTest`"
(https://github.com/bitcoin/bitcoin/pull/27957)
`CConnmanTest` was removed in fa72fce7c948185752a01002000ea511809146ed.
💬 achow101 commented on pull request "net, refactor: net_processing, add `ProcessCompactBlockTxns`":
(https://github.com/bitcoin/bitcoin/pull/26969#issuecomment-1605045047)
ACK 77d6d89d43cc5969c98d9b4b56a1e877b473e731

Verified diff is primarily a moveonly that removes the recursion for `BLOCKTXN`.
🚀 achow101 merged a pull request: "net, refactor: net_processing, add `ProcessCompactBlockTxns`"
(https://github.com/bitcoin/bitcoin/pull/26969)
💬 D33r-Gee commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1240478946)
this works now tested ACK on WSL Ubuntu 22.04
👍 Ayush170-Future approved a pull request: "net: remove unused `CConnmanTest`"
(https://github.com/bitcoin/bitcoin/pull/27957#pullrequestreview-1496154644)
ACK.

I also used Github's search feature to ensure that there are no other instances of `CConnmanTest` in the whole Bitcoin Core source code. So, this is the last one left.
💬 AndriiHlukhovskyi commented on issue "Package Relay Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/27463#issuecomment-1605081489)
Super
💬 achow101 commented on pull request "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)":
(https://github.com/bitcoin/bitcoin/pull/27631#issuecomment-1605082647)
ACK 54877253c807dac7a3720b2c3d1d989c410259a7
achow101 closed an issue: "ci: failure in feature_taproot.py (TSAN)"
(https://github.com/bitcoin/bitcoin/issues/27595)
🚀 achow101 merged a pull request: "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)"
(https://github.com/bitcoin/bitcoin/pull/27631)
🤔 jarolrod reviewed a pull request: "doc: i2p documentation updates"
(https://github.com/bitcoin/bitcoin/pull/27937#pullrequestreview-1496247714)
Concept ACK

Just finished going through setting this up with core on a clean ubuntu install. The changes here are nice cleanups for the documentation, which is important to get people up and running with these alternative networks.
💬 jarolrod commented on pull request "doc: i2p documentation updates":
(https://github.com/bitcoin/bitcoin/pull/27937#discussion_r1240545754)
I would squash commit 6c874b59d1a577b0349c1a04e7e329efba326d37 into 4988ad4ea94c848f1109a88fd7a955d2234090a8
💬 luke-jr commented on pull request "Prevent file descriptor exhaustion from too many RPC calls":
(https://github.com/bitcoin/bitcoin/pull/27731#discussion_r1240557560)
Won't runtime linking fail to find the `evhttp_set_max_connections` symbol?
💬 luke-jr commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#issuecomment-1605210547)
Would prefer to keep refactoring and bugfixes in separate PRs, if there's no reason they have to be together here?
💬 luke-jr commented on pull request "Make non-standard tx acceptance a peer option.":
(https://github.com/bitcoin/bitcoin/pull/27772#issuecomment-1605223931)
See also #7533 and #25532
💬 luke-jr commented on pull request "wallet: clarify replace fields in help output":
(https://github.com/bitcoin/bitcoin/pull/27782#issuecomment-1605225045)
otoh, it would be nice to populate these when we detect a replaced receive tx...
💬 luke-jr commented on pull request "rpc: Be able to access RPC parameters by name":
(https://github.com/bitcoin/bitcoin/pull/27788#issuecomment-1605225921)
#17356
💬 luke-jr commented on pull request "guix: Update `python-lief` package to 0.13.2":
(https://github.com/bitcoin/bitcoin/pull/27813#issuecomment-1605228211)
Would be better to use Guix upstream's lief if possible. Unbundled deps is better, not worse.

If upstream is broken at present, concept ACK for now.
👍 luke-jr approved a pull request: "Blocking arguments -nohelp, -noh, and -no?"
(https://github.com/bitcoin/bitcoin/pull/27814#pullrequestreview-1496289271)
utACK