💬 achow101 commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1240159141)
Fixed. Apparently `AskpassphraseDialog` didn't set `m_passphrase_out` for `Unlock`. I've added a commit to do that and migration of encrypted wallets now works.

💬 sipa commented on pull request "BIP324: ElligatorSwift integrations":
(https://github.com/bitcoin/bitcoin/pull/27479#discussion_r1240159729)
Fixed both.

💬 sipa commented on pull request "BIP324: ElligatorSwift integrations":
(https://github.com/bitcoin/bitcoin/pull/27479#discussion_r1240160094)
I've changed it to 8/8/16, and added rationale why in a comment.

💬 sipa commented on pull request "BIP324: ElligatorSwift integrations":
(https://github.com/bitcoin/bitcoin/pull/27479#discussion_r1240160552)
I've added a comment.

💬 sipa commented on pull request "BIP324: ElligatorSwift integrations":
(https://github.com/bitcoin/bitcoin/pull/27479#issuecomment-1604682504)
@theStack I've dropped the `--enable-module-ellswift`, but I believe the MSVC build change remains necessary (as it isn't influenced by the `./configure` defaults).

💬 luke-jr commented on pull request "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)":
(https://github.com/bitcoin/bitcoin/pull/27631#issuecomment-1604683265)
Concept ACK

💬 sipa commented on pull request "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)":
(https://github.com/bitcoin/bitcoin/pull/27631#issuecomment-1604684451)
utACK 54877253c807dac7a3720b2c3d1d989c410259a7

💬 hebasto commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1604684907)
Guix builds:
```
109ed45706b8cbdc897b6c51efa0247f8e8f1e6bb35c57e69f30093b62189a51 guix-build-3df60704661c/output/aarch64-linux-gnu/SHA256SUMS.part
4e28463f1c074c7c121abd5fbad89aa2269c5978829ccd4898d33a21eedfeb4f guix-build-3df60704661c/output/aarch64-linux-gnu/bitcoin-3df60704661c-aarch64-linux-gnu-debug.tar.gz
f20d074f0529202274a40f0530f79f601f5c575f1cd0addc099418719982485e guix-build-3df60704661c/output/aarch64-linux-gnu/bitcoin-3df60704661c-aarch64-linux-gnu.tar.gz
414d7c4bf531a8d8589
...

💬 theuni commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1604700457)
> > just need to decide out what to do about guix.
>
> What options are currently being considered. Is an upstream patch still possible?

FWIW, though we didn't end up needing it, an upstream guix "fix" is [slotted to go in as well](https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64100), which we can pick up in some future time-machine bump.

That gives us the ability to customize our clang build if we ever need to in the future.

💬 luke-jr commented on pull request "build: Do not define `ENABLE_ZMQ` when ZMQ is not available":
(https://github.com/bitcoin/bitcoin/pull/27696#issuecomment-1604726809)
Huh? This looks wrong... `#if` does check the value.

💬 instagibbs commented on pull request "BIP324: ElligatorSwift integrations":
(https://github.com/bitcoin/bitcoin/pull/27479#issuecomment-1604739539)
reACK https://github.com/bitcoin/bitcoin/pull/27479/commits/3168b08043546cd248a81563e21ff096019f1521

💬 hebasto commented on pull request "build: Do not define `ENABLE_ZMQ` when ZMQ is not available":
(https://github.com/bitcoin/bitcoin/pull/27696#issuecomment-1604760085)
> Huh? This looks wrong... `#if` does check the value.

It does. But when the build system either defines `VAR` to `1` or leaves it undefined, the behavior of `#if VAR` and `#ifdef VAR` is the same, which is the case in this PR.

💬 achow101 commented on pull request "Wallet: estimate the size of signed inputs using descriptors":
(https://github.com/bitcoin/bitcoin/pull/26567#discussion_r1240233314)
This wasn't changed?

💬 achow101 commented on pull request "Wallet: estimate the size of signed inputs using descriptors":
(https://github.com/bitcoin/bitcoin/pull/26567#discussion_r1240225981)
In 3e3521bf956c4387abe4b6ce12ce55224a9e97ba "miniscript: introduce a helper to get the maximum witness size"

I don't quite follow why `subs[0]` needs an additional `+ 1` that `subs[1]` doesn't have. AFAICT, `subs[0]` just has a `1` in the witness, while `subs[1]` has a `0`, and both should be the same size.

💬 achow101 commented on pull request "assumeutxo: catch and log fs::remove error instead of two exist checks":
(https://github.com/bitcoin/bitcoin/pull/26828#issuecomment-1604894784)
ACK 0e21b56a44d53cec9080edb04410a692717f1ddc

🚀 achow101 merged a pull request: "assumeutxo: catch and log fs::remove error instead of two exist checks"
(https://github.com/bitcoin/bitcoin/pull/26828)

💬 furszy commented on pull request "wallet: bugfix, always use apostrophe for spkm descriptor ID":
(https://github.com/bitcoin/bitcoin/pull/27920#issuecomment-1604907150)
Updated based on feedback, thanks @Sjors.

I pulled your test commit and made some changes. While reviewing it, discovered that the descriptors containing a key with an origin are actually incorrect. The origin consists of a root xpub fingerprint and the key derivation path, and this needs to be formatted with an apostrophe as well. Therefore, have updated the code and tests to address the issue. I also expanded the coverage for a few other descriptors that were previously not included.

To
...

💬 achow101 commented on pull request "wallet: Give deprecation warning when loading a legacy wallet":
(https://github.com/bitcoin/bitcoin/pull/27869#discussion_r1240354037)
updated

🚀 achow101 merged a pull request: "[coinselection] Increase SRD target by change_fee"
(https://github.com/bitcoin/bitcoin/pull/27846)

💬 achow101 commented on pull request "p2p: give seednodes time before falling back to fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/27577#issuecomment-1605005735)
ACK 30778124b82791abdc6e930373460ef1dd587cb2

Code looks good and a manual test showed that there is now a 1 minute wait after attempting a seednode before the fixed seeds are added.