💬 achow101 commented on pull request "wallet: Load database records in a particular order":
(https://github.com/bitcoin/bitcoin/pull/24914#discussion_r1240056360)
Added to that commit message.

📝 ephantusmurori001 opened a pull request: "Create FVCszdsfvs"
(https://github.com/bitcoin/bitcoin/pull/27956)
dsgds

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

💬 ephantusmurori001 commented on pull request "Create FVCszdsfvs":
(https://github.com/bitcoin/bitcoin/pull/27956#issuecomment-1604572160)
SFvszfvsdgsdgrd78

💬 ephantusmurori001 commented on pull request "Create FVCszdsfvs":
(https://github.com/bitcoin/bitcoin/pull/27956#issuecomment-1604572408)
zVFsdzfgsdgd

✅ fanquake closed a pull request: "Create FVCszdsfvs"
(https://github.com/bitcoin/bitcoin/pull/27956)

📝 fanquake locked a pull request: "Create FVCszdsfvs"
(https://github.com/bitcoin/bitcoin/pull/27956)
dsgds

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

🤔 pablomartin4btc reviewed a pull request: "Disable and uncheck blank when private keys are disabled"
(https://github.com/bitcoin-core/gui/pull/739#pullrequestreview-1495428197)
Tested ACK.

I think there's a concise description on identifying these "disable private keys" and "blank wallet" concepts by @achow101 [here](https://github.com/bitcoin-core/gui/issues/69#issuecomment-678691104).

I like the approach on replacing the checkboxes by radiobuttons proposed in #69 and bringing it here by [@ryanofsky](https://github.com/bitcoin-core/gui/pull/739#issuecomment-1600761925), I also like the fact having the description under each optiion, and more practical (removing
...

💬 pablomartin4btc commented on pull request "Disable and uncheck blank when private keys are disabled":
(https://github.com/bitcoin-core/gui/pull/739#discussion_r1239996960)
Perhaps this is visually clearer for the user.

💬 luke-jr commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#issuecomment-1604583839)
I wonder if there should be a `noprivacy` permission flag...

💬 pinheadmz commented on pull request "net: Add new permission `forceinbound` to evict a random unprotected connection if all slots are otherwise full":
(https://github.com/bitcoin/bitcoin/pull/27600#issuecomment-1604613277)
> Would be better to score the peers rather than choose one at random.

I had logic for this initially but preferred [this suggestion](https://github.com/bitcoin/bitcoin/pull/27600#pullrequestreview-1431340479) by @mzumsande

💬 achow101 commented on pull request "Disable and uncheck blank when private keys are disabled":
(https://github.com/bitcoin-core/gui/pull/739#discussion_r1240104159)
Done

💬 F0rsX commented on issue "Different versions":
(https://github.com/bitcoin/bitcoin/issues/27936#issuecomment-1604624981)
Strange that the wikipedia link is to bitcoin.org https://en.wikipedia.org/wiki/Bitcoin

💬 jonatack commented on pull request "Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs":
(https://github.com/bitcoin/bitcoin/pull/27231#discussion_r1240112630)
LGTM (and with just `return result;`) and this allows dropping the `#include <util/check.h>` from that file.

💬 Crypt-iQ commented on pull request "http: add evhttp_connection_set_closecb to avoid g_requests hang":
(https://github.com/bitcoin/bitcoin/pull/27909#issuecomment-1604635264)
> @Crypt-iQ There is no need to close this PR now since it got attention and review. I will close mine if you want to continue. But I wanted to clarify this for the future.

I think you can reopen your PR to include the bufferevent read enable. I've updated this PR to include a minimal fix for the issue (without the bufferevent read enable) because I'm still a little unclear on what exactly the bug fix was originally for and I can't reproduce it. Also happy to close this PR in favor of yours s
...

💬 Crypt-iQ commented on pull request "http: add evhttp_connection_set_closecb to avoid g_requests hang":
(https://github.com/bitcoin/bitcoin/pull/27909#discussion_r1240122246)
I've updated the PR and removed this

💬 jonatack commented on pull request "Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs":
(https://github.com/bitcoin/bitcoin/pull/27231#issuecomment-1604660838)
Thank you @pinheadmz and @ajtowns for the review; updated commit 8f336e2dafdc44430e0ae75384bfa4069d7ff796 per https://github.com/bitcoin/bitcoin/pull/27231#discussion_r1239861077.

<details><summary><code>git diff 630b38e 08a367c</code></summary><p>

```diff
--- a/src/init/common.cpp
+++ b/src/init/common.cpp
@@ -11,7 +11,6 @@
#include <logging.h>
#include <node/interface_ui.h>
#include <tinyformat.h>
-#include <util/check.h>
#include <util/fs.h>
#include <util/fs_helpers.h>

...

💬 luke-jr commented on pull request "doc: remove version number from bips.md":
(https://github.com/bitcoin/bitcoin/pull/27629#issuecomment-1604674190)
late nit: release-process.md still talks about the "version number on the first line" :/

💬 achow101 commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1240157865)
Done

💬 achow101 commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1240158149)
Done

💬 achow101 commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1240158478)
Done