💬 fanquake commented on pull request "test: add coverage for invalid parameter in `keypoolrefill`":
(https://github.com/bitcoin/bitcoin/pull/26731#issuecomment-1432821927)
Doesn't seem to be agreement on doing this. Closing for now.

✅ fanquake closed a pull request: "test: add coverage for invalid parameter in `keypoolrefill`"
(https://github.com/bitcoin/bitcoin/pull/26731)

🚀 fanquake merged a pull request: "Signing support for Miniscript Descriptors"
(https://github.com/bitcoin/bitcoin/pull/24149)

💬 AdmiralNeo commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1432858653)
Guys - the user experience is horrible. I download Bitcoin Core from the official webpage - Norton kills my download as it falsely ecognizes it as a virus, if I temporarily disable Norton Apple prevents me from opening the downloaded program cause the signing key is outdated, if I manage to get a valid signing key and work around Apple preventions Norton kills the running software. This is the future of money? So what is the right way to run BTC Core?

📝 fanquake opened a pull request: "doc: remove mention of "proper signing key""
(https://github.com/bitcoin/bitcoin/pull/27107)
This key is no-longer in use: https://lists.linuxfoundation.org/pipermail/bitcoin-core-dev/2023-February/000115.html
> Please remove it from verification pipelines.

👍 hebasto approved a pull request: "doc: remove mention of "proper signing key""
(https://github.com/bitcoin/bitcoin/pull/27107)

💬 fanquake commented on pull request "explicit `-d/--delete` argument for verifybinaries/verify.py":
(https://github.com/bitcoin/bitcoin/pull/26985#issuecomment-1432870417)
Thanks, however this script needs much more work, to make it usable/useful, and this is already underway in #23020. Maybe you'd be interested in reviewing there instead? Going to close this for now.

✅ fanquake closed a pull request: "explicit `-d/--delete` argument for verifybinaries/verify.py"
(https://github.com/bitcoin/bitcoin/pull/26985)

💬 fanquake commented on pull request "doc: Fixup remove 'omitted...' doc for rpc getrawtransaction when verbose is 2":
(https://github.com/bitcoin/bitcoin/pull/26968#issuecomment-1432872397)
@dougEfresh are you going to followup here?

💬 fanquake commented on pull request "I2P network optimizations":
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1432878081)
What are the next steps here? Does this just need more sanity checking from anyone who actually runs with i2p? I assume whatever upstream releases we may/may not have been waiting for have happened by now?

👍 fanquake approved a pull request: "doc: FreeBSD build doc updates to reflect removal of install_db4.sh"
(https://github.com/bitcoin/bitcoin/pull/26773)

💬 fanquake commented on pull request "refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc":
(https://github.com/bitcoin/bitcoin/pull/26840#issuecomment-1432886086)
@achow101 any thoughts on the best way/time to merge this? Conflicting with a lot of other changes.

💬 fanquake commented on pull request "doc: FreeBSD DataDirectoryGroupReadable Setting":
(https://github.com/bitcoin/bitcoin/pull/26741#issuecomment-1432888644)
@jessebarton want to followup here?

💬 fanquake commented on pull request "test: previous releases: add v24.0.1":
(https://github.com/bitcoin/bitcoin/pull/26586#issuecomment-1432890478)
Not sure what to do here. @Sjors?

💬 vasild commented on pull request "I2P network optimizations":
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1432902206)
Like usual, after this is deemed to have had enough review and testing it can be merged. It is not tied to or dependent on I2P releases.

💬 scgbckbone commented on pull request "explicit `-d/--delete` argument for verifybinaries/verify.py":
(https://github.com/bitcoin/bitcoin/pull/26985#issuecomment-1433007940)
didn't know about that, will have a look - thanks

📝 fanquake converted_to_draft a pull request: "More verbose warning for multiple network argument error."
(https://github.com/bitcoin/bitcoin/pull/26028)
This PR has bitcoin print a more verbose message when a network argument collisions happens.
I'm new to using the bitcoin software and was reconfiguring an old node. I also have limited experience at coding, this is my first PR on an open-source project, so any feedback on how to improve this process is welcomed.

If a chain argument is in the bitcoin.conf and then a bitcoin command has a network flag or a chain argument, such as : bitcoind -regtest currently you are presented with the mess
...

🚀 fanquake merged a pull request: "util: remove WSL 1 workaround in fs"
(https://github.com/bitcoin/bitcoin/pull/25898)

💬 fanquake commented on pull request "lint: enable E722 do not use bare except":
(https://github.com/bitcoin/bitcoin/pull/25867#issuecomment-1433021178)
@MarcoFalke merge or close?

💬 fanquake commented on pull request "build: Fail early and show actionable messages if autogen deps are missing":
(https://github.com/bitcoin/bitcoin/pull/25523#issuecomment-1433024510)
Thanks. However I don't think we are going to merge this. We'll also soon be migrating away from autotools & friends.