💬 achow101 commented on pull request "refactor: Disable unused special members functions in `UnlockContext`":
(https://github.com/bitcoin-core/gui/pull/711#issuecomment-1432221567)
ACK 9fa43b5af6b180f4b5f76726f443ee60259d2cd0

👍 furszy approved a pull request: "wallet: SecureString to allow null characters"
(https://github.com/bitcoin/bitcoin/pull/27068)

🚀 achow101 merged a pull request: "refactor: Disable unused special members functions in `UnlockContext`"
(https://github.com/bitcoin-core/gui/pull/711)

💬 achow101 commented on pull request "prune, import: allow pruning to work during loadblock import":
(https://github.com/bitcoin/bitcoin/pull/24957#issuecomment-1432400864)
ACK 734355b470764c523ef08b25320a5fabb73358a6

💬 achow101 commented on pull request "prune, import: allow pruning to work during loadblock import":
(https://github.com/bitcoin/bitcoin/pull/24957#issuecomment-1432403217)
Looks like there's a silent merge conflict:

```
../../../src/validation.cpp: In member function ‘void Chainstate::LoadExternalBlockFile(FILE*, FlatFilePos*, std::multimap<uint256, FlatFilePos>*)’:
../../../src/validation.cpp:4518:21: error: ‘fPruneMode’ was not declared in this scope; did you mean ‘node::fPruneMode’?
4518 | if (fPruneMode && !fReindex && pblock) {
| ^~~~~~~~~~
| node::fPruneMode
In file included from .
...

💬 ponury1990 commented on pull request "Fix minor typo":
(https://github.com/bitcoin/bitcoin/pull/27102#issuecomment-1432652741)
Pierwszy raz w życiu to robię ja tylko chce zamienić dokumentacje wraz z pulą BTC jestem samouk z bardzo małym stażem

💬 vasild commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#issuecomment-1432702025)
Just thinking aloud:

1. Subnetting does not make sense for tor/i2p/cjdns
2. `BanMan` entries are always subnets (`CSubNet` objects), even for single host bans

It follows that banman is doing something that does not make sense (e.g. subnetting tor). This is the root of the problem. I think if that is eradicated, then the rest will untangle by itself.

What this means - store two ban maps in `BanMan` - one for single hosts and one for subnets (only for IPv[46] subnets). This way also look
...

💬 vasild commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#discussion_r1108164412)
The double lock detection inside `LOCK()` is only if `DEBUG_LOCKORDER` is defined.

👋 hebasto's pull request is ready for review: "clang-tidy: Add more `performance-*` checks and related fixes"
(https://github.com/bitcoin/bitcoin/pull/26642)

💬 hebasto commented on pull request "clang-tidy: Add more `performance-*` checks and related fixes":
(https://github.com/bitcoin/bitcoin/pull/26642#discussion_r1108186877)
@martinus

The commented code is no longer relevant since https://github.com/bitcoin-core/gui/pull/711.

Nevertheless, I've dropped `performance-noexcept-move-constructor` commit for a follow up as it requires more thorough reviewing for similar cases.

💬 hebasto commented on pull request "clang-tidy: Add more `performance-*` checks and related fixes":
(https://github.com/bitcoin/bitcoin/pull/26642#issuecomment-1432738411)
Ready for a (final?) review now :)

💬 AdmiralNeo commented on issue "Mac OS latest Bitcoin core latest release will not run as Mac OS, "you can't open the application 'Bitcoin core'"":
(https://github.com/bitcoin/bitcoin/issues/25834#issuecomment-1432786407)
<img width="1015" alt="Norton kills BTC-Downloads" src="https://user-images.githubusercontent.com/125405780/219325517-20fd4eb9-077a-4a06-b6f7-2dea20ce51ef.png">
Norton kills my BTC Core downloads from https://bitcoincore.org/en/download/)

👍 TheCharlatan approved a pull request: "refactor: wallet, remove global 'ArgsManager' dependency"
(https://github.com/bitcoin/bitcoin/pull/26889)

👍 fanquake approved a pull request: "psbt: s/transcation/transaction/"
(https://github.com/bitcoin/bitcoin/pull/26997)

🚀 fanquake merged a pull request: "psbt: s/transcation/transaction/"
(https://github.com/bitcoin/bitcoin/pull/26997)

💬 fanquake commented on pull request "Remove laanwj from trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27054#discussion_r1108235207)
Lets sort this out in a followup, like #27058.

👍 fanquake approved a pull request: "Remove laanwj from trusted-keys"
(https://github.com/bitcoin/bitcoin/pull/27054)

🚀 fanquake merged a pull request: "Remove laanwj from trusted-keys"
(https://github.com/bitcoin/bitcoin/pull/27054)

👍 fanquake approved a pull request: "net: remove orphaned CSubNet::SanityCheck()"
(https://github.com/bitcoin/bitcoin/pull/27106)

👍 fanquake approved a pull request: "test: add coverage for unparsable `-maxuploadtarget`"
(https://github.com/bitcoin/bitcoin/pull/26714)