💬 achow101 commented on pull request "qa: feature_framework_startup_failures.py fixes & improvements (#30660 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/32509#issuecomment-2914136270)
ACK bf950c4544d3a8478b46faf0b93c0dc647274c9b

✅ achow101 closed an issue: "test: feature_framework_startup_failures.py fails with `--timeout-factor=0`"
(https://github.com/bitcoin/bitcoin/issues/32506)

🚀 achow101 merged a pull request: "qa: feature_framework_startup_failures.py fixes & improvements (#30660 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/32509)

💬 achow101 commented on pull request "refactor: validation: mark CheckBlockIndex as const":
(https://github.com/bitcoin/bitcoin/pull/32364#issuecomment-2914316033)
ACK 3e6ac5bf772751c66cdcd015dcb7e6ce4ea2cc77

🤔 w0xlt reviewed a pull request: "wallet, rpc, gui: List legacy wallets with a message about migration"
(https://github.com/bitcoin/bitcoin/pull/32619#pullrequestreview-2872880040)
Code Review ACK https://github.com/bitcoin/bitcoin/pull/32619/commits/f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c

🤔 w0xlt reviewed a pull request: "fuzz: wallet: add target for `MigrateToDescriptor`"
(https://github.com/bitcoin/bitcoin/pull/32624#pullrequestreview-2872882290)
Approach ACK

🤔 w0xlt reviewed a pull request: "contrib: utxo_to_sqlite.py: add option to store txid/spk as BLOBs"
(https://github.com/bitcoin/bitcoin/pull/32621#pullrequestreview-2872887303)
ACK https://github.com/bitcoin/bitcoin/pull/32621/commits/aaf11735040621efbce88d51d5c9f6e3c3470de3

🤔 w0xlt reviewed a pull request: "wallet: Keep track of the wallet's own transaction outputs in memory"
(https://github.com/bitcoin/bitcoin/pull/27286#pullrequestreview-2872890684)
reACK https://github.com/bitcoin/bitcoin/pull/27286/commits/d73e4f878d143fe86d84e0e6f18c2a88c0cb8609

🚀 achow101 merged a pull request: "refactor: validation: mark CheckBlockIndex as const"
(https://github.com/bitcoin/bitcoin/pull/32364)

💬 furszy commented on issue "Assertion failed: TxStateSerializedIndex(wtx.m_state) == TxStateSerializedIndex(state) (wallet/wallet.cpp: AddToWallet: 1094)":
(https://github.com/bitcoin/bitcoin/issues/32625#issuecomment-2914393585)
This was fixed in v29, specifically in #31757.

💬 achow101 commented on pull request "validation: stricter internal handling of invalid blocks":
(https://github.com/bitcoin/bitcoin/pull/31405#issuecomment-2914394066)
ACK ed172d3002da68a3ddbd5d13e7d3f0618c1378d4

Would prefer if others more familiar with consensus could review this before merging.

💬 ajtowns commented on pull request "contrib: utxo_to_sqlite.py: add option to store txid/spk as BLOBs":
(https://github.com/bitcoin/bitcoin/pull/32621#issuecomment-2914409947)
> I think I'd intuitively prefer `raw` for storing them in the hash order, since that's AFAICT the most common txid byte-string serialization

Maybe `raw` and `rawle` then? For future consideration `--spk=type` so that it only records whether the spk was p2pk, p2pkh, p2sh, p2wpkh, p2wsh, p2tr, p2a, or other would probably be interesting.

💬 achow101 commented on pull request "rpc: Round verificationprogress to 1 for a recent tip":
(https://github.com/bitcoin/bitcoin/pull/32528#issuecomment-2914423148)
ACK fab1e02086ceebd7d96417b7a386fe61158bfda9

✅ achow101 closed an issue: "getblockchaininfo `verificationprogress` never reaches 1.0"
(https://github.com/bitcoin/bitcoin/issues/31127)

🚀 achow101 merged a pull request: "rpc: Round verificationprogress to 1 for a recent tip"
(https://github.com/bitcoin/bitcoin/pull/32528)

💬 adyshimony commented on pull request "walletdb: Log additional exception error messages for corrupted wallets":
(https://github.com/bitcoin/bitcoin/pull/32598#discussion_r2110617435)
nit: const std::runtime_error& e

💬 ajtowns commented on issue "Remove Ambiguity of Script ASM Hex and Decimal Integer Representations":
(https://github.com/bitcoin/bitcoin/issues/27795#issuecomment-2914564531)
I've had a go at implementing the above approach; code is at https://github.com/ajtowns/bitcoin/commits/202505-asmdecode/

For testing purposes I've changed the decodescript rpc to accept assembly as input, since that's now a superset of hex encoding. I've also done the round-trip fuzzing in the script -> assembly -> script direction; it seems to work so far.

Examples:

```sh
$ bitcoin-cli -regtest decodescript '51204af12dcd91328acf048740f90666e4f4a88d809f0882ad6f2b4440ddae78cb43' | jq -r .asm

...

💬 ajtowns commented on pull request "Fix ASM ambiguity":
(https://github.com/bitcoin/bitcoin/pull/28824#issuecomment-2914569029)
for anyone following this pr but not the issue, https://github.com/bitcoin/bitcoin/issues/27795#issuecomment-2914564531

💬 davidgumberg commented on pull request "p2p: Drop unsolicited CMPCTBLOCK from non-HB peer":
(https://github.com/bitcoin/bitcoin/pull/32606#issuecomment-2914621423)
Rebased to address @ajtowns and @mzumsande feedback.

💬 adyshimony commented on pull request "walletdb: Log additional exception error messages for corrupted wallets":
(https://github.com/bitcoin/bitcoin/pull/32598#discussion_r2110720147)
nit: pwallet->WalletLogPrintf("Error loading wallet - runtime error: %s\n", e.what());