💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.5":
(https://github.com/bitcoin/bitcoin/pull/32431#discussion_r2110727815)
Good catch, I've removed this.

💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.5":
(https://github.com/bitcoin/bitcoin/pull/32431#discussion_r2110727951)
Thanks, fixed.

💬 davidgumberg commented on pull request "deps: Bump lief to 0.16.5":
(https://github.com/bitcoin/bitcoin/pull/32431#issuecomment-2914679651)
Thanks for the suggested fix @hebasto, bumping the guix time machine to [a786cd333c738dacdf156752b428f572b31382b0](https://codeberg.org/guix/guix/commit/a786cd333c738dacdf156752b428f572b31382b0) seems to fix building lief 0.16.5. But, it introduces other, unrelated issues with the guix build, so I've rebased on the time machine change, but leaving this as draft for now while investigating.

<details> <summary> Error in riscv64 build </summary>

```
- /tmp/guix-build-glibc-cross-riscv64-lin
...

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110817020)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110822058)
Added a commit with a test like this, with some changes. LMK what you think.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110821680)
Done. Also organized the fields of `struct TrimTxData` a bit more logically, into "Populated by Cluster::AppendTxData" and "Only used internally in TxGraphImpl::Trim" sections.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110821096)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110821027)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820886)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820614)
Forgot to take this. Will leave open for now.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820827)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110819198)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820744)
Done.

💬 sipa commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#discussion_r2110820382)
I've written a test based on this, which randomly adds dependencies but in a "directed" sense that never introduces cycles (rather than just has 2 specific scenarios).

💬 saikiran57 commented on pull request "Added rescan option for import descriptors":
(https://github.com/bitcoin/bitcoin/pull/31668#issuecomment-2915121835)
Hi @achow101 @maflcko @davidrobinsonau can you please check this once and merge it everything is fine.

💬 Sjors commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2915387816)
#31375 landed!

Still in draft waiting for https://github.com/bitcoin-core/libmultiprocess/pull/172

💬 Sjors commented on issue "Stratum v2 via IPC Mining Interface tracking issue":
(https://github.com/bitcoin/bitcoin/issues/31098#issuecomment-2915399359)
The wrapper binary PR #31375 just landed, which is great progress!

The only big change left is to add bitcoin-node (aka `bitcoin -m`) to the release binaries, which is what #31802 does.

💬 i-am-yuvi commented on pull request "p2p: protect addnode peers during IBD":
(https://github.com/bitcoin/bitcoin/pull/32051#issuecomment-2915403993)
Code Review ACK 93b07997e9a38523f5ab850aa32ca57983fd2552

I've made a review notes for this pr -> [here](https://github.com/i-am-yuvi/bitcoin-ibd/blob/master/30251.md)

💬 maflcko commented on pull request "test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage":
(https://github.com/bitcoin/bitcoin/pull/32516#issuecomment-2915446066)
re-ACK 84aa484d45e2fb3c1149941ef23779e4adb983d9 🚋

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 84aa484d45e2fb3c1149
...

💬 hebasto commented on issue "build: use UCRT runtime for Windows (release) binaries":
(https://github.com/bitcoin/bitcoin/issues/30210#issuecomment-2915451888)
@jeandudey

> I've sent a patchset a while ago when working on cross-base updating MinGW to 12.0.0: https://issues.guix.gnu.org/71630.
>
> Using `UCRT` will likely need a new target triplet for Guix though like MSYS2 does, e.g. `x86_64-w64-ucrt-mingw32`.

Trying to build `mingw-w64` with the deleted [`--with-default-msvcrt=msvcrt`](https://codeberg.org/guix/guix/src/commit/d1ec5be63e2d8521a6bad61e5c478319280623c6/gnu/packages/mingw.scm#L90) configure option results in a linker error:
```
x86_6
...