📝 maflcko opened a pull request: "test: Slim down previous releases bdb check "
(https://github.com/bitcoin/bitcoin/pull/32350)
The check iterates over several previous BDB-only releases to check that descriptor wallets are considered "corrupt" when loading. It is unclear why this needs to be done for more than one release.

Avoid the confusion by removing the unused releases from the test and from the download script.

📝 l0rinc opened a pull request: "test: avoid stack overflow in `FindChallenges` via manual iteration"
(https://github.com/bitcoin/bitcoin/pull/32351)
`FindChallenges` explores the `Miniscript` node tree by going deep into the first child's subtree, then the second, and so on - effectively performing a Post-order Traversal (Depth-First Search) recursively, using the call stack which can result in stack overflows on Windows debug builds.

This change replaces the recursive implementation with an iterative version using an explicit stack.
It is an alternative to increasing the Windows stack size, as proposed in #32349, and addresses the issue
...

💬 l0rinc commented on pull request "test: Increase stack size for "Debug" builds with MSVC":
(https://github.com/bitcoin/bitcoin/pull/32349#issuecomment-2830559713)
Opened https://github.com/bitcoin/bitcoin/pull/32351 as an alternative fix, cc: @darosior

💬 rkrux commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#issuecomment-2830562388)
I'm reviewing the PR again and will share a final review in the coming days.

📝 hebasto opened a pull request: "[29.x] qt: 29.1 translations update"
(https://github.com/bitcoin/bitcoin/pull/32352)
This PR fetches the recent translation updates from Transifex.

Closes https://github.com/bitcoin/bitcoin/issues/32295.

**Notes for reviewers:**

1. "fr_CM" and "fr_LU" have been dropped as part of [phasing out of territory-specific translations](https://app.transifex.com/bitcoin/communication/d:402657d1-6254-4ce9-8d26-e7827652c627/?q=project%3Abitcoin).

2. The translations for the following languages, which appear to be the result of a mistake or an act of vandalism, have been discard
...

💬 hebasto commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830588111)
> Closes #32295.

However, the Polish (pl) translation still have a couple of issues:

1. String 160: Mismatch between 'S&how' and '%Wyświetl'

2. String 452: Mismatch between 'Transaction broadcast successfully! Transaction ID: %1' and 'transakcja'

💬 hebasto commented on issue "gui: translation spam?":
(https://github.com/bitcoin/bitcoin/issues/32295#issuecomment-2830591421)
> I'm happy we give it another whirl after Transifex changes go in.

Translations from Transifex have been fetched in https://github.com/bitcoin/bitcoin/pull/32352.

💬 hebasto commented on pull request "test: avoid stack overflow in `FindChallenges` via manual iteration":
(https://github.com/bitcoin/bitcoin/pull/32351#issuecomment-2830600873)
cc @darosior

📝 hebasto converted_to_draft a pull request: "test: Increase stack size for "Debug" builds with MSVC"
(https://github.com/bitcoin/bitcoin/pull/32349)
This PR accommodates the deep recursion in the `FindChallenges()` function used in `test/miniscript_tests.cpp`.

Fixes https://github.com/bitcoin/bitcoin/issues/32341#issuecomment-2829441596.

CI log: https://github.com/hebasto/bitcoin/actions/runs/14664806617/job/41156972137

💬 laanwj commented on pull request "common: Close non-std fds before exec in RunCommandJSON":
(https://github.com/bitcoin/bitcoin/pull/32343#issuecomment-2830610090)
> I would try something like this to check if /proc/self/fd is available:

Thanks! Tried that, looks like it is:
```
[09:58:29.841] === BEGIN mount info ===
...
+ ls -al /proc/self/fd
[09:58:29.860] total 0
[09:58:29.860] dr-x------ 2 root root 4 Apr 25 09:58 .
[09:58:29.860] dr-xr-xr-x 9 root root 0 Apr 25 09:58 ..
[09:58:29.860] lr-x------ 1 root root 64 Apr 25 09:58 0 -> /dev/null
[09:58:29.860] l-wx------ 1 root root 64 Apr 25 09:58 1 -> pipe:[887125611]
[09:58:29.860] l-wx--
...

💬 jesterhodl commented on issue "gui: translation spam?":
(https://github.com/bitcoin/bitcoin/issues/32295#issuecomment-2830632592)
Nice, I'll rerun @maflcko's rust program. I modified it to just check polish to get this going quicker.

💬 hebasto commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830660102)
> > Closes #32295.
>
> However, the Polish (pl) translation still have a couple of issues:
>
> 1. String 160: Mismatch between 'S&how' and '%Wyświetl'
>
> 2. String 452: Mismatch between 'Transaction broadcast successfully! Transaction ID: %1' and 'transakcja'

Friendly ping @jesterhodl :)

💬 mzumsande commented on pull request "p2p: Advance pindexLastCommonBlock early after connecting blocks":
(https://github.com/bitcoin/bitcoin/pull/32180#discussion_r2060402198)
Then we would have returned earlier because there are no blocks from this peer that would help us with our IBD:
https://github.com/bitcoin/bitcoin/blob/80e6ad9e3023a57a4ef19b7d0edf9ac5be71a584/src/net_processing.cpp#L1384-L1387 (second condition)

💬 jesterhodl commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830669886)
> Transaction broadcast successfully

Both fixed in Transifex.

👍 ismaelsadeeq approved a pull request: "test: Add missing check for empty stderr in util tester"
(https://github.com/bitcoin/bitcoin/pull/32327#pullrequestreview-2794431069)


Tested ACK fadf12a56c294696052c4cb6ee5284030ada7498

I verified that with this patch, we now raise an exception whenever a `./bitcoin-util` call returns an error message and the corresponding test case does not specify that call have a corresponding `error_txt`.

For example, by removing the `error_txt` from the `grind` util test:

```diff
diff --git a/test/util/data/bitcoin-util-test.json b/test/util/data/bitcoin-util-test.json
index 83b3c430d53..d840c8fa1fb 100644
--- a/test/uti
...

💬 hebasto commented on pull request "test: avoid stack overflow in `FindChallenges` via manual iteration":
(https://github.com/bitcoin/bitcoin/pull/32351#issuecomment-2830714647)
[Here](https://github.com/hebasto/bitcoin-core-nightly/actions/runs/14667837569/job/41166981753) is a "Windows, Debug" CI job for this branch in https://github.com/hebasto/bitcoin-core-nightly.

💬 hebasto commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830725738)
> > Transaction broadcast successfully
>
> Both fixed in Transifex.

Thanks! Updated and undrafted.

👋 hebasto's pull request is ready for review: "[29.x] qt: 29.1 translations update"
(https://github.com/bitcoin/bitcoin/pull/32352)

💬 fanquake commented on pull request "build: Fix `macdeployqtplus` after switching to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/32287#discussion_r2060467577)
In f7bd54d5f34361c0c06dc86fbd8e2497e7e4473c: Why are we adding support for 6, while retaining support for 5, if we now require 6?

💬 ismaelsadeeq commented on pull request "Fees: add Fee rate Forecaster Manager":
(https://github.com/bitcoin/bitcoin/pull/31664#discussion_r2060485327)
Even better, I modified `CachedMempoolForecast` to store the last known tip.
Now, the mempool forecaster will only return the cached fee rate if the last known tip matches the current tip.

This also prevents a case where a cache exists but a new block has just been mined and the mempool has been cleared—in such cases, a new block template should be generated instead of using the cache.

Thanks for your review @polespinasa