💬 Chand-ra commented on issue "Bug: Non-Ranged Descriptors with Range [0,0] Trigger Unexpected Wallet Errors in `AddWalletDescriptor`":
(https://github.com/bitcoin/bitcoin/issues/31728#issuecomment-2830788940)
> Opened PR [#32344](https://github.com/bitcoin/bitcoin/pull/32344) to close this. It's been a while since [@Chand-ra](https://github.com/Chand-ra) indicated interest
Yeah, feel free to tackle it, I just couldn't get around to doing it.
(https://github.com/bitcoin/bitcoin/issues/31728#issuecomment-2830788940)
> Opened PR [#32344](https://github.com/bitcoin/bitcoin/pull/32344) to close this. It's been a while since [@Chand-ra](https://github.com/Chand-ra) indicated interest
Yeah, feel free to tackle it, I just couldn't get around to doing it.
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060500193)
The `importprivkey` overload was kept because several tests still use it.
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060500193)
The `importprivkey` overload was kept because several tests still use it.
💬 ismaelsadeeq commented on issue "estimateSmartFee error: "Insufficient data or no feerate found":
(https://github.com/bitcoin/bitcoin/issues/32178#issuecomment-2830820374)
I've seen this type of issue a few times now #32178, #31116, #31032, and recently, a PR to add a startup option for enabling conservative mode by default: #32329, with the aim to address problems like this.
The potential causes are:
1. Low activity on the network.
2. The node is running in `-blocksonly` mode.
As @pinheadmz mentioned, you can solve this by setting a `-fallbackfee`, just make sure it’s above both the node’s minimum relay transaction fee rate and the minimum mempool fee rate both
...
(https://github.com/bitcoin/bitcoin/issues/32178#issuecomment-2830820374)
I've seen this type of issue a few times now #32178, #31116, #31032, and recently, a PR to add a startup option for enabling conservative mode by default: #32329, with the aim to address problems like this.
The potential causes are:
1. Low activity on the network.
2. The node is running in `-blocksonly` mode.
As @pinheadmz mentioned, you can solve this by setting a `-fallbackfee`, just make sure it’s above both the node’s minimum relay transaction fee rate and the minimum mempool fee rate both
...
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518038)
Added a commit to #28710 changing the comment, and removing `REQUIRE_WALLET_TYPE_SET`.
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518038)
Added a commit to #28710 changing the comment, and removing `REQUIRE_WALLET_TYPE_SET`.
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518265)
Added a commit to #28710 to remove
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518265)
Added a commit to #28710 to remove
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518464)
Added a commit to #28710 to restore
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518464)
Added a commit to #28710 to restore
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518571)
Added a commit to #28710 to remove
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060518571)
Added a commit to #28710 to remove
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060519263)
I'll let the next person to touch it to change this.
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060519263)
I'll let the next person to touch it to change this.
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060519499)
They are removed in #28710
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060519499)
They are removed in #28710
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060520098)
Added a commit to #28710 to remove
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060520098)
Added a commit to #28710 to remove
💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060520569)
added a commit to #28710 to remove
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060520569)
added a commit to #28710 to remove
💬 achow101 commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2830837640)
Rebased and added a couple commits for followups from #31250
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2830837640)
Rebased and added a couple commits for followups from #31250
👋 achow101's pull request is ready for review: "Remove the legacy wallet and BDB dependency"
(https://github.com/bitcoin/bitcoin/pull/28710)
(https://github.com/bitcoin/bitcoin/pull/28710)
💬 fanquake commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#discussion_r2060528559)
`clang_cxx_11.patch` also needs deleting.
(https://github.com/bitcoin/bitcoin/pull/28710#discussion_r2060528559)
`clang_cxx_11.patch` also needs deleting.
💬 fanquake commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2830856375)
There's also a `libdb++-dev` instance in `workflows/ci.yml` & `deadlock:libdb` in tsan suppressions.
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2830856375)
There's also a `libdb++-dev` instance in `workflows/ci.yml` & `deadlock:libdb` in tsan suppressions.
📝 monlovesmango opened a pull request: "doc: Fix fuzz test_runner.py path"
(https://github.com/bitcoin/bitcoin/pull/32353)
This commit fixes the path listed in the documentation for the fuzz testing test_runner.py. Previously the --help option worked but running fuzz tests from the documented path did not.
(https://github.com/bitcoin/bitcoin/pull/32353)
This commit fixes the path listed in the documentation for the fuzz testing test_runner.py. Previously the --help option worked but running fuzz tests from the documented path did not.
💬 darosior commented on pull request "miner: timelock the coinbase to the mined block's height":
(https://github.com/bitcoin/bitcoin/pull/32155#issuecomment-2830913121)
> I think you lost the comment announced here: [#32155 (comment)](https://github.com/bitcoin/bitcoin/pull/32155#discussion_r2056629920)
>
> Other than it looks good.
I did not: https://github.com/bitcoin/bitcoin/pull/32155/commits/67267b147f8c48e0775602395fba9db0105dccf4#diff-6b810fb346def9cc80a9d9ab75184dd9f41c4ac63493135a7bdfcb98f75b1ce8R39
> Failure in `interface_usdt_coinselection` seems to be an instance of #32322.
Yes. Rebased on master to avoid the unrelated CI failure after i
...
(https://github.com/bitcoin/bitcoin/pull/32155#issuecomment-2830913121)
> I think you lost the comment announced here: [#32155 (comment)](https://github.com/bitcoin/bitcoin/pull/32155#discussion_r2056629920)
>
> Other than it looks good.
I did not: https://github.com/bitcoin/bitcoin/pull/32155/commits/67267b147f8c48e0775602395fba9db0105dccf4#diff-6b810fb346def9cc80a9d9ab75184dd9f41c4ac63493135a7bdfcb98f75b1ce8R39
> Failure in `interface_usdt_coinselection` seems to be an instance of #32322.
Yes. Rebased on master to avoid the unrelated CI failure after i
...
💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#issuecomment-2830957054)
For now I've reverted the assert that checks the deserialized key size, since I couldn't reproduce the fuzz failure locally (or when I could, even master failed for the same command).
Will continue trying, but without the assert it's closer to the previous state, so it should be fine as it is as well.
(https://github.com/bitcoin/bitcoin/pull/31144#issuecomment-2830957054)
For now I've reverted the assert that checks the deserialized key size, since I couldn't reproduce the fuzz failure locally (or when I could, even master failed for the same command).
Will continue trying, but without the assert it's closer to the previous state, so it should be fine as it is as well.
💬 jesterhodl commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830993573)
So I rerun the script and found some more issues and updated Transifex.
v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830993573)
So I rerun the script and found some more issues and updated Transifex.
v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.
💬 kevkevinpal commented on pull request "doc: Fix fuzz test_runner.py path":
(https://github.com/bitcoin/bitcoin/pull/32353#issuecomment-2830999023)
ACK [61f238e](https://github.com/bitcoin/bitcoin/pull/32353/commits/61f238e84ac6d24d8f420c2eabcbb2980d7fcb1e)
---
This is the error I get if I try running `test_runner.py` from the non build dir
```
./test/fuzz/test_runner.py ../qa-assets/fuzz_corpora
Traceback (most recent call last):
File "/mnt/shared_drive/DEVDIR/bitcoin/./test/fuzz/test_runner.py", line 407, in <module>
main()
File "/mnt/shared_drive/DEVDIR/bitcoin/./test/fuzz/test_runner.py", line 102, in main
confi
...
(https://github.com/bitcoin/bitcoin/pull/32353#issuecomment-2830999023)
ACK [61f238e](https://github.com/bitcoin/bitcoin/pull/32353/commits/61f238e84ac6d24d8f420c2eabcbb2980d7fcb1e)
---
This is the error I get if I try running `test_runner.py` from the non build dir
```
./test/fuzz/test_runner.py ../qa-assets/fuzz_corpora
Traceback (most recent call last):
File "/mnt/shared_drive/DEVDIR/bitcoin/./test/fuzz/test_runner.py", line 407, in <module>
main()
File "/mnt/shared_drive/DEVDIR/bitcoin/./test/fuzz/test_runner.py", line 102, in main
confi
...