👍 hebasto approved a pull request: "refactor: Replace global find_value function with UniValue::find_value method"
(https://github.com/bitcoin/bitcoin/pull/27605#pullrequestreview-1420414448)
re-ACK fa266c4bbf564308ddbc12653527226506902084

:lock: fanquake locked an issue: "wiadomośc"
(https://github.com/bitcoin-core/gui/issues/718)

:lock: fanquake locked an issue: "View JPEG-encoded data"
(https://github.com/bitcoin-core/gui/issues/707)

🚀 fanquake merged a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611)

💬 hebasto commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1542019486)
Maybe notice the GCC-13 bug in the comments for `#define WITH_LOCK`?

🤔 hebasto reviewed a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420434054)
Post-merge ACK e23088707be2c3bf247f4b777290c8e401db48cb.

💬 hebasto commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189776962)
Our [Developer Notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#c-data-structures) also suggest a comment `// no default case, so the compiler can warn about missing cases`.

💬 fanquake commented on pull request "ci: Run iwyu on all src files":
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542050798)
> (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)

Looks like it's mostly working, except GUI stuff is still being dragged in

💬 MarcoFalke commented on pull request "refactor: Replace global find_value function with UniValue::find_value method":
(https://github.com/bitcoin/bitcoin/pull/27605#issuecomment-1542071939)
> Maybe notice the GCC-13 bug in the comments for #define WITH_LOCK?

I think https://github.com/bitcoin/bitcoin/pull/27605#discussion_r1189731837 applies and we should disable the warning instead if there are more false positives?

💬 Sjors commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542082141)
Concept ACK. I can't verify the PGP key.

📝 MarcoFalke opened a pull request: " ci: Remove CI_EXEC bloat "
(https://github.com/bitcoin/bitcoin/pull/27616)
`CI_EXEC` has many issues:

* It is roughly equivalent to `bash -c "$*"`, meaning that the full command will be treated as a single string, ignoring tokens.
* It must be put in front of (almost) every command, making it easy to forget, hard to debug the resulting failure, and the code verbose.

Fix all issues by removing it almost completely.

💬 RandyMcMillan commented on pull request "ci: Remove CI_EXEC bloat":
(https://github.com/bitcoin/bitcoin/pull/27616#issuecomment-1542118050)
concept ACK

💬 hebasto commented on pull request "ci: Run iwyu on all src files":
(https://github.com/bitcoin/bitcoin/pull/27571#issuecomment-1542127948)
> > (qt/qrc_bitcoin_locale.cpp has correct #includes/fwd-decls)
>
> Looks like it's mostly working, except GUI stuff is still being dragged in

And `qt/qrc_bitcoin.cpp` as well.

🤔 theStack reviewed a pull request: "test: added coverage to mining_basic.py"
(https://github.com/bitcoin/bitcoin/pull/27603#pullrequestreview-1420535642)
Concept ACK

💬 theStack commented on pull request "test: added coverage to mining_basic.py":
(https://github.com/bitcoin/bitcoin/pull/27603#discussion_r1189840647)
nit: could just directly serialize a newly created temporary CBlock() instance, instead of creating a new variable
```suggestion
self.log.info("submitblock: Test block decode failure with empty vtx")
assert_raises_rpc_error(-22, "Block does not start with a coinbase", node.submitblock, CBlock().serialize().hex())
```
Would also suggest to move this down to the test checking the other condition for the same error message ("submitblock: Test invalid coinbase transaction").

💬 0xB10C commented on pull request "add ryanofsky to trusted-keys":
(https://github.com/bitcoin/bitcoin/pull/27604#issuecomment-1542136632)
post-merge ACK

💬 josibake commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1542154805)
> > Using this command to identify those peers: `bitcoin-cli getpeerinfo | jq -r '.[] | if (.bytessent_per_msg.inv > 100000 and .bytesrecv_per_msg.inv == null) then .addr else empty end'`
>
> Someone posted https://news.ycombinator.com/item?id=35824998 linking to a DoS script https://github.com/visualbasic6/drain/blob/c8373b55d83832f95fb0a77aca56436adeffb58d/drain-btc.py a day before this issue. It's possible someone may be using the script targeting public nodes.
>
> Check your `bytessent
...

💬 kevkevinpal commented on pull request "test: added coverage to mining_basic.py":
(https://github.com/bitcoin/bitcoin/pull/27603#discussion_r1189865879)
FIxed in [a7b46a1](https://github.com/bitcoin/bitcoin/pull/27603/commits/a7b46a1feae60e38fe4bdcacf5034f44cae49222)

Thanks for the suggestion!

⚠️ Jackwumingjie opened an issue: "Method not found"
(https://github.com/bitcoin/bitcoin/issues/27617)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

<img width="1018" alt="企业微信截图_958a8dcb-6942-407e-a01b-14eee3df3e14" src="https://github.com/bitcoin/bitcoin/assets/39093109/8059bcd8-967f-41b9-9eb6-3a9425f97b2e">
I build the node with ubuntu20.04 and 24.0.1. But some api return the error as the picture. The run command "bitcoind -datadir=/data2/.btc/data -rpcuser="xxxx" -rpcpass
...

💬 fanquake commented on issue "Method not found":
(https://github.com/bitcoin/bitcoin/issues/27617#issuecomment-1542160043)
Did you compile with wallet support?