💬 maflcko commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656602446)
I can't reproduce with `walletpassphrasechange '(space “thekey” \ \ \ \ \ \ \ \ \ \ \ \ )
“ \ \ \ \ \ \ \ \ \ \ \ \ )”' 'new_'` (it passes fine for me locally) on a freshly created wallet.

Please provide full (and exact) steps to reproduce on a freshly created wallet.

💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656607996)
Ok i will, then i will provide screen recorded video
On Thu, 13 Feb 2025 at 16:28 maflcko ***@***.***> wrote:

> I can't reproduce with walletpassphrasechange '(space “thekey” \ \ \ \ \
> \ \ \ \ \ \ \ ) “ \ \ \ \ \ \ \ \ \ \ \ \ )”' 'new_' (it passes fine for
> me locally) on a freshly created wallet.
>
> Please provide full (and exact) steps to reproduce on a freshly created
> wallet.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issu
...

👍 hebasto approved a pull request: "depends: avoid an unset `CMAKE_OBJDUMP`"
(https://github.com/bitcoin/bitcoin/pull/31857#pullrequestreview-2615016680)
ACK 2434aeab62ba07c5380112838f3600b3dbbceef2.

💬 maflcko commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656625024)
Thx, but it should be sufficient to just copy-paste the commands (and results) into a comment here directly. You can use <code>`</code> for quoting.

💬 ryanofsky commented on pull request "logging: Ensure -debug=0/none behaves consistently with -nodebug":
(https://github.com/bitcoin/bitcoin/pull/31767#discussion_r1954520666)
> Thx for confirming. It would be nice to remove it here, so that it doesn't have to be touched (and reviewed) again in another pull request.

Yep, #30529 does have 2 acks though so getting close

🚀 ryanofsky merged a pull request: "logging: Ensure -debug=0/none behaves consistently with -nodebug"
(https://github.com/bitcoin/bitcoin/pull/31767)

💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954529064)
I don't think we should drop the default, because `MillisecondsDouble::max()` is tedious. It seems fine that the interface does it internally, which is simpler than the other two solutions.

💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656648103)
Ok, I will do that.
command: walletpassphrase ' \ \ \ \ \ \ \ \ \ \ \ \' 800
result:
result is absolutely nothing

On Thu, 13 Feb 2025 at 16:37, maflcko ***@***.***> wrote:

> Thx, but it should be sufficient to just copy-paste the commands (and
> results) into a comment here directly. You can use ` for quoting.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656625024>,
> or unsubscribe
> <https://github.com/
...

💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656653170)
16:36:06

walletpassphrase '\ \ \ \ \ \ \ \ \ \ \ \' 800


16:36:06



On Thu, 13 Feb 2025 at 16:45, Amer Emad ***@***.***> wrote:

> Ok, I will do that.
> command: walletpassphrase ' \ \ \ \ \ \ \ \ \ \ \ \' 800
> result:
> result is absolutely nothing
>
> On Thu, 13 Feb 2025 at 16:37, maflcko ***@***.***> wrote:
>
>> Thx, but it should be sufficient to just copy-paste the commands (and
>> results) into a comment here directly. You can use ` for quoting.
>>
>> —
>> Repl
...

💬 sipa commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656659118)
@innde We don't know how you created the wallet, and set its password in the first place, making it impossible to reproduce.

Can you give the full and exact reproduction steps, from scratch, from starting `bitcoin-qt`, to creating the wallet, to trying to unlock it, and observing it is not working.

💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954537951)
I could also do this:

```diff
diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp
index 66ce64b1c3..b0735d497c 100644
--- a/src/node/interfaces.cpp
+++ b/src/node/interfaces.cpp
@@ -971,7 +971,7 @@ public:
return BlockRef{tip->GetBlockHash(), tip->nHeight};
}

- std::optional<BlockRef> waitTipChanged(uint256 current_tip, MillisecondsDouble timeout) override
+ std::optional<BlockRef> waitTipChanged(uint256 current_tip, MillisecondsDouble timeout = Mill
...

💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656675260)
Yes, I can help you with that.
Through Bitcoin Core interface: *File → Create Wallet → Set Name →
Encrypt Wallet* – \ \ \ \ \ \ \ \ \ \ \ \ That's all.

On Thu, 13 Feb 2025 at 16:50, Pieter Wuille ***@***.***>
wrote:

> @InnDe <https://github.com/InnDe> We don't know how you created the
> wallet, and set its password in the first place, making it impossible to
> reproduce.
>
> Can you give the full and exact reproduction steps, from scratch, from
> starting bitcoin-qt, to creating
...

📝 tianzedavid opened a pull request: "chore: remove redundant word"
(https://github.com/bitcoin/bitcoin/pull/31858)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 tianzedavid commented on pull request "chore: remove redundant word":
(https://github.com/bitcoin/bitcoin/pull/31855#issuecomment-2656717008)
> similar instance on line 94 now that i see it
>
> https://github.com/bitcoin/bitcoin/pull/31855/files#diff-91d294c18d2f63ceb1c9aadff3b3ae046b252b763d69b13f930f7de7b399f440R94

Thanks for pointing out. The new pr https://github.com/bitcoin/bitcoin/pull/31858

💬 ryanofsky commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954473077)
In commit "rpc: introduce RPC_SHUTDOWN_ERROR" (e6760e7f0f04c076c3eb8fa61cb54adf12fed36b)

Out of curiosity, where did 37 come from?

💬 ryanofsky commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364)
In commit "rpc: handle shutdown during long poll and wait methods" (fa99eddd926e0d49604d9ca8f21fac85d63652f4)

I think this new behavior of only using `timeout` as time limit for tip changing, not as a time limit for the tip to be set on startup makes a lot of sense and should be much more convenient for callers than previous behavior.

(Previous version in ad3af401c19b8d05ce69011a359db3090b7018e1 would return ambiguous null values on startup that could mean either the node was shutting down
...

💬 josibake commented on pull request "Benchmark Chainstate::ConnectBlock duration":
(https://github.com/bitcoin/bitcoin/pull/31689#issuecomment-2656722488)
reACK https://github.com/bitcoin/bitcoin/commit/7edaf8b64cb2d59ada22042fee62a417e52368b8

💬 maflcko commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656739550)
I can't reproduce. Though, I am on Linux.

Does it also happen when you copy-paste the exact same password into both places? Does it happen when you use the on-screen software keyboard instead of the hardware one?

💬 willcl-ark commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656741857)
If we are going to be able to reproduce it, the instructions will need to be reproducible by someone. I can't reproduce yours currently. My recommendation would be to, whilst using a computer, write out the instructions in a codeblock as @maflcko suggested. They should look something like this at the end:

\`\`\`bash
```bash
# Start bitcoind
bitcoind

# Create new wallet
bitcoin-cli createwallet test-wallet false false " \ \ \ \ \ \ \ \"

# reload wallet
bitcoin-cli unload wallet "test-wallet"
b
...

💬 sipa commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360)
Is it possible that you have more than one wallet loaded? If so, you should see a drop-down list at the top left in the debug console window.