💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656748026)
I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
type the passphrase or paste it—the result is always the same.
On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
> I can't reproduce. Though, I am on Linux.
>
> Does it also happen when you copy-paste the exact same password into both
> places? Does it happen when you use the on-screen software keyboard instead
> of the hardware one?
>
> —
> Reply to this email directly, view it on GitHub
> <https://
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656748026)
I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
type the passphrase or paste it—the result is always the same.
On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
> I can't reproduce. Though, I am on Linux.
>
> Does it also happen when you copy-paste the exact same password into both
> places? Does it happen when you use the on-screen software keyboard instead
> of the hardware one?
>
> —
> Reply to this email directly, view it on GitHub
> <https://
...
💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656752290)
sorry but I really don't understand what you want me to do
On Thu, 13 Feb 2025 at 17:21, Amer Emad ***@***.***> wrote:
> I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
> type the passphrase or paste it—the result is always the same.
>
> On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
>
>> I can't reproduce. Though, I am on Linux.
>>
>> Does it also happen when you copy-paste the exact same password into both
>> places? Does it happen when you us
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656752290)
sorry but I really don't understand what you want me to do
On Thu, 13 Feb 2025 at 17:21, Amer Emad ***@***.***> wrote:
> I'm using my Acer Predator laptop keyboard. It doesn’t matter whether I
> type the passphrase or paste it—the result is always the same.
>
> On Thu, 13 Feb 2025 at 17:19, maflcko ***@***.***> wrote:
>
>> I can't reproduce. Though, I am on Linux.
>>
>> Does it also happen when you copy-paste the exact same password into both
>> places? Does it happen when you us
...
💬 maflcko commented on pull request "chore: remove redundant word":
(https://github.com/bitcoin/bitcoin/pull/31858#issuecomment-2656752950)
lgtm ACK 4c62b37fcd23e94ea482efc5974acc2560f57f5f
(https://github.com/bitcoin/bitcoin/pull/31858#issuecomment-2656752950)
lgtm ACK 4c62b37fcd23e94ea482efc5974acc2560f57f5f
💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656757505)
Yes, sir, I have more than one, but I choose in the CLI from the top
right corner which one to execute commands in.
On Thu, 13 Feb 2025 at 17:21, Pieter Wuille ***@***.***>
wrote:
> Is it possible that you have more than one wallet loaded? If so, you
> should see a drop-down list at the top left in the debug console window.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360>,
> or unsubscribe
> <http
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656757505)
Yes, sir, I have more than one, but I choose in the CLI from the top
right corner which one to execute commands in.
On Thu, 13 Feb 2025 at 17:21, Pieter Wuille ***@***.***>
wrote:
> Is it possible that you have more than one wallet loaded? If so, you
> should see a drop-down list at the top left in the debug console window.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656746360>,
> or unsubscribe
> <http
...
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954607452)
My takeaway from the article is that having a default for the base class is fine, and that it's better to not use a default for the inherited classes (but it could get ignored).
The patch in my previous comment would be bad. But the current code that calls `waitTipChanged(uint256::ZERO, MillisecondsDouble::max())` should be fine.
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954607452)
My takeaway from the article is that having a default for the base class is fine, and that it's better to not use a default for the inherited classes (but it could get ignored).
The patch in my previous comment would be bad. But the current code that calls `waitTipChanged(uint256::ZERO, MillisecondsDouble::max())` should be fine.
💬 sipa commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656770266)
Ok, well, if the password you set when creating the wallet in the GUI is `\ \ \ \ \ \ \ \ \ \ \ \`, then the command in the debug console should be `walletpassphrase '\ \ \ \ \ \ \ \ \ \ \ \' 800`, or `walletpassphrase "\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\" 800`, because of backslash quoting.
But I cannot explain why you're not seeing any output at all. The response to the `walletpassphrase` command, you should get either `(null)` as output when the password is correct, or `Error: The wallet pas
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656770266)
Ok, well, if the password you set when creating the wallet in the GUI is `\ \ \ \ \ \ \ \ \ \ \ \`, then the command in the debug console should be `walletpassphrase '\ \ \ \ \ \ \ \ \ \ \ \' 800`, or `walletpassphrase "\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\" 800`, because of backslash quoting.
But I cannot explain why you're not seeing any output at all. The response to the `walletpassphrase` command, you should get either `(null)` as output when the password is correct, or `Error: The wallet pas
...
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954608225)
First available number.
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954608225)
First available number.
🤔 delta1 reviewed a pull request: "chore: remove redundant word"
(https://github.com/bitcoin/bitcoin/pull/31858#pullrequestreview-2615179552)
ACK https://github.com/bitcoin/bitcoin/commit/4c62b37fcd23e94ea482efc5974acc2560f57f5f
(https://github.com/bitcoin/bitcoin/pull/31858#pullrequestreview-2615179552)
ACK https://github.com/bitcoin/bitcoin/commit/4c62b37fcd23e94ea482efc5974acc2560f57f5f
🚀 fanquake merged a pull request: "chore: remove redundant word"
(https://github.com/bitcoin/bitcoin/pull/31858)
(https://github.com/bitcoin/bitcoin/pull/31858)
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954615547)
See https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954615547)
See https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954576364
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954626155)
Thanks, that indeed looks simpler.
I also think clients should handle timeouts themselves. For `bitcoin-cli` we have `-rpcclienttimeout=0`, other RPC clients presumably have their own timeout mechanisms, and IPC clients can do the same.
(https://github.com/bitcoin/bitcoin/pull/31785#discussion_r1954626155)
Thanks, that indeed looks simpler.
I also think clients should handle timeouts themselves. For `bitcoin-cli` we have `-rpcclienttimeout=0`, other RPC clients presumably have their own timeout mechanisms, and IPC clients can do the same.
👍 hodlinator approved a pull request: "net: reduce CAddress usage to CService or CNetAddr"
(https://github.com/bitcoin/bitcoin/pull/31854#pullrequestreview-2615228759)
ACK cd4bfaee103591f212b88afd17969c16c1056eb6
### Concept
Defers "faking" of `CAddress` by initializing `CAddress::nServices = NODE_NONE` when all we actually have is a `CService` (network address+port), to all the way down to the construction of `CNode`:
https://github.com/bitcoin/bitcoin/blob/cd4bfaee103591f212b88afd17969c16c1056eb6/src/net.cpp#L1831-L1833
### Type safety sanity check
```mermaid
graph LR;
CService-->CNetAddr;
CAddress-->CService;
```
`CAddress`,
...
(https://github.com/bitcoin/bitcoin/pull/31854#pullrequestreview-2615228759)
ACK cd4bfaee103591f212b88afd17969c16c1056eb6
### Concept
Defers "faking" of `CAddress` by initializing `CAddress::nServices = NODE_NONE` when all we actually have is a `CService` (network address+port), to all the way down to the construction of `CNode`:
https://github.com/bitcoin/bitcoin/blob/cd4bfaee103591f212b88afd17969c16c1056eb6/src/net.cpp#L1831-L1833
### Type safety sanity check
```mermaid
graph LR;
CService-->CNetAddr;
CAddress-->CService;
```
`CAddress`,
...
💬 Sjors commented on pull request "Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods":
(https://github.com/bitcoin/bitcoin/pull/31785#issuecomment-2656828338)
I mixed up the commits in my last push, will fix...
(https://github.com/bitcoin/bitcoin/pull/31785#issuecomment-2656828338)
I mixed up the commits in my last push, will fix...
💬 hebasto commented on pull request "cmake: Do not modify `CMAKE_TRY_COMPILE_TARGET_TYPE` globally":
(https://github.com/bitcoin/bitcoin/pull/31662#discussion_r1954644132)
> Blah, ok, sorry. I've been messing around with this. Final answer:
>
> * Let's add a `SANITIZER_LIBS` var
>
> * add BOTH `LINK_LIBRARIES` and `LDFLAGS` to check_cxx_source_compiles_with_flags
>
> * pass them both for the sanitizers
>
> * update oss-fuzz to use `SANITIZER_LIBS` instead.
>
>
> That way our stuff is well-defined and makes sense and we're not coding around oss-fuzz, but we still expose the option we need there.
Reworked. A new `FUZZ_LIBS` variab
...
(https://github.com/bitcoin/bitcoin/pull/31662#discussion_r1954644132)
> Blah, ok, sorry. I've been messing around with this. Final answer:
>
> * Let's add a `SANITIZER_LIBS` var
>
> * add BOTH `LINK_LIBRARIES` and `LDFLAGS` to check_cxx_source_compiles_with_flags
>
> * pass them both for the sanitizers
>
> * update oss-fuzz to use `SANITIZER_LIBS` instead.
>
>
> That way our stuff is well-defined and makes sense and we're not coding around oss-fuzz, but we still expose the option we need there.
Reworked. A new `FUZZ_LIBS` variab
...
💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656840009)
Ok, thanks for the clarification.
hope someone figure this out
On Thu, 13 Feb 2025 at 17:30, Pieter Wuille ***@***.***>
wrote:
> Ok, well, if the password you set when creating the wallet in the GUI is \
> \ \ \ \ \ \ \ \ \ \ \, then the command in the debug console should be walletpassphrase
> '\ \ \ \ \ \ \ \ \ \ \ \' 800, or walletpassphrase "\\ \\ \\ \\ \\ \\ \\
> \\ \\ \\ \\ \\" 800, because of backslash quoting.
>
> But I cannot explain why you're not seeing any output at all.
...
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2656840009)
Ok, thanks for the clarification.
hope someone figure this out
On Thu, 13 Feb 2025 at 17:30, Pieter Wuille ***@***.***>
wrote:
> Ok, well, if the password you set when creating the wallet in the GUI is \
> \ \ \ \ \ \ \ \ \ \ \, then the command in the debug console should be walletpassphrase
> '\ \ \ \ \ \ \ \ \ \ \ \' 800, or walletpassphrase "\\ \\ \\ \\ \\ \\ \\
> \\ \\ \\ \\ \\" 800, because of backslash quoting.
>
> But I cannot explain why you're not seeing any output at all.
...
💬 laanwj commented on pull request "test, tracing: don't use problematic `bpf_usdt_readarg_p()`":
(https://github.com/bitcoin/bitcoin/pull/31848#issuecomment-2656847216)
> bpf_usdt_readarg_p() is a helper that does this, but apparently not safely enough
i looked into it a bit; the implementation of `bpf_usdt_readarg_p` is here:
https://github.com/iovisor/bcc/blob/master/src/cc/frontends/clang/b_frontend_action.cc#L1270
It's a macro implemented in the clang frontend:
```c++
} else if (Decl->getName() == "bpf_usdt_readarg_p") {
text = "({ u64 __addr = 0x0; ";
text += "_bpf_readarg_" + current_fn_ + "_" + args[0] + "(" +
...
(https://github.com/bitcoin/bitcoin/pull/31848#issuecomment-2656847216)
> bpf_usdt_readarg_p() is a helper that does this, but apparently not safely enough
i looked into it a bit; the implementation of `bpf_usdt_readarg_p` is here:
https://github.com/iovisor/bcc/blob/master/src/cc/frontends/clang/b_frontend_action.cc#L1270
It's a macro implemented in the clang frontend:
```c++
} else if (Decl->getName() == "bpf_usdt_readarg_p") {
text = "({ u64 __addr = 0x0; ";
text += "_bpf_readarg_" + current_fn_ + "_" + args[0] + "(" +
...
💬 jsarenik commented on issue "Memory-only wallet (for faucets)":
(https://github.com/bitcoin/bitcoin/issues/31816#issuecomment-2656848957)
@maflcko thanks for the idea with ``removeprunedfunds but I just tried it and it did not after removing almost all of the already-mined transactions (the list I got from listtransactions RPC with some postprocessing).
(https://github.com/bitcoin/bitcoin/issues/31816#issuecomment-2656848957)
@maflcko thanks for the idea with ``removeprunedfunds but I just tried it and it did not after removing almost all of the already-mined transactions (the list I got from listtransactions RPC with some postprocessing).
💬 jsarenik commented on issue "Memory-only wallet (for faucets)":
(https://github.com/bitcoin/bitcoin/issues/31816#issuecomment-2656857139)
@maflcko thanks for the idea with ``removeprunedfunds but I just tried it and it did not after removing almost all of the already-mined transactions (the list I got from listtransactions RPC with some postprocessing).
I think the database file would need to be vacuumed.
(https://github.com/bitcoin/bitcoin/issues/31816#issuecomment-2656857139)
@maflcko thanks for the idea with ``removeprunedfunds but I just tried it and it did not after removing almost all of the already-mined transactions (the list I got from listtransactions RPC with some postprocessing).
I think the database file would need to be vacuumed.
💬 laanwj commented on pull request "test, tracing: don't use problematic `bpf_usdt_readarg_p()`":
(https://github.com/bitcoin/bitcoin/pull/31848#discussion_r1954661905)
Using `bpf_probe_read_user_str` here at least makes sure that only until the zero-terminator is read and not the entire buffer.
(https://github.com/bitcoin/bitcoin/pull/31848#discussion_r1954661905)
Using `bpf_probe_read_user_str` here at least makes sure that only until the zero-terminator is read and not the entire buffer.
✅ jsarenik closed an issue: "Memory-only wallet (for faucets)"
(https://github.com/bitcoin/bitcoin/issues/31816)
(https://github.com/bitcoin/bitcoin/issues/31816)