💬 fjahr commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921616285)
nit: similar to below

``` suggestion
assert_greater_than(n3.pruneblockchain(START_HEIGHT), 0)
```

💬 fjahr commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921615824)
nit: I would call it `complete_background_validation` or something similar. `wait_for_*` implies that the sync was started before somewhere else, but the sync is part of the function.

💬 luke-jr commented on pull request "RPC: Fix invalid txid in `gettransaction` example":
(https://github.com/bitcoin/bitcoin/pull/31610#issuecomment-2600994475)
> @luke-jr, what's wrong with the current approach?

It won't work without txindex enabled

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921645830)
Done

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921645869)
Done

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921645907)
Fixed

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921646155)
Done. Actually I changed it to `assert_equal(n3.pruneblockchain(FINAL_HEIGHT), 298)`. This is because the `prubeblockchain` method returns the height of the last block pruned (298 in this case) while `pruneheight` from `getblockchaininfo` returns the oldest block stored in disk (299 in our case). I added a comment to clarify this.

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921646227)
Done

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921646239)
Fixed

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921646283)
This is a good point. Done

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1921646317)
Done

💬 alfonsoromanz commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#issuecomment-2601046939)
> Did another pass, mostly minor comments, otherwise looks pretty good. Will do a final pass when my comments have been addressed.

Thanks for the detailed feedback, @fjahr!. I pushed 2f19e42ddd85598438d0b8b49ef93c312c45c21b with your requested changes.

⚠️ SatoshiNakamoto2007 opened an issue: "Create project BankBitcoinBinance"
(https://github.com/bitcoin/bitcoin/issues/31686)
https://github.com/auth0-samples/auth0-react-samples/tree/master/Sample-01

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31686)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31686)

👍 tdb3 approved a pull request: "init: Lock blocksdir in addition to datadir"
(https://github.com/bitcoin/bitcoin/pull/31674#pullrequestreview-2561212482)
Code review and light test ACK 2656a5658c14b43c32959db7235e9db55a17d4c8

Nice update. Increasing safety for blocks dir before concurrency issues arise makes sense.

Sanity checked the migration from `.lock`less blocks dir on signet. New `.lock` was created without issue.

✅ araujo88 closed a pull request: "rpc: method removeprunedfunds should take an array of txids"
(https://github.com/bitcoin/bitcoin/pull/29468)

⚠️ mohammwdofficial opened an issue: "Gift me btc buy"
(https://github.com/bitcoin/bitcoin/issues/31687)
Exchanche blubank.complz

✅ willcl-ark closed an issue: "Gift me btc buy"
(https://github.com/bitcoin/bitcoin/issues/31687)

💬 maflcko commented on issue "`generateblock` RPC Not Collecting Transaction Fees":
(https://github.com/bitcoin/bitcoin/issues/31684#issuecomment-2601620537)
> The block reward should include both the block subsidy and the transaction fees from all transactions included in the block.

Is there a use case for this? `generateblock` is a test-only RPC, so there is no need to write extra code to collect the fees. Note that the other `generate*` calls will collect the fees.