Bitcoin Core Github
42 subscribers
126K links
Download Telegram
📝 Recepxx34 opened a pull request: "Update and rename README.md to GET /api/v1/lightning/channels?public_…"
(https://github.com/bitcoin/bitcoin/pull/31688)
```javascript
…key=:pubKey&status=:channelStatus

Bitcoin Core integration/staging tree
=====================================

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

What is Bitcoin Core?
---------------------

Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which
...
willcl-ark closed a pull request: "Update and rename README.md to GET /api/v1/lightning/channels?public_…"
(https://github.com/bitcoin/bitcoin/pull/31688)
maflcko closed a pull request: "Add NODE_TXRELAY_V2."
(https://github.com/bitcoin/bitcoin/pull/30837)
💬 maflcko commented on pull request "Add NODE_TXRELAY_V2.":
(https://github.com/bitcoin/bitcoin/pull/30837#issuecomment-2601662492)
Closing for now, due to inactivity for a few months, and failing CI, since it was opened.

Please leave a comment, if you want this reopened. Alternatively, you can also open a new pull, since there hasn't been any discussion here anyway, except for discussions around the failing CI.
💬 naiyoma commented on pull request "test: Add test for rpcwhitelistdefault":
(https://github.com/bitcoin/bitcoin/pull/29858#discussion_r1921955676)
Update with all the changes -> https://github.com/bitcoin/bitcoin/pull/29858/commits/f0e5e4cdbec4df190c952d5a61d7a882a7e3b59e
💬 hebasto commented on pull request "guix: use GCC 13 to build releases":
(https://github.com/bitcoin/bitcoin/pull/29881#issuecomment-2601696269)
My Guix build:
```
riscv64
a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974 guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part
ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz
abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz
fdb01866
...
maflcko closed a pull request: "fuzz: Speed up *_package_eval fuzz targets a bit"
(https://github.com/bitcoin/bitcoin/pull/31457)
💬 maflcko commented on pull request "fuzz: Speed up *_package_eval fuzz targets a bit":
(https://github.com/bitcoin/bitcoin/pull/31457#issuecomment-2601705016)
Closing for now, because changing the order of the elements in the set may invalidate the existing fuzz inputs, making this harder to review/test.
👍 hebasto approved a pull request: "guix: use GCC 13 to build releases"
(https://github.com/bitcoin/bitcoin/pull/29881#pullrequestreview-2561635126)
re-ACK 6f0513613a987ef574897e43c41a6ada9022a9d7, only rebased since my recent [review](https://github.com/bitcoin/bitcoin/pull/29881#pullrequestreview-2500087136).
💬 maflcko commented on pull request "ci: Supply `--platform` argument to `docker` commands.":
(https://github.com/bitcoin/bitcoin/pull/31657#discussion_r1921975444)
> but it seems docker infers the arch if an OS is specified, and doesn't just fall back on a cache hit for that OS:

Thanks for checking! In case this ever changes, it should be trivial to re-add the code you wrote by re-applying the diff: https://github.com/bitcoin/bitcoin/compare/1299bd89f8661028f9e1826c51a29d4e3fe39cdc..e1c7c29727faf2d0a5c6fa01505418aac26958fe
💬 maflcko commented on pull request "ci: Supply `--platform` argument to `docker` commands.":
(https://github.com/bitcoin/bitcoin/pull/31657#issuecomment-2601759698)
lgtm ACK 6e29de21010fc5213176a6ba29f754ca72612ea0
:lock: fanquake locked an issue: "Gift me btc buy"
(https://github.com/bitcoin/bitcoin/issues/31687)
📝 fanquake locked a pull request: "Update and rename README.md to GET /api/v1/lightning/channels?public_…"
(https://github.com/bitcoin/bitcoin/pull/31688)
```javascript
…key=:pubKey&status=:channelStatus

Bitcoin Core integration/staging tree
=====================================

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

What is Bitcoin Core?
---------------------

Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which
...
🤔 hebasto reviewed a pull request: "fuzz: add cstdlib to FuzzedDataProvider"
(https://github.com/bitcoin/bitcoin/pull/31448#pullrequestreview-2561696993)
Post-merge ACK bb7e686341e437b2e7aae887827710918c00ae0f.
💬 maflcko commented on pull request "init: Lock blocksdir in addition to datadir":
(https://github.com/bitcoin/bitcoin/pull/31674#discussion_r1922011567)
Sorry, I completely mis-read the test in the last commit. All good, please resolve.
💬 maflcko commented on pull request "init: Lock blocksdir in addition to datadir":
(https://github.com/bitcoin/bitcoin/pull/31674#discussion_r1922011646)
I suggested it, because it avoids the two negations and it is shorter, so it reads more natural, at least to me. But it is just a nit.
💬 maflcko commented on pull request "init: Lock blocksdir in addition to datadir":
(https://github.com/bitcoin/bitcoin/pull/31674#issuecomment-2601784981)
No change since my last review. I just mis-read the test commit.

re-ACK 2656a5658c14b43c32959db7235e9db55a17d4c8 🐓

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A
...
🤔 hebasto reviewed a pull request: "ci: Supply `--platform` argument to `docker` commands."
(https://github.com/bitcoin/bitcoin/pull/31657#pullrequestreview-2561731819)
Tested 6e29de21010fc5213176a6ba29f754ca72612ea0 on Ubuntu 24.10:
```
$ docker --version
Docker version 27.1.1, build 6312585
$ env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'FILE_ENV="./ci/test/00_setup_env_arm.sh" ./ci/test_run_all.sh'
++++ dirname ./ci/test/00_setup_env.sh
+++ cd ./ci/test/../../
+++ pwd
++ BASE_READ_ONLY_DIR=/home/hebasto/git/bitcoin
++ export BASE_READ_ONLY_DIR
++ export BASE_ROOT_DIR=/ci_container_base
++ BASE_ROOT_DIR=/ci_container_base
++ export DEPEND
...
💬 maflcko commented on pull request "ci: Supply `--platform` argument to `docker` commands.":
(https://github.com/bitcoin/bitcoin/pull/31657#issuecomment-2601808032)
> 0.099 exec /usr/bin/bash: exec format error

This is unrelated to the changes in this pull request, as it happens on master as well.

You'll have to set up qemu. Possibly with `podman run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes`
💬 maflcko commented on issue "CI: Improve documentation around replicating CI locally":
(https://github.com/bitcoin/bitcoin/issues/31199#issuecomment-2601811725)
Also, setup of qemu is missing: https://github.com/bitcoin/bitcoin/pull/31657#issuecomment-2601808032