💬 theStack commented on pull request "rpc: allow writing UTXO set to a named pipe, introduce dump_to_sqlite.sh script":
(https://github.com/bitcoin/bitcoin/pull/31560#issuecomment-2599524193)
> Can we make the exists/is_fifo/open atomic somehow? Seems liable to have a race here someday...

> eg [luke-jr@56ee485](https://github.com/luke-jr/bitcoin/commit/56ee485533820d8c7f0e4e27acd712aa8b411286)

@luke-jr: Thanks, applied this to https://github.com/bitcoin/bitcoin/pull/31560/commits/292b0e884df3f266fc57d583cca46ca80400fa4a. Note that I had to introduce a `fs::exists` helper for file_status, as direct usage of `std::filesystem::exists` was prohibited by the linter (which failed wit
...

📝 Ali-pixcell opened a pull request: "Delete .github/workflows directory"
(https://github.com/bitcoin/bitcoin/pull/31680)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ Ali-pixcell closed a pull request: "Delete .github/workflows directory"
(https://github.com/bitcoin/bitcoin/pull/31680)

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2599599923)
Rebased 538671edce5813a62405b9bd5c50c39263c58435 -> 01a43b24436e0aed7b8f79d3857630a4bf6a0545 ([kernelApi_17](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_17) -> [kernelApi_18](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_18), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_17..kernelApi_18))

* Get functional test fix from #31675

📝 fanquake locked a pull request: "Delete .github/workflows directory"
(https://github.com/bitcoin/bitcoin/pull/31680)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

⚠️ SatoshiNakamoto2007 opened an issue: "BitcoinBinanceBank "
(https://github.com/bitcoin/bitcoin/issues/31681)

✅ fanquake closed an issue: "BitcoinBinanceBank "
(https://github.com/bitcoin/bitcoin/issues/31681)

:lock: fanquake locked an issue: "BitcoinBinanceBank "
(https://github.com/bitcoin/bitcoin/issues/31681)

💬 Eunovo commented on pull request "Ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#issuecomment-2599687406)
I had an offline conversation with @mzumsande. During the reindex, we can apply assumevalid for following cases:
- If the assumevalid block is the index, then we can skip script checks for all ancestors of the assumevalid block
- If the assumevalid block is not in the index, then the initial IBD run had not downloaded the assumevalid block yet then the blocks on disk are ancestors of the assumevalid block and we can still skip script verification

Then we download headers from peers in paral
...

📝 Eunovo converted_to_draft a pull request: "Ensure assumevalid is always used during reindex"
(https://github.com/bitcoin/bitcoin/pull/31615)
assumevalid is not always used during reindex because the chainwork of the best header might be less than the minimumchainwork if the previous IBD was interrupted before it could connect blocks up to minimumchainwork.
See Issue https://github.com/bitcoin/bitcoin/issues/31494

This does not occur during normal IBD because the node does not connect blocks before minchainwork headers.

💬 glozow commented on pull request "multi-peer orphan resolution followups":
(https://github.com/bitcoin/bitcoin/pull/31666#issuecomment-2599722690)
Rebased for #31675 which fixes https://cirrus-ci.com/task/5200590696873984

🤔 TheCharlatan reviewed a pull request: "init: Lock blocksdir in addition to datadir"
(https://github.com/bitcoin/bitcoin/pull/31674#pullrequestreview-2560427054)
> It's not likely to happen currently, but may be more relevant in the future with applications using the kernel. Note that the kernel does not currently do any dir locking, but it should.

I think if we want directory locking in the kernel library, we should do that here before we introduce and ossify new assumptions on when exactly the lock is taken. As an alternative, how about taking the lock in the `BlockManager` constructor, like done here https://github.com/TheCharlatan/bitcoin/tree/loc
...

📝 l0rinc opened a pull request: "optimization: `CheckBlock` input duplicate detection"
(https://github.com/bitcoin/bitcoin/pull/31682)
`CheckBlock`'s latency is critical both for quickly discarding invalid blocks and for efficiently validating correct inputs.

This PR improves performance and maintainability by introducing the following changes:
* Benchmarks now measure `CheckBlock` performance for both valid and invalid cases separately (without serialization cost), ensuring accurate insights into critical paths.
* Simplified checks for the most common cases (1 or 2 inputs - [>70% of transactions seem to have a single inpu
...

📝 l0rinc converted_to_draft a pull request: "optimization: `CheckBlock` input duplicate detection"
(https://github.com/bitcoin/bitcoin/pull/31682)
`CheckBlock`'s latency is critical both for quickly discarding invalid blocks and for efficiently validating correct inputs.

This PR improves performance and maintainability by introducing the following changes:
* Benchmarks now measure `CheckBlock` performance for both valid and invalid cases separately (without serialization cost), ensuring accurate insights into critical paths.
* Simplified checks for the most common cases (1 or 2 inputs - [>70% of transactions seem to have a single inpu
...

💬 Eunovo commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#issuecomment-2599763207)
@ismaelsadeeq I wanted to get other opinions on this. With the addition of changesets, the problem is more complicated.

> Can you elaborate on how that work, and the wallet detects that, what if the conflict is not from the child, it's from a parent transaction?

It does work because it's guaranteed that the parent will be confirmed before the child. The wallet can mark the replaced wallet tx as conflicted when the child of the package gets confirmed. The problem though is that the child m
...

👋 l0rinc's pull request is ready for review: "optimization: `CheckBlock` input duplicate detection"
(https://github.com/bitcoin/bitcoin/pull/31682)

💬 1440000bytes commented on pull request "optimization: `CheckBlock` input duplicate detection":
(https://github.com/bitcoin/bitcoin/pull/31682#discussion_r1921118826)
I just reviewed this code and it looks okay to me. However, this is consensus related code and an optimization had caused [CVE-2018-17144](https://bitcoincore.org/en/2018/09/20/notice/) so regular contributors might know better.

🤔 BrandonOdiwuor reviewed a pull request: "init: Lock blocksdir in addition to datadir"
(https://github.com/bitcoin/bitcoin/pull/31674#pullrequestreview-2560502292)
Concept ACK

💬 TheBlueMatt commented on issue "Mining Interface doesn't allow for Bitcoin Core to create blocks when it wants":
(https://github.com/bitcoin/bitcoin/issues/31109#issuecomment-2599859107)
> There's no reason Mining.createNewBlock or BlockTemplate.waitNext methods need to use cs_main. cs_main is an implementation detail and not part of the interface. For example we could have:

Sure, my point wasn't that it has to be exposed in the interface, rather that the implementation details here matter, and the interface should reflect that.

> @TheBlueMatt when you opened this issue the proposed waitFeesChanged() still returned a bool:https://github.com/bitcoin/bitcoin/pull/31003/files#r18
...

⚠️ WTRADEEA opened an issue: "Twk MOMO"
(https://github.com/bitcoin/bitcoin/issues/31683)