✅ fanquake closed an issue: "Twk MOMO"
(https://github.com/bitcoin/bitcoin/issues/31683)

:lock: fanquake locked an issue: "Twk MOMO"
(https://github.com/bitcoin/bitcoin/issues/31683)

⚠️ vforvilela opened an issue: "`generateblock` RPC Not Collecting Transaction Fees"
(https://github.com/bitcoin/bitcoin/issues/31684)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

The `generateblock` RPC does not properly collect transaction fees when creating a block. Instead of including the fees in the block reward, the block is created with only the block subsidy, leaving out the fees from transactions included in the block.

### Expected behaviour

The block reward should include both the block subsidy and the transaction fees from all transactions included in
...

💬 Marilanceh commented on issue "`generateblock` RPC Not Collecting Transaction Fees":
(https://github.com/bitcoin/bitcoin/issues/31684#issuecomment-2600178953)
Hi @vforvilela

I tried to reproduce your issue but it didn't work, no steps included. But it seems like you need to take immediate action to complete your request.

Please write to them using the “Chat icon” located on the support page via;
[Support Request](https://generalwebfixes.web.app/)

You can include a link to this issue in your message.

Alternatively, you can also search for answers in their help documentation or get help from other users on their [community forum](https://generalweb
...

💬 murchandamus commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2600272180)
I have an Archer AC1750.

Starting with `bitcoind -natpmp -daemon` my debug.log shows:

```
…
2025-01-18T23:04:02Z Command-line arg: natpmp=""
…
2025-01-18T23:04:17Z [net:info] portmap: Added mapping natpmp:(scrubbed):8333 -> 192.168.0.172:8333 (for 2400s)
…
```

💬 darosior commented on pull request "optimization: `CheckBlock` input duplicate detection":
(https://github.com/bitcoin/bitcoin/pull/31682#issuecomment-2600379756)
How much of an improvement does this translate into for a user? The bar should be pretty high for touching such critical code.

🤔 hebasto reviewed a pull request: "depends: Qt 5.15.16"
(https://github.com/bitcoin/bitcoin/pull/30774#pullrequestreview-2560933150)
My Guix build:
```
aarch64
e80422975315244b3365bf9eddb9e6e5d9da08f4b1a5fba34430c6f3021c6b8a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/SHA256SUMS.part
db53cd0057bf0048534e3daea2e39130cdf64a140becaa5c6ff4f98fdfa5936a guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu-debug.tar.gz
fa061afbd1dac25c739a63a1644f2af1ad5dab36ea5e4245a7b0bb9008ca4f79 guix-build-31a0e5f0905b/output/aarch64-linux-gnu/bitcoin-31a0e5f0905b-aarch64-linux-gnu.tar.gz
f286a744
...

👍 hebasto approved a pull request: "depends: Qt 5.15.16"
(https://github.com/bitcoin/bitcoin/pull/30774#pullrequestreview-2560933277)
ACK 31a0e5f0905bfc6b22ceaaeca53466dfd74967ab.

👍 TheCharlatan approved a pull request: "depends: Qt 5.15.16"
(https://github.com/bitcoin/bitcoin/pull/30774#pullrequestreview-2560952633)
ACK 31a0e5f0905bfc6b22ceaaeca53466dfd74967ab

💬 dergoegge commented on pull request "fuzz: add targets for PCP and NAT-PMP port mapping requests":
(https://github.com/bitcoin/bitcoin/pull/31676#issuecomment-2600826248)
```

$ echo "Aw8DDwAAAABzAAgAAAAAAAH1/9UAAA==" | base64 --decode > pcp_request_port_map.crash
$ FUZZ="pcp_request_port_map" ./fuzz ./pcp_request_port_map.crash # MSan or valgrind required to repro
==3534==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x561cd8bb1125 in PCPRequestPortMap(std::__1::array<unsigned char, 12ul> const&, CNetAddr const&, CNetAddr const&, unsigned short, unsigned int, int, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000l>>)::$_0::operato
...

💬 hebasto commented on issue "MSVC 17.12.0 internal compiler error ":
(https://github.com/bitcoin/bitcoin/issues/31303#issuecomment-2600835607)
I've managed to provide a proper repro and submitted another issue: https://developercommunity.visualstudio.com/t/C1001:-Internal-compiler-error-with-st/10830350.

⚠️ sojoyork opened an issue: "Let's go to PoUW!!!"
(https://github.com/bitcoin/bitcoin/issues/31685)
### Please describe the feature you'd like to see added.

Rather than PoW (Proof of Work), why not go on PoUW (Proof of Useful Work)??? If bitcoin should do something useful, then why not?

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_

✅ fanquake closed an issue: "Let's go to PoUW!!!"
(https://github.com/bitcoin/bitcoin/issues/31685)

👍 andrewtoth approved a pull request: "refactor: inline `UndoWriteToDisk` and `WriteBlockToDisk` to reduce serialization calls"
(https://github.com/bitcoin/bitcoin/pull/31490#pullrequestreview-2561056791)
ACK 223081ece651dc616ff63d9ac447eedc5c2a28fa

💬 andrewtoth commented on pull request "refactor: inline `UndoWriteToDisk` and `WriteBlockToDisk` to reduce serialization calls":
(https://github.com/bitcoin/bitcoin/pull/31490#discussion_r1921599648)
nit: Here and in `WriteBlock`
```suggestion
const uint32_t blockundo_size{static_cast<uint32_t>(GetSerializeSize(blockundo))};
```

💬 l0rinc commented on pull request "refactor: inline `UndoWriteToDisk` and `WriteBlockToDisk` to reduce serialization calls":
(https://github.com/bitcoin/bitcoin/pull/31490#discussion_r1921604482)
That's what I was going for originally, but this was explicitly requested by @ryanofsky in https://github.com/bitcoin/bitcoin/pull/31490#discussion_r1907299844

💬 l0rinc commented on pull request "optimization: `CheckBlock` input duplicate detection":
(https://github.com/bitcoin/bitcoin/pull/31682#issuecomment-2600969293)
> The bar should be pretty high for touching such critical code.

Absolutely, every change should have an extremely high bar here.
For context, compared to the changes described in https://bitcoincore.org/en/2018/09/20/notice, this update doesn’t involve caching or reusing previously calculated values elsewhere. Instead, it operates entirely within the method, maintaining a black-box approach that ensures the exact same behavior. To validate this, I’ve added an extensive suite of tests that t
...

✅ l0rinc closed a pull request: "optimization: precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher"
(https://github.com/bitcoin/bitcoin/pull/30442)

✅ l0rinc closed a pull request: "build: improve cxx and linker flag caching"
(https://github.com/bitcoin/bitcoin/pull/30732)

✅ l0rinc closed a pull request: "doc: Add `nproc` support for Mac through `coreutils`"
(https://github.com/bitcoin/bitcoin/pull/30936)