💬 willcl-ark commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#issuecomment-2411599475)
Related to: https://github.com/bitcoin/bitcoin/issues/9641
(https://github.com/bitcoin/bitcoin/pull/24539#issuecomment-2411599475)
Related to: https://github.com/bitcoin/bitcoin/issues/9641
💬 maflcko commented on pull request "ci: Split out native fuzz jobs for macOS and windows":
(https://github.com/bitcoin/bitcoin/pull/31073#issuecomment-2411608383)
Not sure about rushing this. Maybe wait for a fix for https://github.com/bitcoin/bitcoin/issues/31057 first, after which this may or may not be needed?
(https://github.com/bitcoin/bitcoin/pull/31073#issuecomment-2411608383)
Not sure about rushing this. Maybe wait for a fix for https://github.com/bitcoin/bitcoin/issues/31057 first, after which this may or may not be needed?
✅ willcl-ark closed an issue: "loadwallet hangs on forever!"
(https://github.com/bitcoin/bitcoin/issues/29525)
(https://github.com/bitcoin/bitcoin/issues/29525)
💬 willcl-ark commented on issue "loadwallet hangs on forever!":
(https://github.com/bitcoin/bitcoin/issues/29525#issuecomment-2411631244)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
(https://github.com/bitcoin/bitcoin/issues/29525#issuecomment-2411631244)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
✅ willcl-ark closed an issue: "RPC idempotency and RPC request replay protection"
(https://github.com/bitcoin/bitcoin/issues/9197)
(https://github.com/bitcoin/bitcoin/issues/9197)
💬 willcl-ark commented on issue "RPC idempotency and RPC request replay protection":
(https://github.com/bitcoin/bitcoin/issues/9197#issuecomment-2411641511)
This feature request does not seem to have attracted much attention from other contributors. As such, it does not seem important enough to keep it sitting around idle in the list of open issues. Closing due to lack of interest.
Pull requests with improvements are always welcome.
(https://github.com/bitcoin/bitcoin/issues/9197#issuecomment-2411641511)
This feature request does not seem to have attracted much attention from other contributors. As such, it does not seem important enough to keep it sitting around idle in the list of open issues. Closing due to lack of interest.
Pull requests with improvements are always welcome.
✅ willcl-ark closed an issue: "Historical scripted-diff failures (trivial)"
(https://github.com/bitcoin/bitcoin/issues/29692)
(https://github.com/bitcoin/bitcoin/issues/29692)
💬 willcl-ark commented on issue "Historical scripted-diff failures (trivial)":
(https://github.com/bitcoin/bitcoin/issues/29692#issuecomment-2411648418)
Closed at request of author.
(https://github.com/bitcoin/bitcoin/issues/29692#issuecomment-2411648418)
Closed at request of author.
✅ willcl-ark closed an issue: "Since 0.16 Bitcoin can be stuck connected to adversarial/3rdparty node"
(https://github.com/bitcoin/bitcoin/issues/29506)
(https://github.com/bitcoin/bitcoin/issues/29506)
💬 willcl-ark commented on issue "Since 0.16 Bitcoin can be stuck connected to adversarial/3rdparty node":
(https://github.com/bitcoin/bitcoin/issues/29506#issuecomment-2411653961)
The problem is not easily reproducible.
Please open a new issue (or leave a comment in here if you want this re-opened) if you experience the problem again.
(https://github.com/bitcoin/bitcoin/issues/29506#issuecomment-2411653961)
The problem is not easily reproducible.
Please open a new issue (or leave a comment in here if you want this re-opened) if you experience the problem again.
💬 maflcko commented on issue "Historical scripted-diff failures (trivial)":
(https://github.com/bitcoin/bitcoin/issues/29692#issuecomment-2411656801)
IIRC the exit code is ignored either way, because `./test/lint/commit-script-check.sh` doesn't set `-e`, but you do.
That may also be the reason they were not found by CI.
(https://github.com/bitcoin/bitcoin/issues/29692#issuecomment-2411656801)
IIRC the exit code is ignored either way, because `./test/lint/commit-script-check.sh` doesn't set `-e`, but you do.
That may also be the reason they were not found by CI.
✅ willcl-ark closed an issue: "Default -rpcclienttimeout is too low for calls which cause rescan"
(https://github.com/bitcoin/bitcoin/issues/9918)
(https://github.com/bitcoin/bitcoin/issues/9918)
💬 willcl-ark commented on issue "Default -rpcclienttimeout is too low for calls which cause rescan":
(https://github.com/bitcoin/bitcoin/issues/9918#issuecomment-2411658195)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
(https://github.com/bitcoin/bitcoin/issues/9918#issuecomment-2411658195)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
✅ willcl-ark closed an issue: "Error: specified data directory "\\IP.Ad.re.ss\release\Folder"does not exist"
(https://github.com/bitcoin/bitcoin/issues/25868)
(https://github.com/bitcoin/bitcoin/issues/25868)
💬 willcl-ark commented on issue "Error: specified data directory "\\IP.Ad.re.ss\release\Folder"does not exist":
(https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-2411660857)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
(https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-2411660857)
Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
✅ willcl-ark closed an issue: "build warnings in outputtype.cpp: may be used uninitialized"
(https://github.com/bitcoin/bitcoin/issues/29359)
(https://github.com/bitcoin/bitcoin/issues/29359)
💬 willcl-ark commented on issue "build warnings in outputtype.cpp: may be used uninitialized":
(https://github.com/bitcoin/bitcoin/issues/29359#issuecomment-2411668157)
This is an upstream issue and will be solved next time you upgrade your toolchain.
Closing for now. Leave a comment if you want this re-opened.
(https://github.com/bitcoin/bitcoin/issues/29359#issuecomment-2411668157)
This is an upstream issue and will be solved next time you upgrade your toolchain.
Closing for now. Leave a comment if you want this re-opened.
💬 darosior commented on issue "Witness scripts being abused to bypass datacarriersize limit (CVE-2023-50428)":
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-2411676907)
This CVE is disputed. The large majority of contributors to this project disagree this is indeed a security vulnerability. I personally believe the CVE system is being abused in this case.
I believe this issue should be closed. There is no point in keeping it open.
(https://github.com/bitcoin/bitcoin/issues/29187#issuecomment-2411676907)
This CVE is disputed. The large majority of contributors to this project disagree this is indeed a security vulnerability. I personally believe the CVE system is being abused in this case.
I believe this issue should be closed. There is no point in keeping it open.
🤔 jarolrod reviewed a pull request: "build: Fix kernel static lib component install"
(https://github.com/bitcoin/bitcoin/pull/31078#pullrequestreview-2367206853)
concept ack
master install
```
cmake --install build --component Kernel
-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/lib/libbitcoinkernel.a
```
pr install
```
cmake --install build --component Kernel
-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/lib/libbitcoin_crypto.a
-- Installing: /usr/local/lib/libbitcoin_crypto_sse41.a
-- Installing: /usr/local/lib/libbitcoin_crypto_avx2.a
-- Installing: /usr/local/lib/libbitcoin_cryp
...
(https://github.com/bitcoin/bitcoin/pull/31078#pullrequestreview-2367206853)
concept ack
master install
```
cmake --install build --component Kernel
-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/lib/libbitcoinkernel.a
```
pr install
```
cmake --install build --component Kernel
-- Install configuration: "RelWithDebInfo"
-- Installing: /usr/local/lib/libbitcoin_crypto.a
-- Installing: /usr/local/lib/libbitcoin_crypto_sse41.a
-- Installing: /usr/local/lib/libbitcoin_crypto_avx2.a
-- Installing: /usr/local/lib/libbitcoin_cryp
...
⚠️ danielabrozzoni opened an issue: "Unable to compile for test coverage on Nixos 24.05"
(https://github.com/bitcoin/bitcoin/issues/31087)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
I'm trying to compile Bitcoin Core for test coverage as explained in `doc/developer-notes.md`, but the command `cmake -P build/Coverage.cmake` fails with
```
[...]
Finished .info-file creation
Deleting all .da files in src and subdirectories
Done.
.lcov-wrapped: WARNING: negative counts found in tracefile test_bitcoin_filtered.info
Combining tracefiles.
Reading tracefile test_bitc
...
(https://github.com/bitcoin/bitcoin/issues/31087)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
I'm trying to compile Bitcoin Core for test coverage as explained in `doc/developer-notes.md`, but the command `cmake -P build/Coverage.cmake` fails with
```
[...]
Finished .info-file creation
Deleting all .da files in src and subdirectories
Done.
.lcov-wrapped: WARNING: negative counts found in tracefile test_bitcoin_filtered.info
Combining tracefiles.
Reading tracefile test_bitc
...