💬 Av32000 commented on pull request "doc: Add xz-utils to the general dependencies for windows build":
(https://github.com/bitcoin/bitcoin/pull/31084#discussion_r1799983029)
I agree with you, I'm closing the pr.

✅ Av32000 closed a pull request: "doc: Add xz-utils to the general dependencies for windows build"
(https://github.com/bitcoin/bitcoin/pull/31084)

💬 Fidel76y commented on issue "Setting torcontrol overrides proxy address":
(https://github.com/bitcoin/bitcoin/issues/25265#issuecomment-2412085149)
According to my understanding bitcoin core designed automatically to configure tor when using `torcontrol,` when `torcontrol` is active the device automatically manages the tor instance making it override the manual proxy configuration

⚠️ ismaelsadeeq opened an issue: "wallet: rpc: `settxfee` sets the wallet feerate not fee"
(https://github.com/bitcoin/bitcoin/issues/31088)
The wallet RPC `settxfee` sets the fee rate for a wallet.

Current help text:
```
Set the transaction fee rate in BTC/kvB for this wallet. Overrides the global -paytxfee command line parameter.
Can be deactivated by passing 0 as the fee. In that case automatic fee selection will be used by default.

Arguments:
1. amount (numeric or string, required) The transaction fee rate in BTC/kvB

Result:
true|false (boolean) Returns true if successful
```
This is a misnomer, as stated h
...

💬 ismaelsadeeq commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2412341951)
> I'm not sure. Point 3 and the rationales in [#20484 (comment)](https://github.com/bitcoin/bitcoin/pull/20484#issuecomment-734786305) suggest a possibly safer way (perhaps you have a workaround in mind I'm overlooking).

You are right! I opened an issue for this #31088

💬 1440000bytes commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2412347684)
No IPv6 support?

💬 ismaelsadeeq commented on issue "Fee Estimation via Fee rate Forecasters tracking issue":
(https://github.com/bitcoin/bitcoin/issues/30392#issuecomment-2412355904)
> While reviwing data from [txstats](https://txstats.com/d/000000011/fee-estimation?orgId=1) in the context of optimizing how Eclair manages its utxo set I noticed the large variation between estimatesmartfee and, for example, mempool.space fee estimation.

Also see https://github.com/bitcoin/bitcoin/pull/30157#issuecomment-2128952313

> Eclair uses `estimatesmartfee` and recently changed from the (previous) default to economical

Bitcoin Core 28.0 also updated its default to `economical`
...

💬 ismaelsadeeq commented on issue "Why does `submitpackage` require at least two transactions":
(https://github.com/bitcoin/bitcoin/issues/31085#issuecomment-2412384410)
It won't hurt to broadcast a single transaction if it passes consensus and policy checks via `submitpackage` RPC.

From the [package relay BIP](https://github.com/bitcoin/bips/blob/632f143fadaed8c91bba12d096e62feb2a308054/bip-0331.mediawiki#definitions) and the [policy documentation](https://github.com/bitcoin/bitcoin/blob/master/doc/policy/packages.md), I see that a package is defined as a child transaction with its unconfirmed ancestors, topologically sorted.

I think the intent of the che
...

💬 1440000bytes commented on pull request "Deniability - a tool to automatically improve coin ownership privacy":
(https://github.com/bitcoin-core/gui/pull/733#issuecomment-2412386930)
@denavila any update on 3 and 4 from https://github.com/bitcoin-core/gui/pull/733#issuecomment-2083190086?

💬 TheBlueMatt commented on issue "Why does `submitpackage` require at least two transactions":
(https://github.com/bitcoin/bitcoin/issues/31085#issuecomment-2412484265)
From a Bitcoin Core perspective, sure. From the users' perspective I have a bundle of transactions and I want to get them relayed. They may be a package, they may not, I want Bitcoin Core to figure that out, not me.

💬 l0rinc commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2412512371)
Finished the same benchmarks on a HDD with very similar results:

<details>
<summary>benchmark</summary>

```
# hyperfine \
--runs 1 \
--export-json /mnt/my_storage/ibd_full-write-chainstate-every-hour.json \
--parameter-list COMMIT 5e90501abe13731579c61b13092b31b9fc4f8c4d,ffc9df87a0da35b451720556bdb3f0f65f315c8f,f5e7b1508a06c0c7a9c06d1ac270840fd72e9e6f \
--prepare 'rm -rf /mnt/my_storage/BitcoinData/* && git checkout {COMMIT} && git clean -fxd && git reset \
--hard && cmake -B build
...

💬 brunoerg commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#issuecomment-2413148520)
Worth adding a release note?

📝 l0rinc opened a pull request: "CI: Add label to scripted-diffs"
(https://github.com/bitcoin/bitcoin/pull/31089)
testing

✅ hebasto closed an issue: "CMake-based build system tracking issue"
(https://github.com/bitcoin/bitcoin/issues/28607)

💬 hebasto commented on issue "CMake-based build system tracking issue":
(https://github.com/bitcoin/bitcoin/issues/28607#issuecomment-2413162020)
Closing. See https://github.com/bitcoin/bitcoin/pull/30454.

📝 l0rinc converted_to_draft a pull request: "CI: Add label to scripted-diffs"
(https://github.com/bitcoin/bitcoin/pull/31089)
Add a `scripted-diff` label for pull requests that contain `scripted-diff:` commits to make sure that CI is running them properly.

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1800679447)
This was introduced in b335710782c2545e6eeed67b5e1763c07eab26b0.

Related to https://github.com/bitcoin/bitcoin/pull/28880#issuecomment-1867610348.

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1800702587)
Can you suggest another name? It's a map to get peer info, hence `m_peer_info`.

💬 hebasto commented on issue "Run coverage functional tests in parallel":
(https://github.com/bitcoin/bitcoin/issues/26736#issuecomment-2413249267)
> This was probably resolved by `cmake`.

From the "Compiling for test coverage" section of [Developer Notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#compiling-for-test-coverage):
> To enable test parallelism:
>
> cmake -DJOBS=$(nproc) -P build/Coverage.cmake

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1800708031)
Grep will show `AddTxAnnouncement` called with `p2p_inv=false` in the new orphan handling code. We don't exit because we might already have a low feerate parent in reconsiderable rejects. You can also comment this out to see what fails.