💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#discussion_r1759642418)
I cherry-picked this, but it adds significant runtime to the test for what is a very basic check. I'd suggest filing a follow-up if you're still interested in testing this.

⚠️ johnsqonericgaK opened an issue: "https://github.market : Buy Github Stars, Forks & more over at https://github.market"
(https://github.com/bitcoin/bitcoin/issues/30904)
Boost visibility and ranking of your Github Profile and Repositories with our products over at https://github.market

We sell:
- Github Stars
- Github Forks
- Github Followers
- Github Watchers
- Github Reactions
- Github Upvotes
- Github Comments
- A Github Botting Tool

Our high-quality products come with substantial bulk discounts, ensuring both excellence and cost-effectiveness.

Buy now over at https://github.market

🤔 Shourya742 requested changes to a pull request: "Stratum v2 Noise Protocol"
(https://github.com/bitcoin/bitcoin/pull/29346#pullrequestreview-2291544930)
utACK. This looks good, just a few nits. It closely aligns with the Noise NX standards and the SRI template provider implementation. I will test it soon and share detailed findings.

💬 Shourya742 commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1758221954)
```suggestion
* @returns whether encryption succeeded
```

💬 Shourya742 commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1751379795)
```suggestion
size_t num_chunks = (plain.size() + max_chunk_size - 1) / max_chunk_size;
```

💬 Shourya742 commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1759755153)
```suggestion
size_t chunk_size = NOISE_MAX_CHUNK_SIZE - Poly1305::TAGLEN;
size_t num_chunks = (msg_len + chunk_size - 1) / chunk_size;
return msg_len + (num_chunks * Poly1305::TAGLEN);

```

👋 hebasto's pull request is ready for review: "cmake: Add `FindZeroMQ` module"
(https://github.com/bitcoin/bitcoin/pull/30903)

👋 hebasto's pull request is ready for review: "build: Improve `ccache` performance for different build directories"
(https://github.com/bitcoin/bitcoin/pull/30861)

💬 hebasto commented on pull request "build: Improve `ccache` performance for different build directories":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2351053745)
The PR has been reworked to keep compatibility with git worktrees. See [this](https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1752076990) discussion.

The PR description has been updated accordingly.

💬 hebasto commented on pull request "build: Improve `ccache` performance for different build directories":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1759763193)
@ryanofsky
> I only do the second not the first, because I use git worktrees...

Thanks for your feedback. Your concerns should be addressed in the recent [push](https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2351053745).

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769956)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769962)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769972)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769979)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2351067786)
> Also in `test_deterministic_coverage.sh`: `Run \"./configure --enable-lcov\"`

thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2351067954)
> Since you are here, you could update the translate instructions as well (I've tested them), if @hebasto agrees with the changes:
>
> * `doc/translation_process.md`
> ```diff
> @@ -18,8 +18,8 @@ We use automated scripts to help extract translations in both Qt, and non-Qt sou
>
> To automatically regenerate the `bitcoin_en.ts` file, run the following commands:
> ```sh
> -cd src/
> -make translate
> +cmake -B build -DWITH_BDB=ON -
...

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change and removed libtools from CI":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2351069254)
From these two comments these are the two that have not been addressed yet in this PR
https://github.com/bitcoin/bitcoin/pull/30664#issuecomment-2320892444 https://github.com/bitcoin/bitcoin/pull/30664#issuecomment-2321610186

```
test/get_previous_releases.py: './configure {}'.format(config_flags),
contrib/devtools/check-deps.sh:# Output makefile targets, converting library .a paths to libtool .la targets
```

👍 itornaza approved a pull request: "Stratum v2 Noise Protocol"
(https://github.com/bitcoin/bitcoin/pull/29346#pullrequestreview-2304920988)
re ACK c8d9d84e21ba091be6be83261b31684ac693d016

Run all tests locally once again and all of them pass including the extended.

💬 itornaza commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1759782079)
If you consider updating for other reasons, could you format this in the same way as PROTOCOL_NAME_HASH?

💬 tdb3 commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change and removed libtools from CI":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759786194)
Wouldn't we want to keep `bitcoin-node` (part of multiprocess) rather than change to `bitcoind`? Am I missing something?

Thoughts @ryanofsky ?