💬 ismaelsadeeq commented on issue "Mempool + Validation Code Organization":
(https://github.com/bitcoin/bitcoin/issues/25584#issuecomment-2351096923)
If I understand correctly as is right now
- Validation houses to all of validation logic(block, transaction, and mempool)
- txmempool defines the data structure of mempool transactions managing removal and addition.

```mermaid
graph TD
A[Validation] --> B[Block Validation]
A[Validation] --> C[Mempool Validation]
A[Validation] --> D[Chainstate Manager]
A[Validation] --> E[MemPool]
E --> F[CTxMempool]
D --> E
```

> I agree, but my point is that the relatio
...

💬 ismaelsadeeq commented on issue "Improve documentation of estimatesmartfee":
(https://github.com/bitcoin/bitcoin/issues/18217#issuecomment-2351102167)
The previous attempt to fix in #30525 in commit https://github.com/bitcoin/bitcoin/commit/e387642f36ba01e45656875d8bde7b021ed28556 was not successful, so I am bringing this here as an attempt to move this issue forward i.e closed/fixed

> _@glozow said in https://github.com/bitcoin/bitcoin/pull/30525#discussion_r1705470107:
I think the previous text is clear and not inaccurate, so I'm wondering whether this last commit is necessary._

📝 hebasto opened a pull request: "cmake: Switch to crc32c upstream build system"
(https://github.com/bitcoin/bitcoin/pull/30905)
A few things still need to be addressed:
- The minimum supported version 3.1 is too low and raises a warning.
- Some compiler flags (hardening, sanitizers etc) have to be passed to the subtree build system.
- https://github.com/google/crc32c/pull/61.

💬 hebasto commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change and removed libtools from CI":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2351112478)
@kevkevinpal

I didn't notice that https://github.com/bitcoin/bitcoin/pull/30902 overlaps with this PR. Feel free to pick all changes from https://github.com/bitcoin/bitcoin/pull/30902 to let me close it.

💬 hebasto commented on pull request "Remove Autotools packages from depends and CI":
(https://github.com/bitcoin/bitcoin/pull/30902#issuecomment-2351113099)
About to close it in favour of https://github.com/bitcoin/bitcoin/pull/30875.

💬 edilmedeiros commented on issue "contrib/signet/miner: grind will fail for high difficulty chain":
(https://github.com/bitcoin/bitcoin/issues/30102#issuecomment-2351114889)
Could not reproduce this using `--min-nbits` with the new miner script from #28417. Seems like the difficulty won't increase as fast as I would expect, even after 10 difficulty adjustment periods. I'll leave it running more time to be sure and also try again using a custom difficulty as initially reported.

💬 hebasto commented on pull request "kernel: Create usable static kernel library":
(https://github.com/bitcoin/bitcoin/pull/30814#discussion_r1760005637)
Should this be a part of the ["Kernel" component](https://github.com/bitcoin/bitcoin/pull/30835)?

💬 TheCharlatan commented on pull request "kernel: Create usable static kernel library":
(https://github.com/bitcoin/bitcoin/pull/30814#discussion_r1760007655)
Yeah, I missed this. Already patched in #30595 , but could also patch it independently if you want to.

💬 hebasto commented on pull request "kernel: Create usable static kernel library":
(https://github.com/bitcoin/bitcoin/pull/30814#discussion_r1760009962)
> Already patched in #30595 , but could also patch it independently if you want to.

Great!

Feel free to consider another refactor commit to get rid off `foreach()` loop: https://github.com/hebasto/bitcoin/commits/240915-kernel/.

💬 fjahr commented on pull request "test: Introduce ensure helper":
(https://github.com/bitcoin/bitcoin/pull/30893#issuecomment-2351534412)
Since a few reviewers seem to prefer a clearer naming, I have now changed it to `ensure_for(duration=..., f=...)`.

💬 danielabrozzoni commented on pull request "signet: fixing mining for OP_TRUE challenge":
(https://github.com/bitcoin/bitcoin/pull/29032#discussion_r1760032207)
I think walletprocesspsbt is trying to sign the PSBT using `SIGHASH_DEFAULT`, while the PSBT specifies to use `SIGHASH_ALL`.

Using `$CLI -signet walletprocesspsbt $PSBT true ALL` works for me.

📝 l0rinc opened a pull request: "coins: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests"
(https://github.com/bitcoin/bitcoin/pull/30906)
Similarly to https://github.com/bitcoin/bitcoin/pull/30849, this cleanup is intended to de-risk https://github.com/bitcoin/bitcoin/pull/30673#discussion_r1739909068 by simplifying the coin cache public interface.

`CCoinsCacheEntry` provided general access to its internal flags state, even though, in reality, it could only be `clean`, `fresh`, `dirty`, or `fresh|dirty` (in the follow-up, we will remove `fresh` without `dirty`).

Once it was marked as `dirty`, we couldn’t set the state back t
...

💬 l0rinc commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r1760050345)
Split out to https://github.com/bitcoin/bitcoin/pull/30906

🤔 andrewtoth reviewed a pull request: "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests"
(https://github.com/bitcoin/bitcoin/pull/30906#pullrequestreview-2305366216)
Concept ACK

Can we remove any other tests that are trying to add flags that are not FRESH or DIRTY and so are now useless?

💬 andrewtoth commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1760052862)
Why was this changed?

💬 andrewtoth commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1760052629)
This assertion is obviated now.

💬 andrewtoth commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1760053494)
`But` can be removed now.

💬 glozow commented on pull request "cluster mempool: optimized candidate search":
(https://github.com/bitcoin/bitcoin/pull/30286#issuecomment-2351617058)
My graph on a log scale, looks similar to sipa's:


Results txt: [2024-09-14-bench.txt](https://github.com/user-attachments/files/17006092/2024-09-14-bench.txt)

💬 maflcko commented on issue "CI timeouts":
(https://github.com/bitcoin/bitcoin/issues/30851#issuecomment-2351617378)
> I could reproduce the macOS 2h timeout issue on GHA yesterday. However, today I also fail to reproduce them.

Actually, it looks like the GHA macOS CI timeouts remain today, for example: https://github.com/bitcoin/bitcoin/actions/runs/10833854937/job/30163805645?pr=30866 or https://github.com/bitcoin/bitcoin/actions/runs/10829942238/job/30163952659?pr=30856

I am not really familiar with GHA, nor with macOS, so it would be good if someone else checked:

* Does the macOS 13 GHA task succ
...

💬 l0rinc commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1760072626)
Because class declarations don't need semicolons, but I'll revert if you find it distracting