💬 BrandonOdiwuor commented on pull request "doc: explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/28974#discussion_r1574923164)
removed

💬 BrandonOdiwuor commented on pull request "doc: explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/28974#discussion_r1574923762)
fixed:summarised further

💬 maflcko commented on pull request "test: Fix multiprocess CI timeout in p2p_tx_download":
(https://github.com/bitcoin/bitcoin/pull/29926#issuecomment-2069822890)
See also the current test failure, which remains: https://github.com/bitcoin/bitcoin/pull/29926/checks?check_run_id=24105987877

💬 achow101 commented on pull request "ZMQ: Support UNIX domain sockets":
(https://github.com/bitcoin/bitcoin/pull/27679#issuecomment-2069827639)
ACK 21d0e6c7b7c7af7f6e54a45829b4fbfba6923b86

💬 instagibbs commented on pull request "test: Fix intermittent timeout in p2p_tx_download.py":
(https://github.com/bitcoin/bitcoin/pull/29933#discussion_r1574936864)
> Should I just put a comment here # Avoid inbounds because they are not needed and slow down the test?

not really, doesn't add anything, so leave it as is

💬 instagibbs commented on pull request "test: Fix intermittent timeout in p2p_tx_download.py":
(https://github.com/bitcoin/bitcoin/pull/29933#issuecomment-2069846036)
makes sense

ACK fa6c300a9926a1d35fdd0a80f59ea39769bd2596

💬 fjahr commented on pull request "test: Fix multiprocess CI timeout in p2p_tx_download":
(https://github.com/bitcoin/bitcoin/pull/29926#issuecomment-2069859823)
> Which indicates that the problem is during shutdown, _after_ the test, not in the test.
>
> So I don't think adding mocktime will fix it. Maybe you were running into a different issue, or are trying to fix a different bug?

Hm, I didn't see `Stopping nodes` being printed so I am not convinced it's during shutdown but maybe I am just not familiar enough with the test framework. I am closing since it seems even with the +30 it's still failing and it seems duplicate #29933 might have a bette
...

✅ fjahr closed a pull request: "test: Fix multiprocess CI timeout in p2p_tx_download"
(https://github.com/bitcoin/bitcoin/pull/29926)

💬 instagibbs commented on pull request "test: Don't fetch orphan parent when parent is in orphanage":
(https://github.com/bitcoin/bitcoin/pull/29915#discussion_r1574948358)
hmm yeah this doesn't add anything *unless it was requested in a separate `getdata` which this check wouldn't ensure anyways.

✅ instagibbs closed a pull request: "test: Don't fetch orphan parent when parent is in orphanage"
(https://github.com/bitcoin/bitcoin/pull/29915)

💬 maflcko commented on pull request "test: Fix multiprocess CI timeout in p2p_tx_download":
(https://github.com/bitcoin/bitcoin/pull/29926#issuecomment-2069873791)
> Hm, I didn't see Stopping nodes being printed so I am not convinced it's during shutdown


This will be printed after the network thread is closed. However, the network thread not closing is the underlying bug.

You can see this in the traceback I posted above. (`self.network_thread.close()` is line 314, and "Stopping nodes" is line 316)

🚀 achow101 merged a pull request: "ZMQ: Support UNIX domain sockets"
(https://github.com/bitcoin/bitcoin/pull/27679)

✅ achow101 closed an issue: "Invalid port specified in -zmqpubrawtx when using IPC"
(https://github.com/bitcoin/bitcoin/issues/29802)

💬 fjahr commented on pull request "doc: explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/28974#issuecomment-2069900043)
ACK 55b13ecd2e00ad2dbfd44c34d7de6f616590adf8

💬 levantah commented on issue "Release schedule for 27.0":
(https://github.com/bitcoin/bitcoin/issues/29028#issuecomment-2069950412)
Thank you @fanquake , @bitcoin please delete the previous comment and this one the same way. And Thanks.

💬 levantah commented on issue "Release schedule for 27.0":
(https://github.com/bitcoin/bitcoin/issues/29028#issuecomment-2069955306)
And happy Passover!

💬 fjahr commented on pull request "test: Fix intermittent timeout in p2p_tx_download.py":
(https://github.com/bitcoin/bitcoin/pull/29933#issuecomment-2070011950)
We should probably re-run the multiprocess job at least 2 more times manually here to ensure this actually fixes it and it wasn't just lucky this one time.

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2070016254)
i concur with @tdb3 - use underscores for signet paths.

💬 maflcko commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#discussion_r1575006254)
nit: According to Wikipedia, Big Sur is "Unsupported as of September 26, 2023." (https://en.wikipedia.org/wiki/MacOS_Big_Sur)

Maybe just say macOS Monterey 12 (and earlier), or drop Big Sur?

💬 maflcko commented on pull request "test: Fix intermittent timeout in p2p_tx_download.py":
(https://github.com/bitcoin/bitcoin/pull/29933#issuecomment-2070020844)
It is already re-run 10 times. You can double check by navigating to the Cirrus CI page for this pull request.