🤔 glozow reviewed a pull request: "test: Fix intermittent issue in p2p_handshake.py"
(https://github.com/bitcoin/bitcoin/pull/29898#pullrequestreview-2015211017)
ACK 6b02c11d667adff24daf611f9b14815d27963674

💬 fjahr commented on pull request "test: Fix intermittent timeout in p2p_tx_download.py":
(https://github.com/bitcoin/bitcoin/pull/29933#issuecomment-2070033655)
> It is already re-run 10 times. You can double check by navigating to the Cirrus CI page for this pull request.

Thanks, ACK fa6c300a9926a1d35fdd0a80f59ea39769bd2596

🚀 glozow merged a pull request: "test: Fix intermittent issue in p2p_handshake.py"
(https://github.com/bitcoin/bitcoin/pull/29898)

💬 achow101 commented on pull request "test: Fix intermittent issue in p2p_handshake.py":
(https://github.com/bitcoin/bitcoin/pull/29898#issuecomment-2070050583)
ACK 6b02c11d667adff24daf611f9b14815d27963674

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2070059159)
I concur with @Sjors.

💬 achow101 commented on pull request "net: Decrease nMaxIPs when learning from DNS seeds":
(https://github.com/bitcoin/bitcoin/pull/29850#issuecomment-2070059206)
ACK f2e3662e57eca1330962faf38ff428a564d50a11

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2070074983)
Ensure the signet path prefix is shared with the wallet so it can find the appropriate wallets for each signet. Treating the global signet as “just another signet” ought to simplify the wallet logic as well as avoiding a bug where the wallet doesn’t distinguish between global signet and custom signets.

✅ achow101 closed an issue: "Decreasing nMaxIPs when learning from DNS seeds"
(https://github.com/bitcoin/bitcoin/issues/16070)

🚀 achow101 merged a pull request: "net: Decrease nMaxIPs when learning from DNS seeds"
(https://github.com/bitcoin/bitcoin/pull/29850)

💬 josibake commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#discussion_r1575031937)
Added a new function `GetSerializedSilentPaymentsPublicData` that returns a `CPubKey`.

💬 josibake commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#discussion_r1575032154)
also lol at the `// TODO` comment

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#discussion_r1575035825)
fixed

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#discussion_r1575039039)
> I agree it could potentially be confused with the active chain in new code, and that would be a bug.

I added a comment in `CheckBlockIndex()` describing why these can differ.

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#discussion_r1575039363)
done, thanks!

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#discussion_r1575039633)
changed to an assert.

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#issuecomment-2070114863)
[e880ee0 ](https://github.com/bitcoin/bitcoin/commit/e880ee0a634f0be5079d39328fa5e118452553a9)to [3c3895c](https://github.com/bitcoin/bitcoin/commit/3c3895ccfa108e10f4a0b1a78f64ffedade1fd11):
Addressed review feedback.

💬 darosior commented on pull request "sign: don't assume we are parsing a sane TapMiniscript":
(https://github.com/bitcoin/bitcoin/pull/29853#discussion_r1575040757)
I think it emphases the wrong thing: we are not testing it's failing, we are testing it's not crashing. That's why i didn't do it. Anyways it's not really important and there is already a comment highlighting this. Done.

💬 laanwj commented on issue "RFC: In guix compile the GUI sequentially from everything else?":
(https://github.com/bitcoin/bitcoin/issues/29914#issuecomment-2070147285)
FWIW in #29923 i've removed all the GUI specific dependencies except for Qt itself.

👍 theStack approved a pull request: "test: Fix intermittent timeout in p2p_tx_download.py"
(https://github.com/bitcoin/bitcoin/pull/29933#pullrequestreview-2015285694)
ACK fa6c300a9926a1d35fdd0a80f59ea39769bd2596

Thanks for fixing!

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2070170967)
You may be able to allow cascading signet
configurations by having a user configured “prefix” setting.
This may also translate better to a gui dialogue later on as well (hot swapping signets from the gui).


[signet]
prune=1000

prefix=<short_string1>
signetchallenge=1234abc…
signetseednode=...

prefix=<short_string2>
signetchallenge=5678def…
signetseednode=...