💬 petertodd commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-2066969764)
The "two many replacements" condition is only triggered when a large number of transactions are replaced at once. OpenTimestamps doesn't do that.
On April 19, 2024 8:31:20 AM EDT, levantah ***@***.***> wrote:
>> Possibly the best estimate we can get for that is to look at full-RBF replacements that do not get mined. It's not too uncommon to see, for example, OpenTimestamp's full-RBF replacements mysteriously get mined at the second or third highest fee-rate they were propagated at even though
...
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-2066969764)
The "two many replacements" condition is only triggered when a large number of transactions are replaced at once. OpenTimestamps doesn't do that.
On April 19, 2024 8:31:20 AM EDT, levantah ***@***.***> wrote:
>> Possibly the best estimate we can get for that is to look at full-RBF replacements that do not get mined. It's not too uncommon to see, for example, OpenTimestamp's full-RBF replacements mysteriously get mined at the second or third highest fee-rate they were propagated at even though
...
📝 instagibbs opened a pull request: "test: Don't fetch orphan parent when parent is in orphanage"
(https://github.com/bitcoin/bitcoin/pull/29915)
Takes a comment to that effect and makes an assertion.
(https://github.com/bitcoin/bitcoin/pull/29915)
Takes a comment to that effect and makes an assertion.
⚠️ iotamega opened an issue: "Serious Crashes in v27 on Windows 10 and 11"
(https://github.com/bitcoin/bitcoin/issues/29916)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Both the pre-built binaries and manually compiling from source give the same issues with v27.
Very serious crashes that entirely lockup the client and require a force restart across both Windows 10 and Windows 11 across multiple machines. The issue does not happen on my Ubuntu machines and it seems to only be happening with my Windows based machines.
Have tried opening this ticket ma
...
(https://github.com/bitcoin/bitcoin/issues/29916)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Both the pre-built binaries and manually compiling from source give the same issues with v27.
Very serious crashes that entirely lockup the client and require a force restart across both Windows 10 and Windows 11 across multiple machines. The issue does not happen on my Ubuntu machines and it seems to only be happening with my Windows based machines.
Have tried opening this ticket ma
...
💬 iotamega commented on issue "Serious Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067175991)
2024-04-19T18:42:06Z Bitcoin Core version v27.0.0 (release build)
2024-04-19T18:42:06Z Qt 5.15.11 (static), plugin=windows (static)
2024-04-19T18:42:06Z Static plugins:
2024-04-19T18:42:06Z QWindowsIntegrationPlugin, version 331520
2024-04-19T18:42:06Z QWindowsVistaStylePlugin, version 331520
2024-04-19T18:42:06Z Style: windowsvista / QWindowsVistaStyle
2024-04-19T18:42:06Z System: Windows 10 Version 2009, x86_64-little_endian-llp64
2024-04-19T18:42:06Z Screen: \\.\DISPLAY1 1600x900, pi
...
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067175991)
2024-04-19T18:42:06Z Bitcoin Core version v27.0.0 (release build)
2024-04-19T18:42:06Z Qt 5.15.11 (static), plugin=windows (static)
2024-04-19T18:42:06Z Static plugins:
2024-04-19T18:42:06Z QWindowsIntegrationPlugin, version 331520
2024-04-19T18:42:06Z QWindowsVistaStylePlugin, version 331520
2024-04-19T18:42:06Z Style: windowsvista / QWindowsVistaStyle
2024-04-19T18:42:06Z System: Windows 10 Version 2009, x86_64-little_endian-llp64
2024-04-19T18:42:06Z Screen: \\.\DISPLAY1 1600x900, pi
...
💬 iotamega commented on issue "V2 Only Option":
(https://github.com/bitcoin/bitcoin/issues/29618#issuecomment-2067189094)
> Any v2only option should apply only to IPv4 and IPv6 peers, but not to Tor, I2P, CJDNS because the latter already have (stronger) MITM prevention and encryption.
Agreed on this point regarding Tor, I2P, and CJDNS.
> ## Per-address v2only option
> Surely one would set such an option for an address of a peer already known to support v2. For such a peer, v2 connection would already be established currently. So what is the point of having such an option? To make sure MITM does not interfere
...
(https://github.com/bitcoin/bitcoin/issues/29618#issuecomment-2067189094)
> Any v2only option should apply only to IPv4 and IPv6 peers, but not to Tor, I2P, CJDNS because the latter already have (stronger) MITM prevention and encryption.
Agreed on this point regarding Tor, I2P, and CJDNS.
> ## Per-address v2only option
> Surely one would set such an option for an address of a peer already known to support v2. For such a peer, v2 connection would already be established currently. So what is the point of having such an option? To make sure MITM does not interfere
...
👍 pinheadmz approved a pull request: "Make it possible to disable Tor binds and abort startup on bind failure"
(https://github.com/bitcoin/bitcoin/pull/22729#pullrequestreview-2012295896)
ACK d0c8109dd0f2c8ca3ee742f0a0f11911553e0a62
Reviewed each commit. Ran all unit and functional tests on arm/macos and then AGAIN on arm/linux (docker) when I noticed the relevant test requires it :-P
Confirmed the tests fail on master without the patch.
Also confirmed the "crash on port collision" behavior with my own test, @vasild take it or leave it: https://gist.github.com/pinheadmz/0bea4bf8d8bf9af85f8ae326286d3082
<details><summary>Show Signature</summary>
```
-----BEGIN PGP
...
(https://github.com/bitcoin/bitcoin/pull/22729#pullrequestreview-2012295896)
ACK d0c8109dd0f2c8ca3ee742f0a0f11911553e0a62
Reviewed each commit. Ran all unit and functional tests on arm/macos and then AGAIN on arm/linux (docker) when I noticed the relevant test requires it :-P
Confirmed the tests fail on master without the patch.
Also confirmed the "crash on port collision" behavior with my own test, @vasild take it or leave it: https://gist.github.com/pinheadmz/0bea4bf8d8bf9af85f8ae326286d3082
<details><summary>Show Signature</summary>
```
-----BEGIN PGP
...
💬 instagibbs commented on pull request "test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter)":
(https://github.com/bitcoin/bitcoin/pull/29827#issuecomment-2067244164)
Seeing a failure of this test in my other PR, though I can't make heads or tails of the failure: https://cirrus-ci.com/task/6740372997537792
(https://github.com/bitcoin/bitcoin/pull/29827#issuecomment-2067244164)
Seeing a failure of this test in my other PR, though I can't make heads or tails of the failure: https://cirrus-ci.com/task/6740372997537792
💬 hebasto commented on issue "Serious Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067254672)
@iotamega
> Right click on a bad actor peer and ban them, immediate lockup across MULTIPLE systems and both Windows 10 and Windows 11.
I'll try to reproduce the issue. Meanwhile, would you please be more specific regarding
> ### How did you obtain Bitcoin Core
>
> Other
If you're using pre-built binaries, where they were downloaded from?
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067254672)
@iotamega
> Right click on a bad actor peer and ban them, immediate lockup across MULTIPLE systems and both Windows 10 and Windows 11.
I'll try to reproduce the issue. Meanwhile, would you please be more specific regarding
> ### How did you obtain Bitcoin Core
>
> Other
If you're using pre-built binaries, where they were downloaded from?
💬 iotamega commented on issue "Serious Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067260215)
> If you're using pre-built binaries, where they were downloaded from?
I downloaded them directly from https://bitcoincore.org/bin/bitcoin-core-27.0/
I also thought maybe it was something with those so I then compiled on my own as well using WSL and encountered the same issue. Both give the same error, the prebuilt binary was also blocked by Windows Defender in the latest build of Windows 11 for containing a "keylogger" so I whitelisted it in Defender but haven't seen an issue like that in
...
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067260215)
> If you're using pre-built binaries, where they were downloaded from?
I downloaded them directly from https://bitcoincore.org/bin/bitcoin-core-27.0/
I also thought maybe it was something with those so I then compiled on my own as well using WSL and encountered the same issue. Both give the same error, the prebuilt binary was also blocked by Windows Defender in the latest build of Windows 11 for containing a "keylogger" so I whitelisted it in Defender but haven't seen an issue like that in
...
💬 hebasto commented on issue "Serious Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067262898)
> It doesn't happen 100% of the time so it might take a while to reproduce, it is a strange one.
Then I suggest to remove the word "Serious" from the issue title :)
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067262898)
> It doesn't happen 100% of the time so it might take a while to reproduce, it is a strange one.
Then I suggest to remove the word "Serious" from the issue title :)
💬 iotamega commented on issue "Serious Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067264471)
> > It doesn't happen 100% of the time so it might take a while to reproduce, it is a strange one.
>
> Then I suggest to remove the word "Serious" from the issue title :)
I can do that but it pretty serious when it requires a restart every few hours because I have to ban a very serious bad actor from causing a massive DDOS against my node, but I will remove it for the time being. I imagine others will be reporting the same issue.
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067264471)
> > It doesn't happen 100% of the time so it might take a while to reproduce, it is a strange one.
>
> Then I suggest to remove the word "Serious" from the issue title :)
I can do that but it pretty serious when it requires a restart every few hours because I have to ban a very serious bad actor from causing a massive DDOS against my node, but I will remove it for the time being. I imagine others will be reporting the same issue.
⚠️ IAmAdamRest opened an issue: "Windows 11 Blocks Install Due to "Virus Found""
(https://github.com/bitcoin/bitcoin/issues/29917)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Windows 11 Microsoft Defender blocks the installation of Bitcoin-Core version 27.0.0 due to a virus being found. Smartscreen also blocks the installer. I was able to get it installed by telling Microsoft Defender to ignore the "virus" but since this is the default behavior of Windows 11 now this could be an issue for new users who don't know anything.
### Expected behaviour
That the inst
...
(https://github.com/bitcoin/bitcoin/issues/29917)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Windows 11 Microsoft Defender blocks the installation of Bitcoin-Core version 27.0.0 due to a virus being found. Smartscreen also blocks the installer. I was able to get it installed by telling Microsoft Defender to ignore the "virus" but since this is the default behavior of Windows 11 now this could be an issue for new users who don't know anything.
### Expected behaviour
That the inst
...
💬 iotamega commented on issue "Windows 11 Blocks Install Due to "Virus Found"":
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067281777)
I had the same error. Be sure to not just disable Defender temporarily to get around the issue and start Bitcoin Core, it will later turn back on and kill the process again. To fully fix the issue you will need to go inside Defender and ALWAYS IGNORE the threat notification for the time being.
Otherwise things will start up just fine and run for a few hours before Defender freaks out and closes it down.
I believe the source is clean from a ten thousand foot review and this is a false posit
...
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067281777)
I had the same error. Be sure to not just disable Defender temporarily to get around the issue and start Bitcoin Core, it will later turn back on and kill the process again. To fully fix the issue you will need to go inside Defender and ALWAYS IGNORE the threat notification for the time being.
Otherwise things will start up just fine and run for a few hours before Defender freaks out and closes it down.
I believe the source is clean from a ten thousand foot review and this is a false posit
...
💬 hebasto commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067281851)
@iotamega
Your log shows a non-default number of connections:
> 2024-04-19T18:42:06Z Using at most 422 automatic connections (2048 file descriptors available)
However, it does not mention the `-maxconnections` option. Can you clarify this point please?
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067281851)
@iotamega
Your log shows a non-default number of connections:
> 2024-04-19T18:42:06Z Using at most 422 automatic connections (2048 file descriptors available)
However, it does not mention the `-maxconnections` option. Can you clarify this point please?
💬 iotamega commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067284813)
> @iotamega
>
> Your log shows a non-default number of connections:
>
> > 2024-04-19T18:42:06Z Using at most 422 automatic connections (2048 file descriptors available)
>
> However, it does not mention the `-maxconnections` option. Can you clarify this point please?
I am passing a higher maxconnections option because I operate a large number of nodes. I can likely lower that if we believe it is having an impact as I just selected an arbitrary high number because usually I just let th
...
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067284813)
> @iotamega
>
> Your log shows a non-default number of connections:
>
> > 2024-04-19T18:42:06Z Using at most 422 automatic connections (2048 file descriptors available)
>
> However, it does not mention the `-maxconnections` option. Can you clarify this point please?
I am passing a higher maxconnections option because I operate a large number of nodes. I can likely lower that if we believe it is having an impact as I just selected an arbitrary high number because usually I just let th
...
💬 hebasto commented on issue "Windows 11 Blocks Install Due to "Virus Found"":
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067287149)
This is false positive.
For example, https://github.com/bitcoin/bitcoin/issues?q=is%3Aissue+windows+virus.
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067287149)
This is false positive.
For example, https://github.com/bitcoin/bitcoin/issues?q=is%3Aissue+windows+virus.
✅ IAmAdamRest closed an issue: "Windows 11 Blocks Install Due to "Virus Found""
(https://github.com/bitcoin/bitcoin/issues/29917)
(https://github.com/bitcoin/bitcoin/issues/29917)
💬 IAmAdamRest commented on issue "Windows 11 Blocks Install Due to "Virus Found"":
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067290867)
Thanks for the clarification, I added to always ignore and it started without issue.
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067290867)
Thanks for the clarification, I added to always ignore and it started without issue.
💬 hebasto commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067300160)
@iotamega
> ### Expected behaviour
>
> To be able to right click and ban known bad acting peers without a crash.
Is the issue reproducible when you're using `setban` RPC, for example in the Console tab?
> I am passing a higher maxconnections option...
How?
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067300160)
@iotamega
> ### Expected behaviour
>
> To be able to right click and ban known bad acting peers without a crash.
Is the issue reproducible when you're using `setban` RPC, for example in the Console tab?
> I am passing a higher maxconnections option...
How?
💬 iotamega commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067307693)
> @iotamega
>
> > ### Expected behaviour
> > To be able to right click and ban known bad acting peers without a crash.
>
> Is the issue reproducible when you're using `setban` RPC, for example, in the Console tab?
>
> > I am passing a higher maxconnections option...
>
> How?
I haven't tried from the console but will next time I come across one of these fake clients trying to overwhelm my node which seemingly happens every few hours.
After I had issues with the binary I downloa
...
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067307693)
> @iotamega
>
> > ### Expected behaviour
> > To be able to right click and ban known bad acting peers without a crash.
>
> Is the issue reproducible when you're using `setban` RPC, for example, in the Console tab?
>
> > I am passing a higher maxconnections option...
>
> How?
I haven't tried from the console but will next time I come across one of these fake clients trying to overwhelm my node which seemingly happens every few hours.
After I had issues with the binary I downloa
...