Bitcoin Core Github
43 subscribers
122K links
Download Telegram
💬 pinheadmz commented on pull request "doc: update release-process.md":
(https://github.com/bitcoin/bitcoin/pull/29645#discussion_r1573048851)
Mine as well also include the parent directories, there are two `detached-sig-create.sh` between`macdeploy/` and `windeploy/`
💬 iotamega commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067390572)
Just updating to add that using the RPC method does not cause a crash further making me think this is QT related somehow.
⚠️ hebasto opened an issue: "Apple Clang 14.0 lacks support for `std::is_eq`"
(https://github.com/bitcoin/bitcoin/issues/29918)
```
% cat test.cpp
#include <compare>

int main()
{
double foo = -0.0;
double bar = 0.0;
return std::is_eq(foo <=> bar);
}
% clang++ -std=c++20 test.cpp
test.cpp:7:15: error: no member named 'is_eq' in namespace 'std'
return std::is_eq(foo <=> bar);
~~~~~^
1 error generated.
% clang -v
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Libra
...
📝 JonathanTylerCombs opened a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
⚠️ khnt2x3 opened an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)
### Please describe the feature you'd like to see added.

I'd like to see gen=0|1 added back into Bitcoin Core aka Satoshi Clients.

### Is your feature related to a problem, if so please describe it.

I learned about gen=0|1 growing up.

So, when I was working with the random person on mIRC #Math Channel. I specifically knew I want gen=0|1 added to the system, one, for the Adult Gaming Industry, two, because it just made sense to have this contrary to not.

Today the default mining mo
...
achow101 closed a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)
📝 JonathanTylerCombs opened a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are a
...
📝 achow101 locked a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
achow101 closed an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)
:lock: achow101 locked an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)
achow101 closed a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)
📝 achow101 locked a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are a
...
💬 fanquake commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067565383)
We'll be dropping support for this compiler as soon as oss-fuzz rolls their Clang, and we bump our minimum.
⚠️ Spire83 opened an issue: "Issue Title"
(https://github.com/bitcoin/bitcoin/issues/29922)
<!-- Edit the body of your new issue then click the ✓ "Create Issue" button in the top right of the editor. The first line will be the issue title. Assignees and Labels follow after a blank line. Leave an empty line before beginning the body of the issue. -->
willcl-ark closed an issue: "Issue Title"
(https://github.com/bitcoin/bitcoin/issues/29922)
💬 Lastat22 commented on issue "Proposal for a new mempool design":
(https://github.com/bitcoin/bitcoin/issues/27677#issuecomment-2067606886)
Change is always good find new horizons develops character builds new path ways to be newly enlighten is the key in life new knowledge means growth growth means productivity proverb lastat 22 aka Mnt man
💬 1440000bytes commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2067609951)
> I guess I should add that I don't think the nodes returned by "seed.bitcoinstats.com" are good.
>
> My assumptions is that it's just caching all the nodes it's previously seen and not checking if they're still providing all the services it previously has.

I have stopped using these DNS seeds. I found only 2 useful when I last tested:

seed.bitcoin.sipa.be
seed.bitcoin.wiz.biz
:lock: fanquake locked an issue: "Issue Title"
(https://github.com/bitcoin/bitcoin/issues/29922)
💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067656695)
Tested e79c54456f3e299a619a46451a4ce5a017b8da44.

I've verified compiler flags for CMake vs Autotools without providing the `HOST` variable:
1. A new `-DMINIUPNP_STATICLIB` macro, which basically is Windows-specific and has no affect on non-Windows targets.
2. The `-fno-common` flag is being missed, however, it the default for both [GCC](https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fcommon) and [Clang](https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-cla
...
💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067666130)
Test e79c54456f3e299a619a46451a4ce5a017b8da44 continued.

Compiler flags for `HOST=x86_64-w64-mingw32` are OK, including correct `-D_WIN32_WINNT=0x0601`.

However, the commit e5a114ac762fb6ce331998e6d2730386b9dbc905 is broken, which is not good for the commit history:
```
$ make -C depends miniupnpc HOST=x86_64-w64-mingw32
make: Entering directory '/home/hebasto/git/bitcoin/depends'
Extracting miniupnpc...
/home/hebasto/git/bitcoin/depends/sources/miniupnpc-2.2.7.tar.gz: OK
Preprocessi
...