💬 davidgumberg commented on pull request "doc: fixup help output for -upnp and -natpmp":
(https://github.com/bitcoin/bitcoin/pull/28874#issuecomment-2045114437)
ACK https://github.com/bitcoin/bitcoin/commit/92f88a962908c49dde99c03a4608e63e4a6eec71

Configured `--with-natpmp` and verified the help messages.

```console
$ bitcoind --help

[...]
-natpmp
Use NAT-PMP to map the listening port (default: 0)
[...]
-upnp
Use UPnP to map the listening port (default: 0)
```

Verified that modifying `bool DEFAULT_UPNP` and `bool DEFAULT_NATPMP` changes the `--help` output.

💬 laanwj commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1557583470)
aside: might be better to not use size_t at all for file offsets, as the type is 32 bit on usual 32 bit platforms

💬 glozow commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1557583670)
👍 I think this interface is better if the caller knows what the requirements are but can otherwise put whatever args they want

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1557587565)
moved and added assertion of empty mempool after restart

💬 laanwj commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1557592239)
do we want to sanity check for encryption to be disabled? (didn't know bdb supported db-level encryption in the first place)

👍 fanquake approved a pull request: "build: Change MAC_OSX macro to __APPLE__ in crypto"
(https://github.com/bitcoin/bitcoin/pull/29834#pullrequestreview-1988981666)
ACK a71eadf66bed8d3ea4282c8499f533a8eeed9900

💬 maflcko commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2045134493)
rebased

💬 maflcko commented on issue "valgrind: Conditional jump or move depends on uninitialised value(s)":
(https://github.com/bitcoin/bitcoin/issues/29635#issuecomment-2045231903)
https://bugs.kde.org/show_bug.cgi?id=485276

💬 real-or-random commented on issue "Fuzzer enhancement: Explicitly check output for uninitialized memory":
(https://github.com/bitcoin/bitcoin/issues/22064#issuecomment-2045244702)
> Alternative solution that also works with Valgrind: write the data to `/dev/null`:

There's also `VALGRIND_CHECK_MEM_IS_DEFINED`, see also https://github.com/bitcoin-core/secp256k1/blob/master/src/checkmem.h for an abstraction layer that works with both MSan and Valgrind.


---

What's suggested in this issue, i.e., reporting every read of an uninitialized value, may just be too much. The [Valgrind FAQ](https://valgrind.org/docs/manual/faq.html#faq.undeferrors) says this:
> As for eage
...

💬 theuni commented on pull request "[WIP] libevent @ master + use CMake":
(https://github.com/bitcoin/bitcoin/pull/29835#issuecomment-2045257973)
I'm confused about this error. sigaddset should come from `<signal.h>`, which is included from `"evsignal-internal.h"`.

💬 stratospher commented on pull request "test: Extends wait_for_getheaders so a specific block hash can be checked":
(https://github.com/bitcoin/bitcoin/pull/29736#discussion_r1557701025)
inserting an `assert "getheaders" not in p.last_message` fails here because it received a new header after those checks. and the block hash doesn't change here.

💬 stratospher commented on pull request "test: Extends wait_for_getheaders so a specific block hash can be checked":
(https://github.com/bitcoin/bitcoin/pull/29736#discussion_r1557701131)
oh good point.

✅ achow101 closed a pull request: "Bugfix: configure: Correct check for fuzz binary needing a main function"
(https://github.com/bitcoin/bitcoin/pull/28564)

✅ achow101 closed a pull request: "Bugfix: Package relay / bytespersigop checks"
(https://github.com/bitcoin/bitcoin/pull/28345)

💬 achow101 commented on pull request "Bugfix: Package relay / bytespersigop checks":
(https://github.com/bitcoin/bitcoin/pull/28345#issuecomment-2045293951)
Closing as up for grabs due to lack of activity.

✅ achow101 closed a pull request: "net: Add new permission `forceinbound` to evict a random unprotected connection if all slots are otherwise full"
(https://github.com/bitcoin/bitcoin/pull/27600)

💬 pinheadmz commented on issue "whiteconnections should be re-added":
(https://github.com/bitcoin/bitcoin/issues/8798#issuecomment-2045309981)
Proposed alternative to #27600 is a setting such that bitcoind listens for inbound connections but does not advertise itself

💬 achow101 commented on pull request "Safegcd-based modular inverses in MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/21590#issuecomment-2045311564)
Are you still working on this?

💬 achow101 commented on pull request "RPC: add new `listmempooltransactions`":
(https://github.com/bitcoin/bitcoin/pull/29016#issuecomment-2045315768)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes"
(https://github.com/bitcoin/bitcoin/pull/29050)
Implementation of OP_TXHASH and OP_CHECKTXHASHVERIFY, as per the [draft BIP](https://github.com/bitcoin/bips/pull/1500).

This MR includes a test using the test vectors generated from the reference implementation in the BIP.
The implementation utilizes a caching strategy that hopefully alleviates concerns around resource usage like quadratic hashing.

This MR on purpose does not make any consensus changes yet. Activation of the proposed opcodes will be coordinated in an independent MR, prob
...